Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e2afd4bde3e85db358d50553a60a744f.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230526-topic-smd_icc-v6-18-263283111e66@linaro.org>
References: <20230526-topic-smd_icc-v6-0-263283111e66@linaro.org> <20230526-topic-smd_icc-v6-18-263283111e66@linaro.org>
Subject: Re: [PATCH v6 18/22] clk: qcom: smd-rpm: Separate out interconnect bus clocks
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Marijn Suijten <marijn.suijten@somainline.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org,
        Konrad Dybcio <konrad.dybcio@linaro.org>
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Evan Green <evgreen@chromium.org>,
        Georgi Djakov <djakov@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>
Date:   Wed, 14 Jun 2023 17:48:06 -0700
User-Agent: alot/0.10
Precedence: bulk

Quoting Konrad Dybcio (2023-06-14 11:04:37)
> The interconnect bus clocks are now handled within the ICC framework.
> They still however need to get a kickstart *before* we call
> clk_smd_rpm_enable_scaling(), or RPM will assume that they should all
> be running at 0 kHz and the system will inevitably die.
>=20
> Separate them out to ensure such a kickstart can still take place.
>=20
> As a happy accident, the file got smaller:
>=20
> Total: Before=3D41951, After=3D41555, chg -0.94%
>=20
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  drivers/clk/qcom/clk-smd-rpm.c | 278 +++++++++++++++++------------------=
------
>  1 file changed, 115 insertions(+), 163 deletions(-)
>=20
> diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rp=
m.c
> index 6e7f0438e8b8..0d1d97659d59 100644
> --- a/drivers/clk/qcom/clk-smd-rpm.c
> +++ b/drivers/clk/qcom/clk-smd-rpm.c
> @@ -498,13 +506,69 @@ DEFINE_CLK_SMD_RPM_XO_BUFFER(div_clk1, 11, 19200000=
);
>  DEFINE_CLK_SMD_RPM_XO_BUFFER(div_clk2, 12, 19200000);
>  DEFINE_CLK_SMD_RPM_XO_BUFFER(div_clk3, 13, 19200000);
> =20
> +static struct clk_smd_rpm *bimc_pcnoc_icc_clks[] =3D {

Can these be const arrays?

> +       &clk_smd_rpm_bimc_clk,
> +       &clk_smd_rpm_bus_0_pcnoc_clk,
> +};
> +
[...]
> @@ -1332,6 +1275,15 @@ static int rpm_smd_clk_probe(struct platform_devic=
e *pdev)
>                         goto err;
>         }
> =20
> +       for (i =3D 0; i < desc->num_icc_clks; i++) {
> +               if (!desc->icc_clks[i])
> +                       continue;
> +
> +               ret =3D clk_smd_rpm_handoff(desc->icc_clks[i]);

This API can probably take a const struct clk_smd_rpm pointer as well.