Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 15 Jun 2023 01:56:35 +0100
From:   Mark Brown <broonie@kernel.org>
To:     yixuanjiang <yixuanjiang@google.com>
Cc:     vkoul@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
        tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] ASoC: soc-compress: Fix deadlock in soc_compr_open_fe
Message-ID: <92159f51-2e17-4c6b-8fd4-0bde8b1dd38a@sirena.org.uk>
References: <20230613062350.271107-1-yixuanjiang@google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="yfBNAdUiVMRgFxH8"
Content-Disposition: inline
In-Reply-To: <20230613062350.271107-1-yixuanjiang@google.com>
Precedence: bulk


--yfBNAdUiVMRgFxH8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jun 13, 2023 at 02:23:50PM +0800, yixuanjiang wrote:
> Modify the error handling flow by release lock.
> The require pcm_mutex will keep holding if open fail.

> +++ b/sound/soc/soc-compress.c
> @@ -166,6 +166,7 @@ static int soc_compr_open_fe(struct snd_compr_stream *cstream)
>  	snd_soc_dai_compr_shutdown(cpu_dai, cstream, 1);
>  out:
>  	dpcm_path_put(&list);
> +	mutex_unlock(&fe->card->pcm_mutex);
>  be_err:

This is really hard to follow due to the lack of any mutex_lock()s in
the function, I think because this is intended to undo
snd_soc_dpcm_mutex_lock(fe) but if that's the case why is it not using
snd_soc_dpcm_mutex_unlock(fe) like the success path does?  Given the use
of classes not doing that looks like it'll create lockdep issues.

I'd expect the unlock to match the lock.

--yfBNAdUiVMRgFxH8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSKYcMACgkQJNaLcl1U
h9AIFAf+LLNgL9osk++AWzcSBDBByXr2ksUuFuAjK9f/R7G+Slh2/w7hotCeNbFh
UxGQu0bkilmwhLUVwBbbyQhRCcXXJMXqDGBxbsVzJwwrq2Xw9IFlZx+Q2acg/Uce
j4XoOPvrnxNXIld5kAJmoHmVLrnwppge9wT1T/Bof9a5SqhcDOqjuYYv/Vbcta2+
KgPHAe6hRQ1SGjTyoP4fwYfTyikTtiBP9S32dMDGCzcxFGTFXovVMFNeXDgMwSRf
r8WH8jz8WD+dKuU3s39Wioe4AxWqDu7AsXOkU7zynAYlWDx8TvNOI0SVknZxpLf3
7ua6T/Hcp8DPaxgdmNjAkTTvG5Ferw==
=zGKJ
-----END PGP SIGNATURE-----

--yfBNAdUiVMRgFxH8--