Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Daniel Wagner <dwagner@suse.de>
CC:     "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Shin'ichiro Kawasaki <shinichiro@fastmail.com>,
        Sagi Grimberg <sagi@grimberg.me>,
        Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH blktests v1] nvme/040: Free loop back resources
Thread-Topic: [PATCH blktests v1] nvme/040: Free loop back resources
Thread-Index: AQHZnrE4w5/2y34gjUOOvl0fC4wVwa+KKOwAgAD8dgA=
Date:   Thu, 15 Jun 2023 02:30:46 +0000
Message-ID: <6vx4kyddssjo6lerd2biogylkrwrbtvnpaoajf3wfzsadosiyn@sefcrktyz3zr>
References: <20230612142945.10969-1-dwagner@suse.de>
 <bsbx3i3ut32zbatwrpn3t2vjbjdmttqul2jt7opd3s4mipo6pj@5ojtsv7aunbn>
 <pzgf2abc2piophrwt3m3elaeb3vrrgrvxyq437ytpmah6rnxf5@m4gfyw4bcmxo>
In-Reply-To: <pzgf2abc2piophrwt3m3elaeb3vrrgrvxyq437ytpmah6rnxf5@m4gfyw4bcmxo>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CdE6wxdzLAm+GqrLtn+dP+c2NBP9unGUKge9fi7ljZ7o27t0g7aS0qEQpYRd?=
 =?us-ascii?Q?SUaxwyZr4Nar1dhD/iJM//QoL9FshrTLmFaSQuSMJuGRrFJVb/DgZWr0qROT?=
 =?us-ascii?Q?Kh9ZNbDtXanEzye97vu5W/4YqUmi45nuUp+Ec//zKO2sVt3nJIXXWwsqPmCe?=
 =?us-ascii?Q?9Ajwc9dpmlBWEKue7DTdJjbP0LE+7xo9eEwrEc5T4yVLWmVABIy5H05lWv5I?=
 =?us-ascii?Q?1YDPtiI2ia8SY5kcWE9KXW0jXKoXn4D5N0b6AQDHIlNpO++WYZdvxfIr9FGg?=
 =?us-ascii?Q?pGBmNDTVSkKY4WRj+4pf+EPUotwb4R88bYrKI49iR6yehSrTPLWqbYHJIYLg?=
 =?us-ascii?Q?MSYEWJXuP7/tTkzRjS0Zo9vsVbswsh1oVHjLWnOKUhheif0a42JntoXcBEGO?=
 =?us-ascii?Q?lO45C9J37JhNtet1/8ej0FhcZsEJZWzFJDGFYR6+GAa00NRMYX9LbI7BIWyF?=
 =?us-ascii?Q?6fdl7kShgEFUv6maNvJJI13ttaBJrJeFMbECpQDmwmQCMhJN1qHELbxP5738?=
 =?us-ascii?Q?vGwDW1s2qjenlkadpL3r9gCb0R0pUNatCGmC8w7nNwGLS9SImLciFWZUOkCV?=
 =?us-ascii?Q?d5aIrh34O9sMGUUNEvixWep5diGAf0YJV8KZnhwaJ4ARM4JNUP/w+lpsIiT/?=
 =?us-ascii?Q?OtwxPkgOQrOKPCtX1n5e/0nGhkm6pjCMDmpj3uoE2nkpcooUZOsp0OVzW8Xu?=
 =?us-ascii?Q?pvEtGYAYzCH9JWoDWntSTnNmMuFC8cu3UYqonoFm/z4k0dlqMxWrQw78tHQB?=
 =?us-ascii?Q?ONnCUN3W7lKctLQtD4/R+a2EW0lFbx8KViJGJ2TzJNBGaXHkoFJd1XzQisW8?=
 =?us-ascii?Q?9ELCUhg5wx11j8enX2ZoEr16H8VhtVlA9S2DvyEB+oTb0LdrvNIDDdwmHqUw?=
 =?us-ascii?Q?EMSe5vVphYaVFyLOxfiE7QjkjihvwPylT2bHsSbg5Dgzhvf1BceVil2NUsnW?=
 =?us-ascii?Q?lsHI7+exwwiT3xSN4GBNMZJkBwHzii+E/DB677r7SEid/naYCPq21jcY2u4c?=
 =?us-ascii?Q?40lZ3YOLYfaKvvuvpmS2qXZtRG75YHB03FMy0oFg896nBhxebmufZrtmDFzb?=
 =?us-ascii?Q?lVkAiTj0K6HsNX4DLnCPFvrh3hx5uhmaC8FnRzh5DxdqdFXdy25F0JYOWGjA?=
 =?us-ascii?Q?HlETY/z/xjfJRgljwcMViZ2AlBZ9oI+6TjLP/Nm8wlF+cl58mcDm6IFLzG0N?=
 =?us-ascii?Q?z24GBwxyP02FnBXG2PxjzFshdLiY3mSubTw3ez4NGz+OQNtdElL5dAiPRcU8?=
 =?us-ascii?Q?fFtAVJyQIzMvOoH9Ou2CvHqvAYSggdRgpNH+VnmGtBYvAmd5N2iGN6e6Q7Su?=
 =?us-ascii?Q?uDXpZKQqE+7uSKeTsly7hiwiBLVq8PUm+e58Va87uKpY/sBu1VFwLZa79y10?=
 =?us-ascii?Q?lUZZnesZnVoRrte1viLl0YZaE0ug5RFJduRzNrlCHpWDPnuRKnpJ/t1Hd5p0?=
 =?us-ascii?Q?hcdlSDBRgUbc/6MhJLbEcuT7Cz0xfvZ4YLMjrJ2zCRZieFqksHjPvbuwFR9s?=
 =?us-ascii?Q?ZlgGEe6onUatItjGzSR636bv04wu9zfIxQNLZxuw64O7aEt8PD8IzGCM6tXN?=
 =?us-ascii?Q?1nK6t5qgT1vXlsTTRqCfBZgbDRUDNJBBxx3iPfQTziyrS69pDE9PqlgnoJ0+?=
 =?us-ascii?Q?JixIHo1KGnm/w/7ui/tza00=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <DAABDAB5C834B04FBFCE2352A066FA83@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?aJ2aR7PQrGXsfZnmF6XU56J8noUywWSj0j5Pjhsp9J5AVWrXz3tAegw65JmZ?=
 =?us-ascii?Q?0pDvl+SRqZen/IYziI9Z6lrZxiLqLpM7k8tssYM2dl4mOTMbKwGK4k1LZgwI?=
 =?us-ascii?Q?xOLqf4tzCCkOg+Alo0DlGm6DCySbY8gqwRUVA01WYNxF6pI2sMC9MDfoUSqQ?=
 =?us-ascii?Q?kwc6odbO3aheGXFV2zqUIg1C2U0UqGGAl/ED9I7K1Jm3k6kYKpJ0ANSMaHl7?=
 =?us-ascii?Q?zThg6+IrB55KBEcfzAgg2DntBYJkTb11DpuU/HQK8p7B0dn3+5BOfR/Yausj?=
 =?us-ascii?Q?XEjntssKLL2D3D2yV7SUBSYXPwyKajxOhbdz0HeRSgi8Fup0t9F88SYoIBu3?=
 =?us-ascii?Q?AYU/NbQK7qphJE1Xzw7gLXZZWOpZSK4x2jVA6dSShxp+wV+F0uy3POfRtyNS?=
 =?us-ascii?Q?+1NmfeZyAU182mcpi0ZzIkLQBEIzFcaQ+2Gh43sliW21XmusIRXoXE8AoQrN?=
 =?us-ascii?Q?7s8dGgK9dmjZfGDhbjFbAcmmGlF8gb0gFg4OK41L6EuPJAij72t6k2rtv7oI?=
 =?us-ascii?Q?0hfJb/R+1LACWaU/BWrTjnZdXQeKtYTWOOu0/INZsqcoQ9wAZVkYKu25DqSQ?=
 =?us-ascii?Q?4scTKJ+dryfzcODcCv5OwqwdsCO/LWIhfJVImFy+Z5ItMNm/R1zryAFjcmzm?=
 =?us-ascii?Q?Z3WpY/g6Z/GpWbr08Orq/YDUh1Ti1yIzuvMJ8eztWKZLfX3EgD+IRxbIwynG?=
 =?us-ascii?Q?c8IETJrLKxZJ0GMb8aJAhlMdY40DpBAseZrGsUjeqEdTR2pdhDSpCVHrI3Lk?=
 =?us-ascii?Q?b+RwEh25nJHJPkdLU9cVXNvglncKSY/pkk9ni3c5EWpitKMK+hdc7k7FAqlY?=
 =?us-ascii?Q?UHqnG73EEXIQuNpa95rJlcUsfrGEaP3ZDTF1TP0KpWAricmkudrvugXBU8g3?=
 =?us-ascii?Q?IqRqjl4khwb3dw82491qYb++qCYfRMqdIyTUgBiNNOorLfm5QWd8jyfZiocj?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6973cc50-bd77-493e-b3c8-08db6d4886c2
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2023 02:30:46.8967
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bjhtH5YV5CRifLzyKPptMmrZEgHa4lkZ12HOOYSHHeLvpJiaaNhNkP+y0gcTdAOtQLIHpbJ/3FT5Vm+EXQI0D85+5bAV9Ct9BGPNTHHOAXA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR04MB7695
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Jun 14, 2023 / 13:27, Daniel Wagner wrote:
> On Wed, Jun 14, 2023 at 11:13:18AM +0000, Shinichiro Kawasaki wrote:
> > On Jun 12, 2023 / 16:29, Daniel Wagner wrote:
> > > The tests does not cleanup all resources after it has finished. This
> > > leads to rm not being able to remove the TMPDIR cleanly:
> > >=20
> > >   + rm -rf blktests/results/tmpdir.nvme.040.m2J
> > >   rm: cannot remove 'blktests/results/tmpdir.nvme.040.m2J': Directory=
 not empty
> > >=20
> > > Signed-off-by: Daniel Wagner <dwagner@suse.de>
> >=20
> > Hi Daniel, thanks for the patch. It looks good to me. Now the test case=
 leaves a
> > loop device. This patch avoids it. Good.
> >=20
> > Question, I do not observe the rm command failure in my test environmen=
ts. Do
> > you have insight why you were able to find the failure?
>=20
> I am running the tests inside a VM and I am sharing a part of my host fil=
esystem
> via NFS which contain the blktests. If I understood it correctly, the NFS=
 server
> is behaving slightly differently here. I can't observe it either with xfs=
 or
> btrfs.

I see, the NFS sounds triggering the failure. I've applied the patch. Thank=
s!=