Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230609083009.2822259-1-wenst@chromium.org> <20230609083009.2822259-8-wenst@chromium.org>
 <a5c00706-dc23-4561-8bcf-729fd10e74ef@sirena.org.uk>
In-Reply-To: <a5c00706-dc23-4561-8bcf-729fd10e74ef@sirena.org.uk>
From:   Chen-Yu Tsai <wenst@chromium.org>
Date:   Thu, 15 Jun 2023 11:24:42 +0800
Message-ID: <CAGXv+5HWM_mfKp-o8kOyZ7W8yqZwBwPF3QNwo5sBfuv4quc-vQ@mail.gmail.com>
Subject: Re: [PATCH 7/9] regulator: mt6358: Add output voltage fine tuning to
 fixed regulators
To:     Mark Brown <broonie@kernel.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jun 15, 2023 at 12:15=E2=80=AFAM Mark Brown <broonie@kernel.org> wr=
ote:
>
> On Fri, Jun 09, 2023 at 04:30:04PM +0800, Chen-Yu Tsai wrote:
> > The "fixed" LDO regulators found on the MT6358 and MT6366 PMICs have
> > either no voltage selection register, or only one valid setting.
> > However these do have a fine voltage calibration setting that can
> > slightly boost the output voltage from 0 mV to 100 mV, in 10 mV
> > increments.
>
> This and the followup patch break the build on both arm64 and x86_64:
>
> /build/stage/linux/drivers/regulator/mt6358-regulator.c:127:29: error: =
=E2=80=98MT6358_VFE28_ANA_CON0=E2=80=99 undeclared here (not in a function)=
; did you mean =E2=80=98MT6358_VIO28_ANA_CON0=E2=80=99?
>   127 |                 .vsel_reg =3D MT6358_##vreg##_ANA_CON0,   \
>       |                             ^~~~~~~

Argh, I sequenced the patches in my tree incorrectly. I see you already
merged the first six patches. I'll send a new version including a header
change that this patch needs, and other fixups that reviewers suggested.

ChenYu


> /build/stage/linux/drivers/regulator/mt6358-regulator.c:525:9: note: in e=
xpansion of macro =E2=80=98MT6358_REG_FIXED=E2=80=99
>   525 |         MT6358_REG_FIXED("ldo_vfe28", VFE28, MT6358_LDO_VFE28_CON=
0, 0, 2800000),
>       |         ^~~~~~~~~~~~~~~~
> /build/stage/linux/drivers/regulator/mt6358-regulator.c:127:29: error: =
=E2=80=98MT6358_VCN28_ANA_CON0=E2=80=99 undeclared here (not in a function)=
; did you mean =E2=80=98MT6358_VCN18_ANA_CON0=E2=80=99?
>   127 |                 .vsel_reg =3D MT6358_##vreg##_ANA_CON0,   \
>       |                             ^~~~~~~
> /build/stage/linux/drivers/regulator/mt6358-regulator.c:526:9: note: in e=
xpansion of macro =E2=80=98MT6358_REG_FIXED=E2=80=99
>   526 |         MT6358_REG_FIXED("ldo_vcn28", VCN28, MT6358_LDO_VCN28_CON=
0, 0, 2800000),
>       |         ^~~~~~~~~~~~~~~~
> /build/stage/linux/drivers/regulator/mt6358-regulator.c:127:29: error: =
=E2=80=98MT6358_VXO22_ANA_CON0=E2=80=99 undeclared here (not in a function)=
; did you mean =E2=80=98MT6358_VIO28_ANA_CON0=E2=80=99?
>   127 |                 .vsel_reg =3D MT6358_##vreg##_ANA_CON0,   \
>       |                             ^~~~~~~
> /build/stage/linux/drivers/regulator/mt6358-regulator.c:527:9: note: in e=
xpansion of macro =E2=80=98MT6358_REG_FIXED=E2=80=99
>   527 |         MT6358_REG_FIXED("ldo_vxo22", VXO22, MT6358_LDO_VXO22_CON=
0, 0, 2200000),
>       |         ^~~~~~~~~~~~~~~~
> /build/stage/linux/drivers/regulator/mt6358-regulator.c:127:29: error: =
=E2=80=98MT6358_VAUX18_ANA_CON0=E2=80=99 undeclared here (not in a function=
); did you mean =E2=80=98MT6358_VRF18_ANA_CON0=E2=80=99?
>   127 |                 .vsel_reg =3D MT6358_##vreg##_ANA_CON0,   \
>       |                             ^~~~~~~
> /build/stage/linux/drivers/regulator/mt6358-regulator.c:528:9: note: in e=
xpansion of macro =E2=80=98MT6358_REG_FIXED=E2=80=99
>   528 |         MT6358_REG_FIXED("ldo_vaux18", VAUX18,
>       |         ^~~~~~~~~~~~~~~~
> /build/stage/linux/drivers/regulator/mt6358-regulator.c:127:29: error: =
=E2=80=98MT6358_VBIF28_ANA_CON0=E2=80=99 undeclared here (not in a function=
); did you mean =E2=80=98MT6358_VIO28_ANA_CON0=E2=80=99?
>   127 |                 .vsel_reg =3D MT6358_##vreg##_ANA_CON0,   \
>       |                             ^~~~~~~
> /build/stage/linux/drivers/regulator/mt6358-regulator.c:530:9: note: in e=
xpansion of macro =E2=80=98MT6358_REG_FIXED=E2=80=99
>   530 |         MT6358_REG_FIXED("ldo_vbif28", VBIF28,
>       |         ^~~~~~~~~~~~~~~~
> /build/stage/linux/drivers/regulator/mt6358-regulator.c:127:29: error: =
=E2=80=98MT6358_VAUD28_ANA_CON0=E2=80=99 undeclared here (not in a function=
); did you mean =E2=80=98MT6358_VA12_ANA_CON0=E2=80=99?
>   127 |                 .vsel_reg =3D MT6358_##vreg##_ANA_CON0,   \
>       |                             ^~~~~~~
> /build/stage/linux/drivers/regulator/mt6358-regulator.c:535:9: note: in e=
xpansion of macro =E2=80=98MT6358_REG_FIXED=E2=80=99
>   535 |         MT6358_REG_FIXED("ldo_vaud28", VAUD28,
>       |         ^~~~~~~~~~~~~~~~