Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     Gao Xiang <xiang@kernel.org>, Chao Yu <chao@kernel.org>,
        Yue Hu <huyue2@coolpad.com>,
        Jeffle Xu <jefflexu@linux.alibaba.com>
Cc:     Yangtao Li <frank.li@vivo.com>, linux-erofs@lists.ozlabs.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] erofs: remove unnecessary goto
Date:   Thu, 15 Jun 2023 11:45:38 +0800
Message-Id: <20230615034539.14286-1-frank.li@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ztc4Aa6zc19EWDYsvz3aT5rURQg1yLIQBb+DzQRiSTKdyp/zbQXwQ3dkLqct?=
 =?us-ascii?Q?YRRXZ4R6iBb8arhpBHNzLf5ZvnS5ZyCDjuh2ZhHs0LyrBUkpo/oghFukS+1L?=
 =?us-ascii?Q?5YniC4bYB5YXWadZxPY6beGiQbbolECXfa7FvkP172xiH/+FEUCtWcaky/4e?=
 =?us-ascii?Q?7t6005hc6Xem46txsrKMxJ+a5b7f8Y+oQCy9adu9rCl/ojulslJSmve0R9Cw?=
 =?us-ascii?Q?SNZiurbmNSBE566cVO2IJZq07XRPC9x/Bn5DKFN0U5m0kI3fn2uXchRacG+v?=
 =?us-ascii?Q?9yHU9Fmk2IZStbjXM59SSseuhTgxDaaOQ0+IJ8HRiOJFHr9IjuvM7Kcy+lTb?=
 =?us-ascii?Q?gx+gvfUiqj4MaNZnmae4qJns7IXWUgHurFhRTNNEIPUOJ0hbK9WcxKFEVig+?=
 =?us-ascii?Q?9Z3HbGS/Cjf0E0V0PEQHJNeTQMHOvoITHw43yh2bCqYQVLWbOWCF2kWcbjVD?=
 =?us-ascii?Q?FcPtxHT5+uQixleifJd6gVgo8sIEEFpjRX2mNgG8Y6tnHE0LdhinmlD+8BXH?=
 =?us-ascii?Q?VR9yBQCODN4OBZ/9qnCuMz7dSdhCKXYhBHR9/vqsd/Fe9iVxaI2PT5wjB7PT?=
 =?us-ascii?Q?dhr+pc+fIJ0DLgi7n+Kr0YWMgdKsSjtdWwmDLTlyQhyD0+8QUkPZHkgSJKXP?=
 =?us-ascii?Q?7pY4ckoUlaxdT0ZUNAfSr71nZq19Okt7p8DAfSXFWQHspCNCleoNdBaVmXA1?=
 =?us-ascii?Q?ZBDlLy3Z1hsv5R4KDSu9u08whXtI/0m0++F9JY8Icd8UeXYEwcF/nJ1oCQ7L?=
 =?us-ascii?Q?x/6Ar1AIXd7KTVibaWuVCtDA1/K+PjkSuY12KUQa/uzsxBrq0IBuOT/zv0DU?=
 =?us-ascii?Q?1VoxIzrCTIvQEW5MczqE1fl3jsTAVTDqKjnvkOxh674F0bCJcakeZtf8VELn?=
 =?us-ascii?Q?H4XbZd8JW1YARhckhOmFt/vixG4w7uxvUJLfA44z9cfUV9rxV61I89Hz5l26?=
 =?us-ascii?Q?drbwjIJNveIwn77ovVpe1cZOYdLBZVu8TSI/4JI9ucLsb/JpiO35y+HDvIhm?=
 =?us-ascii?Q?pCnXZphfpnxFteQKVvuM6q0oR479n+cKpGlP2ITCUvB4i8L539r/lWmiw6et?=
 =?us-ascii?Q?Ll777RBs+UQGVakryaxtRjmHiUD3YNpdqxRQZ3f5n3kH0fPOf1XehZ70N02H?=
 =?us-ascii?Q?1hDw8mLbqhykyL0PgKZPnTk1HrMKQXWvWvtz7I5npC5VUIXIEE0ShOI1pq6p?=
 =?us-ascii?Q?dNsMl9+7Obn+lWbZgcvdKK2wIRMyHIGAs4eecphwp7s9MDKMNsZS4A1KM1Rn?=
 =?us-ascii?Q?jNaQ3fFc0IcNnYyLS/CvO8kOi4+SAs6k7Hbcp53ZFamYb2WlCAY1pfxCqoqa?=
 =?us-ascii?Q?LTI2niQPIxPnGcH26qRsasSWcy7l/+kdOxToJeE8/OLk3hJk8DJe/wLBs2Bq?=
 =?us-ascii?Q?k9k52E3QQFgWlyc0ZBInFVlRTqBJwGkJFb1bxhFJCW61uAYYMzKFgE358wY7?=
 =?us-ascii?Q?yaqHS2sdDTLdMEN8hboRaVvJG3rlIKLqYpwzGAkxBVRCGRGxrFc4nqSE8f+R?=
 =?us-ascii?Q?qlgpCec8sl9vOuq+roM1bQfqoBubU3p+ddCBm6wpC4A3iZZzhirrzqQAdrwZ?=
 =?us-ascii?Q?M49uFf1P2YU97GD5OMpDgA+CI01DPEBcGPrNcR9L?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a58ca942-8b5b-4361-a940-08db6d53068f
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 03:45:56.5936
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bVFiI0/BgfPd5cJpjb3lAI477aMhmLdk2HZ/bjuzHAMrUDzKkeyrHTnlsKWDmYdGDKmVqo0aXu+1lyreHyLQyQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PSAPR06MB4534
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

It's redundant, let's remove it.

Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
 fs/erofs/super.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 811ab66d805e..f48ce692094d 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -1016,10 +1016,8 @@ static int __init erofs_module_init(void)
 					       sizeof(struct erofs_inode), 0,
 					       SLAB_RECLAIM_ACCOUNT,
 					       erofs_inode_init_once);
-	if (!erofs_inode_cachep) {
-		err = -ENOMEM;
-		goto icache_err;
-	}
+	if (!erofs_inode_cachep)
+		return -ENOMEM;
 
 	err = erofs_init_shrinker();
 	if (err)
@@ -1054,7 +1052,6 @@ static int __init erofs_module_init(void)
 	erofs_exit_shrinker();
 shrinker_err:
 	kmem_cache_destroy(erofs_inode_cachep);
-icache_err:
 	return err;
 }
 
-- 
2.39.0