Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6b49563d-e9e7-ae8e-582e-f4aead06de0a@intel.com>
Date:   Thu, 15 Jun 2023 10:05:10 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915/display/lspcon: Increase LSPCON
 mode settle timeout
To:     Pablo Ceballos <pceballos@google.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
CC:     <intel-gfx@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
        <dri-devel@lists.freedesktop.org>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Sam Ravnborg <sam@ravnborg.org>
References: <20230614235452.3765265-1-pceballos@google.com>
Content-Language: en-US
From:   "Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>
In-Reply-To: <20230614235452.3765265-1-pceballos@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OVVhN3d6bFdrdEVYRHVNYU1uSWZSZUttbU1xVS8rK3RHN3hORVNDYzFSTjM1?=
 =?utf-8?B?MHZHMHlKZ0V3c0FWYzQ0VENMY0p0RDk2ZzQ0RWo5SmMvZFpIQlhvQlVkTlh0?=
 =?utf-8?B?a2NuQktlMVo0VnRTTmVJczN1dFI4STR4RGQ4MWtXd3lLaEorTDhzZzVDRzg2?=
 =?utf-8?B?MXBKeitWaHJWdzRrQ3hYckZXR0M0V2x5OTE2dmtjSEtZblNjYi8vK3E0eUlB?=
 =?utf-8?B?cG5KQzZCeXptQ0xJVjNrbkZ3amtHTVBHcFkySHJiSE1KUWlmNFdVN090VVpq?=
 =?utf-8?B?T3JuSERsQjJPRk9GcHVmRUdnNTZuYlNqOVJnRW1RRFZOcW85dHlYUUh2RlJP?=
 =?utf-8?B?QkI2TXN6WTNxZ2xFUlliNmxrd3NKZGhQMTBMaEN5YkszdjFWaXQydEJUWHhx?=
 =?utf-8?B?NmdEakxoaXpPRUN0WkU5dTRDU3NvMktIRG9XWkVkbGkxYk9ETXV3S3dHNk9X?=
 =?utf-8?B?dTF2L2pVZGs2RVM2Y2ozeHUyWU5uQkt4c1VaaVZQeXkwWVk2RjFhdzRwTW0x?=
 =?utf-8?B?M25jQWFIeXVuelh0Q0pDVGp5eTRySEhsZmZzVjNCV2ZadHVQRUJQQ1FkT3Rt?=
 =?utf-8?B?VGhWbE9sMWFMUmQ4RFdXdG1nbkdLc3Z5MTFWMjR2L3JLeGlnSzZMSWZ2QTF0?=
 =?utf-8?B?WkVCWTdsbThTOVBBb1ZVQUJqQndEU0pqdUxESm55M2dRaTJ5UGxxZUZ2VW1s?=
 =?utf-8?B?by9xbzFJeC9MS0lTSHNVUlBBRnBHa0FqbHVRTjUrd0tvNXNnQTY2b0MwTDlT?=
 =?utf-8?B?UzB5TFhVMFdjcU9abFRGYkg3QzUxSUpqZFNkMGNaRk8wRHNVVHRUOEhIUWR6?=
 =?utf-8?B?WGVqQVUwbjhHQTJMQzdhZ3ErZnJZZXcxSXhsZldCQlZtU1dDcnJnc3VWa0RL?=
 =?utf-8?B?RHozeWY5MWlnSkN3L3lHd3BhWkNTamw2dHIwV2ZuMFNORUZlalFlN2tpUUUw?=
 =?utf-8?B?WUU0N1Y0Sk41TDZuU2JHRnlWZUlEeE5WS1E4UENWSSt2TkxxeEpUN2Q0bG5B?=
 =?utf-8?B?NmdzN2dwc0k3L25xVkdNTHE1VXdGV2h0Qloydjd6TGR2TWdQNWxKeWo4Y3E0?=
 =?utf-8?B?ZHVxNGQ2UFVaM1NiR1hQOFM2RlkxS2JNQ0t4Q2FMNWFJYzFvcy8zdm8vTVdx?=
 =?utf-8?B?cGx3MFJKdEFxbEQ2eGVkclhGTFNoVEdwTCtvc0FnL0UwRGt3L3NFUWJWVGZK?=
 =?utf-8?B?eFIxclhtemYvOUtSbzNVRW9vRDlCMW9MSlpMa29RT1JCbGFhbWY5SUFKSnly?=
 =?utf-8?B?ZkErVXlQT1ZIQWpnb2M1RGY0cHJGdTdUNHozZWpBdjZ6OC9JWG9CUmkyS0s1?=
 =?utf-8?B?Wm5RRzg3bkRBekJFN0c3SVJ4Y1VrQVVacnNtNmlXZFN1UHpzWklZTFV5VVY4?=
 =?utf-8?B?emVjWitUQm9EL0poREJmMDVVZG5RUzdMVjBYL0RLRGsxaDFmM3EwYmNEbW5E?=
 =?utf-8?B?SXN0VkZib3JGcWNXbWhtYzluUnFTZUd6NGtlN3NUK0o5ZmRmNVZRUktRVmxN?=
 =?utf-8?B?SzJLMXBaUm9INjlnemRLbzZ1NGpYaXE0N2QxUDI0Q25rM1ppRFJBV09MSmFR?=
 =?utf-8?B?UzVzdWd0N255ZVozQ1kzemNaUWxCaE1RaGh4MUowcytrR3UvNEU3NzZoK2NI?=
 =?utf-8?B?Mll6anVGMnd2Q1N1KzJmUkhSenNNUnFoWlFkSmVRSDhkZU1TRTlvTmlGUUw5?=
 =?utf-8?B?d20xeElLLzZBSFV3Z3c1R3J2QkNiNWNCVmxPc0hsb3kwSmNWamc1REtLSk4x?=
 =?utf-8?B?QWpKTGdzSlRxcUFLUTQrOHA2ZHJjUkJab3ExVEdJTVdqZytlR29qVFpsTGNB?=
 =?utf-8?B?d2thMmZVMGdJK3FhNmM1V0MzOTh3RFFqS1Y5UndBV2tBVGhkRERPcUJ5R0dK?=
 =?utf-8?B?TE8xSk1CdUNwYkJRT2o3Z1crRnEvaHFEdmJ2UlFlSVUxYkVudW1pY2V0MzVV?=
 =?utf-8?B?dlpITkhwZTZ3eTFHMXhSeExCRkhnSDFqa1pKQmZtcXNmZm5Zc0tBYk9GckVW?=
 =?utf-8?B?aFc1RW12TGNFM0o2cmU5b21YUHM5Y1ZEZkY0QnZPL0RKTXl3YytJbE5QajNE?=
 =?utf-8?B?czdOcFpGWUU0b2o3MjdmQnY4aWJqREJaZXVsbk5SS0daN1QwQUttRXd4b2Ny?=
 =?utf-8?B?ZXZ4WDllZkl2Wk1PRUFPZFo2eXdnWmFKeStyelZOQ1BpTGpRSGJJT0dMZjl6?=
 =?utf-8?B?UHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ef41b6b-8fdf-4314-e470-08db6d59edf1
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5341.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 04:35:21.8302
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JqiJqYYrWpi0Tb2E6aXNFpAqCp7MSxnWb0RRBVjeAWiEAVDFBcqoahAQKIyJWnuwvSNyo7nK1VwMrpVzW0SDH7pupHMY2/ul4aldAhlVvlM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6421
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/15/2023 5:24 AM, Pablo Ceballos wrote:
> This is to eliminate all cases of "*ERROR* LSPCON mode hasn't settled",
> followed by link training errors. Intel engineers recommended increasing
> this timeout and that does resolve the issue.
>
> On some CometLake-based device designs the Parade PS175 takes more than
> 400ms to settle in PCON mode. 100 reboot trials on one device resulted
> in a median settle time of 440ms and a maximum of 444ms. Even after
> increasing the timeout to 500ms, 2% of devices still had this error. So
> this increases the timeout to 800ms.

In one of the gitlab issue, it was tried with 1000ms as well, situation 
did improve, but issue didn't get fully resolved. [1].

I was wondering if trying to set LS/PCON mode multiple time will have 
any effect.

Unfortunately I do not have access to machine with Parade LSPCON chip, 
had suggested in yet another git lab issue [2].

I have a patch for this, sent to try-bot, though not sent to intel-gfx 
yet [3].


The timeout value was already increased from 100 ms to 400 ms earlier too.

If there is indeed no other way, perhaps need to have this solution.


[1] https://gitlab.freedesktop.org/drm/intel/-/issues/4516#note_1406500

[2] https://gitlab.freedesktop.org/drm/intel/-/issues/4458#note_1922654

[3] Patch : 
https://patchwork.freedesktop.org/patch/538819/?series=118208&rev=1


Regards,

Ankit


>
> Signed-off-by: Pablo Ceballos <pceballos@google.com>
> ---
>
> Changelog since v1:
> - Added more details in the commit message
>
>   drivers/gpu/drm/i915/display/intel_lspcon.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c
> index bb3b5355a0d9..d7299fdc43ad 100644
> --- a/drivers/gpu/drm/i915/display/intel_lspcon.c
> +++ b/drivers/gpu/drm/i915/display/intel_lspcon.c
> @@ -167,7 +167,7 @@ static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon,
>   	drm_dbg_kms(&i915->drm, "Waiting for LSPCON mode %s to settle\n",
>   		    lspcon_mode_name(mode));
>   
> -	wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 400);
> +	wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 800);
>   	if (current_mode != mode)
>   		drm_err(&i915->drm, "LSPCON mode hasn't settled\n");
>