Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp643329rwd; Wed, 14 Jun 2023 23:20:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ54cNeECYQLon5NMSusLZtjzuG3LfFZaKgqXkZbZiE0O/celuDWiRkkUs1ShdCeGRoGyioq X-Received: by 2002:a17:90a:19cb:b0:256:33ba:8f5f with SMTP id 11-20020a17090a19cb00b0025633ba8f5fmr2793340pjj.36.1686810012305; Wed, 14 Jun 2023 23:20:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686810012; cv=none; d=google.com; s=arc-20160816; b=csmif4LKOUqt8y7dtG/b/Tx4bEN0cDFFWGONObUa+63b2GFjRqLjlmDtcUUJfA4Wq7 sbRV3yfYEwJw8DBDCpYGBWfedGJoS+jrSIlFSDmLGMGdTr47+7a25NPXeYmgaB0ZXxNS G0MkXCudabHCCK8ZlF2YW5L5IvpFyTwdpY4ywhCwQIeQfcF+RmiZy7fyXO6cz7m1MkoJ xlUrSuRNcuhTIF6C+1pauXBlQlHr5NfeA9ZfVe1o6QGJEG0+KpVbUnHt/zlUBV2lWyoO mBl/WcapC5tAnrql3wsOjiJto8EgFcij1nTY6zgsSDhtXZNsesRSaL9Jmj85uNB7p2bY Yc0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=3g/QkDN7rwkKXaUR94a6uJ3ThDlUWtDgdh1jKQIOpuc=; b=e0S9HDOwY7adgd6bvSEiAf0CkmC1h0iTs6aHKYDAKoEQVscOsEfTs+tEiUFaeIayc7 Z1t6eFAttNkoj+GT7DkL5gLSvGWUpFZ+mPdU2CY0AXpDflHwvVKtKfzzfXELy5u1N4+e 5AZ5a08jabjpWf/GeCov2nNzM2FWmII/eJeCL/MwUF6ubdPoWxHKJ+680chmlhZi1nk3 0Mym5GmtIpxuWYBJP7XgNn6yK2MXcrgLwBcaTpmhW0nWa1LvDzappYQZT+JD78pLZK5B PCnGp1qFpVIn57BPk64zA1S3fKEQr+rLb0e2eOLRxmutOhnW50izT4jCxNdVW5lcYaH4 1KxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="CGNr6G/z"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c29-20020a63725d000000b0053fb3bd8ee3si12135012pgn.806.2023.06.14.23.19.36; Wed, 14 Jun 2023 23:20:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="CGNr6G/z"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243492AbjFOGDj (ORCPT + 99 others); Thu, 15 Jun 2023 02:03:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243264AbjFOGDF (ORCPT ); Thu, 15 Jun 2023 02:03:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27BC32716 for ; Wed, 14 Jun 2023 23:02:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 84BDE62964 for ; Thu, 15 Jun 2023 06:02:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7429BC433C0; Thu, 15 Jun 2023 06:02:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686808961; bh=fE+EH/4fj3DJZDVn9ec0SNsTOWyotHaRxtT2lAgs+ZI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CGNr6G/zzyvYn6sOEvvyJP4hyUtej5y42IbPSwRd9kxmtdFmfIMJ3+BHXVmObmh0t 7Aqu5niW+4rpKNtdD33jsOr4sOn5gU5XLDKRiWmOqFH0A0ATXQTHGs1AxSxPWiOch8 6AUEVQIeAtlczmaQk5aVwbyCBE5Q6qCoEFA/o++WkLpuz5gUIC/Uls2QhRCOc6pILk MZaC6Uqcrg14qsWfEY31VHkKbu1EX66LSpUwQjbG1JnwJml61For+8D4tcSqzZOaJi Tx1a6js1sSJV2C8dLAlpBdKnHAc7Yvfp06zjcWcaPR83fsa+5tKTuNB6OXAMJ/ZVyg L84i96kBx8Sqw== Date: Wed, 14 Jun 2023 23:02:39 -0700 From: Jakub Kicinski To: Sabrina Dubroca Cc: Fedor Pchelkin , "David S. Miller" , Eric Dumazet , Paolo Abeni , Raed Salem , Lior Nahmanson , Saeed Mahameed , Hannes Frederic Sowa , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org Subject: Re: [PATCH] net: macsec: fix double free of percpu stats Message-ID: <20230614230239.02c388a8@kernel.org> In-Reply-To: References: <20230613192220.159407-1-pchelkin@ispras.ru> <20230613200150.361bc462@kernel.org> <20230614090126.149049b1@kernel.org> <20230614201714.lgwpk4wyojribbyj@fpc> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Jun 2023 23:15:03 +0200 Sabrina Dubroca wrote: > It's been 7 years... your guess is about as good as mine :/ > > I wouldn't bother reshuffling the device creation code just to make > the handling of rare failures a bit nicer. Would you be willing to venture a review tag?