Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230615001735.3643996-1-kan.liang@linux.intel.com> <20230615001735.3643996-7-kan.liang@linux.intel.com>
In-Reply-To: <20230615001735.3643996-7-kan.liang@linux.intel.com>
From:   Ian Rogers <irogers@google.com>
Date:   Wed, 14 Jun 2023 22:58:11 -0700
Message-ID: <CAP-5=fVooOBWHWa8=73uS+eS1kW-qF5cp=WRV5O83SRE=oC6wQ@mail.gmail.com>
Subject: Re: [PATCH V2 6/8] pert tests: Update metric-value for perf stat JSON output
To:     kan.liang@linux.intel.com
Cc:     acme@kernel.org, mingo@redhat.com, peterz@infradead.org,
        namhyung@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        ak@linux.intel.com, eranian@google.com, ahmad.yasin@intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jun 14, 2023 at 5:18=E2=80=AFPM <kan.liang@linux.intel.com> wrote:
>
> From: Kan Liang <kan.liang@linux.intel.com>
>
> There may be multiplexing triggered, e.g., e-core of ADL.
>
> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/tests/shell/lib/perf_json_output_lint.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/tests/shell/lib/perf_json_output_lint.py b/tools/=
perf/tests/shell/lib/perf_json_output_lint.py
> index 5e9bd68c83fe..ea55d5ea1ced 100644
> --- a/tools/perf/tests/shell/lib/perf_json_output_lint.py
> +++ b/tools/perf/tests/shell/lib/perf_json_output_lint.py
> @@ -66,10 +66,10 @@ def check_json_output(expected_items):
>    for item in json.loads(input):
>      if expected_items !=3D -1:
>        count =3D len(item)
> -      if count !=3D expected_items and count >=3D 1 and count <=3D 4 and=
 'metric-value' in item:
> +      if count !=3D expected_items and count >=3D 1 and count <=3D 6 and=
 'metric-value' in item:
>          # Events that generate >1 metric may have isolated metric
> -        # values and possibly other prefixes like interval, core and
> -        # aggregate-number.
> +        # values and possibly other prefixes like interval, core,
> +        # aggregate-number, or event-runtime/pcnt-running from multiplex=
ing.
>          pass
>        elif count !=3D expected_items and count >=3D 1 and count <=3D 5 a=
nd 'metricgroup' in item:
>          pass
> --
> 2.35.1
>