Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jose Abreu <Jose.Abreu@synopsys.com>
To:     Christian Marangi <ansuelsmth@gmail.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Jose Abreu <Jose.Abreu@synopsys.com>
Subject: RE: [net PATCH v2] net: ethernet: stmicro: stmmac: fix possible
 memory leak in __stmmac_open
Thread-Topic: [net PATCH v2] net: ethernet: stmicro: stmmac: fix possible
 memory leak in __stmmac_open
Thread-Index: AQHZnthZIpDsy937hU25DOLowXgjL6+LZJkA
Date:   Thu, 15 Jun 2023 06:18:46 +0000
Message-ID: <DM4PR12MB50880561EC92E25F6A721944D35BA@DM4PR12MB5088.namprd12.prod.outlook.com>
References: <20230614091714.15912-1-ansuelsmth@gmail.com>
In-Reply-To: <20230614091714.15912-1-ansuelsmth@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8vhHdNbZ1SwkX//uLmi7JnFISX/KxjxdfuOKyy1GmFcQ3A6UomBjlAFr1h2z?=
 =?us-ascii?Q?mPDMJyP9yDUaphaLd2O4JmtytU7yGMt25t8XAhHtxVYPxNr73ZRWqgnsQyMB?=
 =?us-ascii?Q?wvGKJQoJAX7C+4q+mXfZdjp2TarocZlKjHnTGIuT+j0VqqGNUZde1uduRjaN?=
 =?us-ascii?Q?JedzFalcpWcjF+yjPhsNkIoL7L6g8C+N/SXchpCKFDmcUYHhfd+yGmxyUt50?=
 =?us-ascii?Q?MzGzHwL5znWc1j3JHUZ7KgR8LFN5yy0o3e+UiedwNRVGmKFrxbuIrKZqfmpX?=
 =?us-ascii?Q?JiVYvsEtYsouANV0UwMbG93BMUZ6xvB/jrcusuCsWXL4PIjU4tg+l0caDoSY?=
 =?us-ascii?Q?OWeHMWTkvoUf+N6UNFvcsvfFKd26DbJKXfX86k5DOJbU0H8AV3OWCHRbhpqH?=
 =?us-ascii?Q?X8lsmu+m6kmmSjjDe6blqTMvpObPNbgO9MIBQXUTNbk7BovGsdzjtgNzus9y?=
 =?us-ascii?Q?kiFLNy89feuHmqEeHid8OwpIgBEyYPzBvgrXK1MRUpsiSK9YCbzidmQ+DXBX?=
 =?us-ascii?Q?bQ4KWHVurwo5uZIR3lei0IgU3de9/zwYXWEg/AMJFmB6j0SqQKPmznzX9apq?=
 =?us-ascii?Q?FxrwLgnJkdfKerXpEu4u8V9f0iV6Wb/Ji1eG6TNYAq4U2s1X5JrmxBNmN+qE?=
 =?us-ascii?Q?wvbK8smWnF+YoJ6x6mPf/o9Eodw1fEll6S7GW8jY3IcV6yCLI/pJe1tsdRUb?=
 =?us-ascii?Q?sd73yZEeKOP9XyjKywGZvJgePMzub2eqeymhosaM/dKG9pfUwp1ofInJNt+y?=
 =?us-ascii?Q?2NC29TWlL/FrplaczRLmOgkWnm3WqFHIFvbP5zifZ+aZBT6TEqxxLAXdZ/qM?=
 =?us-ascii?Q?ylfhOhWgM6GYNeXdEEzExyXsu8MBzRrURTWI0aN+5wreDGG051Rw9cLQcDlH?=
 =?us-ascii?Q?+uXUJpNrJMJrjawH29By/zjAF4jsi0nypUK6jvdJzrxdpprA206jC4W/IjZC?=
 =?us-ascii?Q?LwXOc4Vx5ceRkLDjdwwq/gDkTVwkl1UmHchDEHjQk1eKC0uf4VrcaAgZBlV6?=
 =?us-ascii?Q?rScQvGYQTJbHKw2dygsvOpCgUZbqhY/BE8yY216SWeMlvnr8RNvxUPVjDPYo?=
 =?us-ascii?Q?Km5Vz6WMePldWajWnNQ49Ma49bB8S4M7vnRoy8EX73gfLFVuIToAIVvf2tcN?=
 =?us-ascii?Q?Ylbn+HH559veTDeju95ockYxmwveUlk8Rhm6jHY9L+23OxZNjQBaVt7pEAkp?=
 =?us-ascii?Q?7nRQARMaXp+Yaq6rjg1lOw/uC2Mcz5Hy++KlIO3HB7VkoqYayAj5u9+qA/bn?=
 =?us-ascii?Q?/MKWt4TaIXK9AIShdscyWjdXo+I9pnl1r5w07kBhl3w9/WUw9927fIu3qsS9?=
 =?us-ascii?Q?j9Ch4oWYSGVLG90TFOSK/4dYhoFLo1dUEkHRAdsydyx3kzZydUpYGV3ACIT9?=
 =?us-ascii?Q?gmF5ih5xk712AA1knnXCqq9MVB6pw6qrOGIomct5btNQLu+f5BESMlQPbp1u?=
 =?us-ascii?Q?TgKJJ6Xj6gQauhdMMRnUYfFp2sEq6WruIVwPtMf4mw8kDoxzX69heTjPPjp5?=
 =?us-ascii?Q?beMi5HrWoClanbOpwoI9COBk/CvnIxF6rLHJcLu82aRgqOp7/hrt5abtdA?=
 =?us-ascii?Q?=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?v45zOlt6Zh+U9lYHyBIw5hLYdu2vBjQTCZqOpetg+rw0xizo/sM+QmzvMKti?=
 =?us-ascii?Q?BEK26IOFUK3VcRLcBNodHNn/arUkXjALJ4ShRHOcfP6LOvTe1Sir5pCrYC9R?=
 =?us-ascii?Q?T5yBSperZ2J56ccrdJZBLblUqigotWDDjYtoUqThmAZssh9byG1pfmtdw0Yn?=
 =?us-ascii?Q?3MZo1I2xfz+QGRbmIdZOXKzIoyVXvS+hxtabw4UZxGEHrxoeKfgHfo+Ys/nv?=
 =?us-ascii?Q?v/fulML2hP+vrdX39c/eQ3T8RuqPRjq055/mkwTE9b1N2fmeyfLo2WG/L0Zc?=
 =?us-ascii?Q?yKVNgtH1w8FBUbTzmqg34pZPoTELBSEMkC5SXWoS8inzLjMOL/SEBt2OgwV/?=
 =?us-ascii?Q?akWbmdA7BLGWR3G262k5/bS4BGLobpd9f0e5KFeP4iw+umVW1KeU/hsWdfLR?=
 =?us-ascii?Q?W62MyMURDMwSGsAbaLGdcBIcGkIni4y3zegJMSksZSV2RkGcndNjie2ZZYL2?=
 =?us-ascii?Q?2q7zCR5C/dSfNWibiAm3LKNti1HpJJisqUX4+PWjq/9pIANci5MLso+q0hPL?=
 =?us-ascii?Q?q2hP+46N/A/gGK5Qq8hswKsGDlZRy9j8xajsARlhBc2YrIydVptXzcHQnVFL?=
 =?us-ascii?Q?nSKVx26gdSwb0aIMxzvGh6vvbhVL3oWrprweCfN5pFOpNaQy/3KEyzPvYI22?=
 =?us-ascii?Q?4YfRNn/z6HObWF9Z6gQKj7Rbq2OzaCoTDenGceymPzf5nZ1QgEiPYbalcvS7?=
 =?us-ascii?Q?D0vVQFeKkPqygAL2wy8tNkNF6OKmkDr/3x2qIuVSfoUjenTfABm2MTalZB/0?=
 =?us-ascii?Q?LHcN2SHbQeJE8JXpx6EujSLdqpZB6/n3bi29HISIWjBkV5p3Uzi52rCM/L2X?=
 =?us-ascii?Q?8Pi2vAzj1BEmbPLyu1IzkhaLp3VbwiYnOUMWENXB9A3dZzZMMGi76bN1zf4+?=
 =?us-ascii?Q?pPsheraKypwcoykcNpGEb1twJYgsVb9TzVc7jqmRLy2z1e38appKN2FNCwsh?=
 =?us-ascii?Q?vePHfzVU3JJu9GfQrLlYpIMBpggx0a+wcnZw8r7DR2SqkQ5BH5gjhmSjb7HC?=
 =?us-ascii?Q?D5RoVt4bikDI68k2K4zjpVKOGsiJsibH1q2lUmlTAjsTec71Tp/jgLLCng43?=
 =?us-ascii?Q?A0b+2l13TN435qBdQz/KRZbentgyIoENuafAti7nA+puWQ42EYgrhQVuFolS?=
 =?us-ascii?Q?V1UL8nOWy9JsjkI3oiMNuciFWx1TOFZNB6hrBLqXxRnZGBBVSYMlO2I=3D?=
X-OriginatorOrg: synopsys.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5088.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78c83ebb-658b-4005-767b-08db6d68603f
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2023 06:18:46.1697
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: c33c9f88-1eb7-4099-9700-16013fd9e8aa
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MFEwKPsFI0mXa91SBW18LCUBQv9SzxHSDn+0s3dN5qxZeIQiw1oaEvPuyRUkzkoeV4/wlHE+8g32nPkGMp86Sw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7734
X-Proofpoint-GUID: jL7MwNQffBFLAnOM5BWIQPAIomqEn2hX
X-Proofpoint-ORIG-GUID: jL7MwNQffBFLAnOM5BWIQPAIomqEn2hX
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26
 definitions=2023-06-15_03,2023-06-14_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_active_cloned_notspam policy=outbound_active_cloned score=0
 priorityscore=1501 phishscore=0 lowpriorityscore=0 mlxlogscore=999
 spamscore=0 impostorscore=0 suspectscore=0 mlxscore=0 clxscore=1011
 adultscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0
 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2306150052
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Christian Marangi <ansuelsmth@gmail.com>
Date: Wed, Jun 14, 2023 at 10:17:14

> Fix a possible memory leak in __stmmac_open when stmmac_init_phy fails.
> It's also needed to free everything allocated by stmmac_setup_dma_desc
> and not just the dma_conf struct.
>=20
> Drop free_dma_desc_resources from __stmmac_open and correctly call
> free_dma_desc_resources on each user of __stmmac_open on error.
>=20
> Reported-by: Jose Abreu <Jose.Abreu@synopsys.com>
> Fixes: ba39b344e924 ("net: ethernet: stmicro: stmmac: generate stmmac dma=
 conf before open")
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> Cc: stable@vger.kernel.org

Thanks for the fix.

Reviewed-by: Jose Abreu <Jose.Abreu@synopsys.com>

Thanks,
Jose