Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e63e6d33-6659-b63f-2716-c347aba7f525@amd.com>
Date:   Thu, 15 Jun 2023 11:33:57 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v2 2/3] perf mem amd: Fix perf_pmus__num_mem_pmus()
To:     Ian Rogers <irogers@google.com>
Cc:     acme@kernel.org, jolsa@kernel.org, namhyung@kernel.org,
        peterz@infradead.org, james.clark@arm.com, alisaidi@amazon.com,
        leo.yan@linaro.org, adrian.hunter@intel.com,
        kan.liang@linux.intel.com, mark.rutland@arm.com,
        maddy@linux.ibm.com, tmricht@linux.ibm.com,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        sandipan.das@amd.com, ananth.narayan@amd.com,
        santosh.shukla@amd.com, Ravi Bangoria <ravi.bangoria@amd.com>
References: <20230615051700.1833-1-ravi.bangoria@amd.com>
 <20230615051700.1833-3-ravi.bangoria@amd.com>
 <CAP-5=fWkzHufJXV-iRAGifv_z11AOc5LKOyL-QvYL_N+gSPvzw@mail.gmail.com>
Content-Language: en-US
From:   Ravi Bangoria <ravi.bangoria@amd.com>
In-Reply-To: <CAP-5=fWkzHufJXV-iRAGifv_z11AOc5LKOyL-QvYL_N+gSPvzw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzJrY1o2SE9mS2pRaVhQRHYvNUY0WUFxS251YmdxUzdiSkVjQXdRSE56Ymg0?=
 =?utf-8?B?dlphckhzNWJhd0pRTlZmcFgrWlQ3cDNaT1ZKUXBDZzVPdUdOZ1NHQWNLVDdm?=
 =?utf-8?B?NFZlRmRJR3JvUWJHMHduTEtDN01JcHJiOFhZeGs0a2taL1pGbVVWSkJvZk13?=
 =?utf-8?B?R2xNeDdYM3RBMnlXNW0xWlJGVjlIaEd4R2doSE85UzN1VCtJanlLOGJNYi9z?=
 =?utf-8?B?SW1ybHNCcDVQVWUrOEg5alFCcGRBYXoyZ0FPanZMQXFmajFrY25ra3h4SFNr?=
 =?utf-8?B?YTU0S1pWenBRa1ZIL2xLMUEvWTNlZ1VKVjRVakljRlhzdDhwOG81blVBYnox?=
 =?utf-8?B?eHJaSFZpMTlscS9GR3VkMHMwUXFqYWFlT1EzRWpZR2JCUVVjdnA4UmJTWDlF?=
 =?utf-8?B?Z2F0cnAzYmpKeTBpT3ByR2JFVnVkMHdobUhhU3h0bGY3LzVib2lpZElGWFdi?=
 =?utf-8?B?ejhsaEhsM2xucXFyWXVKUTQybXpyWi9RWnNpSmk4anY1cDBuZjRyd0FrelVu?=
 =?utf-8?B?TEwwbkhYYXpsQTJ5NStFcUhDVWJadGxTL2VxY2JTSlJkNmJDOHIzMWI0WGlq?=
 =?utf-8?B?NHlLSUJjRnNwTjVPNHVRTGtQUm1rYjdNZUVqMXc3SWRpSEw0OXIwL0FreXhH?=
 =?utf-8?B?bVVIbGFBYlp2VkdzRjlkeWllUmlQMFd1R1d4N2d2ZU5NQ29NaGYvNGtONGVp?=
 =?utf-8?B?a0cxZVlJNGJJN0s3QVRpRk1MMjFtTDZlcVp0QWkyY3ZmTElZakxDTzU5UzJ0?=
 =?utf-8?B?bWZrT2crbjRSRFZZL2JFd0dvZWpuUm1FdElqWmRiS3dSUmlxVDNVdndoZjBT?=
 =?utf-8?B?K045Zjg1Q1UwRnMxSlVqZWdoQ1RRcmZOMmdNR0o2RkhOdmhRQUNNVWVKWTkw?=
 =?utf-8?B?OGJGaGd5Qk0wN0lhZ0Y3ZlJKdmNrYXJoa0VlL0tteGZjbGxFbzhjdzJHanBX?=
 =?utf-8?B?VkZTakhseXI0T2lrd2JmWWZrd2FEQ3pUSjlWbFlEZDc2K1YzTURZblVRdjJj?=
 =?utf-8?B?aWptWFNXZlZjMWFQSm9wODJsZENEaEtGb01malVrTUZLeUFaTFJzd2JUTWNQ?=
 =?utf-8?B?cTFEUXNPVDNwTzNVU1hjSFdQYUlXRXE3Wi93SWhIeTZjUzhNMWxIRXBlSEUw?=
 =?utf-8?B?Y0IwRjhZR2QwNTRxajF5REhVcDdGK0ViNGc1SFRhT1N1amZyYnd4MG8wRGky?=
 =?utf-8?B?UW1OaVVKNityZXRNTmtVTUYyeUQwbEJQbmZQRHBJNk9zRFpqNzlINFpsaFBi?=
 =?utf-8?B?ZkRBR2tQVmVPTWNNeXpiQit6dk1GUk92UDk4NDdVZjk0K0E2a3NHcGZaS2ZO?=
 =?utf-8?B?MFZ1ZEFBQnFFSnlmNEkzY1BTS1E4dHF4MFdrSzBGT1I2Kzc4K3FiaFBYU0px?=
 =?utf-8?B?dXpBN0ZHRHltMVJmckdITm5haHZzaEg4VFJoV2hPQXZ4UlJzaHQrYy80Y0k5?=
 =?utf-8?B?c1hyTjhzK2UzNXYrR016SDg5MHBRZHl6WTFiV0VnNlRUQThIRU5MYVNMVW41?=
 =?utf-8?B?VDloS1YwSUVXNEY3c2dyTUJ4YnpKd0gxTEVYdXQreVNaNU5KYnkvM3JiVG4y?=
 =?utf-8?B?c2czcXZRakJaQm5OdlNCc3RxcGNXZVdVVThKOHR3NXorTU8zR3dITUg1YTNp?=
 =?utf-8?B?Z0p3WjNXZ3ozYWV5cnBKWkxwSXdJbWZINU52UFZoaGlKWVRaSU5jZ1pFcEhE?=
 =?utf-8?B?OFdLU2FhR2lZRVJxUmZsK0kzWHppeEhmbk9vV2FRb1dQQ2kzTm00QktRUytj?=
 =?utf-8?B?bU4zTGhnc0VVUXdWM0Q4L3BZam5hdUNiOUdWbG53bzhJU2xzcjJMYUtLRDB5?=
 =?utf-8?B?UFowdE9lYUMyZnR4WDJXRjJsSysvdlhxVXVWZGROVlBLcWQzayttczlNNVFX?=
 =?utf-8?B?TVErZ1JxZHFtRS92aEt6V2RlTzV4eUNEYjRPVnA3SnpiY3djaXhaeWVJSVVx?=
 =?utf-8?B?TS9BTDdCODdSb3BXaGdoM2xOalp6Qm43cWxURzdNVGFJZVNKVkw2Tms2UVl0?=
 =?utf-8?B?N1c1T3ZNNkpWYTBrMXNnclU3c01RN1c5aTVMTlBFby9DZEkvSGNCWWtrZFNU?=
 =?utf-8?B?RGZnZnpyWld3dGF2cWxaVjVBbXJvbjZaL0NIWjJFcXRETVl6UDRmdXlyWkhz?=
 =?utf-8?Q?n23QPinaw4ZP4YVS09Mjdkgd5?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e9920172-8fc7-44b8-910a-08db6d667ab3
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB6588.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 06:05:11.9888
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: k8urhlt91bderhmceETYaGrxc8Pj+neuGeV1JzxwO4V8yV1b5NUgWCfgcxWzs9DAN5XYGJUX+ciV35b4YElsrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7037
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> +int perf_pmus__num_mem_pmus(void)
>> +{
>> +       /* AMD uses IBS OP pmu for perf mem/c2c */
> 
> nit: could we just add:
> AMD uses IBS OP pmu and not a core PMU for perf mem/c2c

Sure.