Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b6ebaf92-39ed-01af-6aa9-52232a2e3ea7@ti.com>
Date:   Thu, 15 Jun 2023 11:52:22 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v2 4/5] arm64: dts: ti: add verdin am62 dahlia
Content-Language: en-US
To:     Francesco Dolcini <francesco@dolcini.it>,
        Nishanth Menon <nm@ti.com>
CC:     Francesco Dolcini <francesco.dolcini@toradex.com>,
        Tero Kristo <kristo@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230601131332.26877-1-francesco@dolcini.it>
 <20230601131332.26877-5-francesco@dolcini.it>
From:   Vignesh Raghavendra <vigneshr@ti.com>
In-Reply-To: <20230601131332.26877-5-francesco@dolcini.it>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 01/06/23 18:43, Francesco Dolcini wrote:

[...]

> +/* Verdin I2C_1 */
> +&main_i2c1 {
> +	status = "okay";
> +
> +	/* Audio Codec */
> +	wm8904_1a: audio-codec@1a {
> +		compatible = "wlf,wm8904";

This node doesn't have YAML bindings :(

> +		reg = <0x1a>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_i2s1_mclk>;
> +		/* POSTDIV4_16FF_MAIN_2_HSDIVOUT8_CLK -> AUDIO_EXT_REFCLK1 */
> +		assigned-clocks = <&k3_clks 157 10>;
> +		assigned-clock-parents = <&k3_clks 157 18>;
> +		assigned-clock-rates = <25000000>; /* for 48KHz ± 1.7% */
> +		clocks = <&k3_clks 157 10>;
> +		clock-names = "mclk";

> +		AVDD-supply = <&reg_1v8_sw>;
> +		CPVDD-supply = <&reg_1v8_sw>;
> +		DBVDD-supply = <&reg_1v8_sw>;
> +		DCVDD-supply = <&reg_1v8_sw>;
> +		MICVDD-supply = <&reg_1v8_sw>;

I dont see these properties in .txt bindings either.

> +		#sound-dai-cells = <0>;
> +	};
> +

[...]

-- 
Regards
Vignesh