Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 15 Jun 2023 08:41:52 +0200
Message-ID: <87r0qd8bwv.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Su Hui <suhui@nfschina.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Arnd Bergmann <arnd@arndb.de>, maciej.szmigiero@oracle.com,
        yangyingliang@huawei.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ALSA: ac97: Fix possible NULL dereference in snd_ac97_mixer
In-Reply-To: <20230615021732.1972194-1-suhui@nfschina.com>
References: <20230615021732.1972194-1-suhui@nfschina.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 15 Jun 2023 04:17:32 +0200,
Su Hui wrote:
> 
> smatch error:
> sound/pci/ac97/ac97_codec.c:2354 snd_ac97_mixer() error:
> we previously assumed 'rac97' could be null (see line 2072)
> 
> remove redundant assignment, return error if rac97 is NULL.
> 
> Fixes: da3cec35dd3c ("ALSA: Kill snd_assert() in sound/pci/*")
> Signed-off-by: Su Hui <suhui@nfschina.com>

Thanks, applied.


Takashi