Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, Wang Ming <machel@vivo.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com
Subject: [PATCH v1] drivers:net:dsa:Fix resource leaks in fwnode_for_each_child_node() loops 
Date:   Thu, 15 Jun 2023 15:04:58 +0800
Message-Id: <20230615070512.6634-1-machel@vivo.com>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ans2JvnZ7IESSDNaceCa75h8Jdd1lDQBLzqhBMHGmY0hjR3eVJHDGtEusqD7?=
 =?us-ascii?Q?tIcfJg1kJ2TPA2uwzoPMHsnVnR3AuIWGJjFc06h/LVY5V6/aTFrNYWf2MQRr?=
 =?us-ascii?Q?AARet0LfSFp0wm3Tkf7X1xtSVC8jySb02gCewQ+8Wf/71bfm7nlQlMWt8wH2?=
 =?us-ascii?Q?qrefwlt31yiOco++swCbWfsESQAYWvHGpQ9ZVEXJ2HFHXkspuQoYbZq03Veg?=
 =?us-ascii?Q?mE55Pl2qUYCwuf7iuelVey2HqwccvuK/VYxt8e3EeodaG/SB111Pv8j2lFUF?=
 =?us-ascii?Q?pMleOrS6SnuTbexhQ9sSnQGgzfr7AXJJNRLP8XJ5q8sONqTbda6/w3HQP2O7?=
 =?us-ascii?Q?XbTeHxkCDWmnnfrpni+7BNIvWavwYQyrx49B34S73gUXPm1LYztUZL3uodpL?=
 =?us-ascii?Q?T2RYl2eqgsk5cMXiHtVJMyyMDqXGyIm+EtVUOeONQ5Rkk3gkuoKVw52w6pl6?=
 =?us-ascii?Q?73vamztNC7SxL53W18SUA4d3NYi0af9qkIqndx2be4GUdzDrybd6I1QvJGlk?=
 =?us-ascii?Q?dgBT96oeEu/mmJ/MyslH2uJ0uiJlqZmOdbRUWAAXYlaJypSiUT8MWTjY4CSD?=
 =?us-ascii?Q?CK5dvDkZib4wkhpje6l+Z1m02l9Neb25PKesL1Pf8kODPnTVCfYedX+ieUny?=
 =?us-ascii?Q?QgdAyWg7bhZjjQ3BVNFISTZtggX8ofVLJfuOLoT5rq6t8D5pzjZEW9hIoiPt?=
 =?us-ascii?Q?fLZTMRAZTwTsNDdttm3+iHehTYzXMKW8ZhvU/RdlUMq0klzbmIXYrI4OSt2W?=
 =?us-ascii?Q?papvepIdZWB4+T0d54oZU7/QRaRkqhFewN5Fb8yN3NUamOcRrkizYdtB++9l?=
 =?us-ascii?Q?EQ5Etgiy5tArcwZO27zgMw26bpIYJa/POQGDywgXHYg5UyMhT9o+xjj43Wn0?=
 =?us-ascii?Q?cpnO0+tpTQro/yT7sEmDJ6FrijjIa9BW+i1yiqHWRVKaxVG7OHIQAdOozX+9?=
 =?us-ascii?Q?uD4RmaOyiUHljd6JttjUyVakJJ41L18HMwUi9H5f7d/NmNDR70q/+EZyBE6G?=
 =?us-ascii?Q?AOa7SzUVx35UbyEmAyivT7oAXVLDrC+5tQuhofJfIvIvQ2U0T0gHaIEqhXJg?=
 =?us-ascii?Q?2G8W/8CUVCPjPN35jq1j+Ee5IOnlkNPD1gURpczGLkUuZEhr8cTRcSviLZsq?=
 =?us-ascii?Q?/Gl+ZlXeY7noCv7T3IAIM5yckDABSTmK2QI25iPWF28wP5yPel5r4FTOT2YB?=
 =?us-ascii?Q?zlQmmBJggslctEr5oAjyAn9qI/HTgp9S5p1KId+trsRkQDXLXBuBjp0j5bae?=
 =?us-ascii?Q?69HsubNSryeHgR1PwESm2MLHPZB1CK4Ov3qTGN+q/Dep7SuxnrTXatnNMTds?=
 =?us-ascii?Q?O+YZZwEzE75oC64/NTzQl1SBjgxDDC0CjnxGH1W/eyc32U42ryFDuxjf/O51?=
 =?us-ascii?Q?zkFPPQtePNeElhfIbgjtyZGhW/1Ee3g0LKRkVdA6PkLrtuMBKa+5Df4TcFe3?=
 =?us-ascii?Q?TjkUkE1SrUHSvs4KBXlIEG4Ghn7PLbWXM6tm37chKcG0HTaCoVWhQc4QamKk?=
 =?us-ascii?Q?EHDOUqadYEk/GgtuEPNr8ndyGYGfgtNIGP8T1bKSUmfehlm1rI4snmb0zPpv?=
 =?us-ascii?Q?OfvLYjajUmIC7Xcpf0jHbNjetHIm4Hnm6VxlaxXw?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e2ed9da8-acda-400a-77f4-08db6d6f0879
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 07:06:25.6330
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dTg6AXjO40ONLc1aZIzDIQvvhf7F8/wXNtsfin/vZ7t8wbU73m0qR0/Q/g4XiRG8liThTuZ2sabja5n1QE8Sxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4100
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

 The fwnode_for_each_child_node loop in qca8k_setup_led_ctrl should
 have fwnode_handle_put() before return which could avoid resource leaks.
 This patch could fix this bug.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/net/dsa/qca/qca8k-leds.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/dsa/qca/qca8k-leds.c b/drivers/net/dsa/qca/qca8k-l=
eds.c
index 6f02029b4..d24ee5df9 100644
--- a/drivers/net/dsa/qca/qca8k-leds.c
+++ b/drivers/net/dsa/qca/qca8k-leds.c
@@ -450,8 +450,10 @@ qca8k_setup_led_ctrl(struct qca8k_priv *priv)
                 * the correct port for LED setup.
                 */
                ret =3D qca8k_parse_port_leds(priv, port, qca8k_port_to_phy=
(port_num));
-               if (ret)
+               if (ret) {
+                       fwnode_handle_put(port);
                        return ret;
+               }
        }

        return 0;
--
2.25.1


________________________________
=E6=9C=AC=E9=82=AE=E4=BB=B6=E5=8F=8A=E5=85=B6=E9=99=84=E4=BB=B6=E5=86=85=E5=
=AE=B9=E5=8F=AF=E8=83=BD=E5=90=AB=E6=9C=89=E6=9C=BA=E5=AF=86=E5=92=8C/=E6=
=88=96=E9=9A=90=E7=A7=81=E4=BF=A1=E6=81=AF=EF=BC=8C=E4=BB=85=E4=BE=9B=E6=8C=
=87=E5=AE=9A=E4=B8=AA=E4=BA=BA=E6=88=96=E6=9C=BA=E6=9E=84=E4=BD=BF=E7=94=A8=
=E3=80=82=E8=8B=A5=E6=82=A8=E9=9D=9E=E5=8F=91=E4=BB=B6=E4=BA=BA=E6=8C=87=E5=
=AE=9A=E6=94=B6=E4=BB=B6=E4=BA=BA=E6=88=96=E5=85=B6=E4=BB=A3=E7=90=86=E4=BA=
=BA=EF=BC=8C=E8=AF=B7=E5=8B=BF=E4=BD=BF=E7=94=A8=E3=80=81=E4=BC=A0=E6=92=AD=
=E3=80=81=E5=A4=8D=E5=88=B6=E6=88=96=E5=AD=98=E5=82=A8=E6=AD=A4=E9=82=AE=E4=
=BB=B6=E4=B9=8B=E4=BB=BB=E4=BD=95=E5=86=85=E5=AE=B9=E6=88=96=E5=85=B6=E9=99=
=84=E4=BB=B6=E3=80=82=E5=A6=82=E6=82=A8=E8=AF=AF=E6=94=B6=E6=9C=AC=E9=82=AE=
=E4=BB=B6=EF=BC=8C=E8=AF=B7=E5=8D=B3=E4=BB=A5=E5=9B=9E=E5=A4=8D=E6=88=96=E7=
=94=B5=E8=AF=9D=E6=96=B9=E5=BC=8F=E9=80=9A=E7=9F=A5=E5=8F=91=E4=BB=B6=E4=BA=
=BA=EF=BC=8C=E5=B9=B6=E5=B0=86=E5=8E=9F=E5=A7=8B=E9=82=AE=E4=BB=B6=E3=80=81=
=E9=99=84=E4=BB=B6=E5=8F=8A=E5=85=B6=E6=89=80=E6=9C=89=E5=A4=8D=E6=9C=AC=E5=
=88=A0=E9=99=A4=E3=80=82=E8=B0=A2=E8=B0=A2=E3=80=82
The contents of this message and any attachments may contain confidential a=
nd/or privileged information and are intended exclusively for the addressee=
(s). If you are not the intended recipient of this message or their agent, =
please note that any use, dissemination, copying, or storage of this messag=
e or its attachments is not allowed. If you receive this message in error, =
please notify the sender by reply the message or phone and delete this mess=
age, any attachments and any copies immediately.
Thank you