Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Subject: Re: [PATCH 3/9] MIPS: DTS: CI20: Add parent supplies to ACT8600
 regulators
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <20230604145642.200577-4-paul@crapouillou.net>
Date:   Thu, 15 Jun 2023 09:00:32 +0200
Cc:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, linux-mips@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        list@opendingux.net
Content-Transfer-Encoding: quoted-printable
Message-Id: <D6E7498A-3172-42C6-804A-CB5A323F91DC@goldelico.com>
References: <20230604145642.200577-1-paul@crapouillou.net>
 <20230604145642.200577-4-paul@crapouillou.net>
To:     Paul Cercueil <paul@crapouillou.net>
Precedence: bulk


> Am 04.06.2023 um 16:56 schrieb Paul Cercueil <paul@crapouillou.net>:
>=20
> Provide parent regulators to the ACT8600 regulators that need one.
>=20
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> arch/mips/boot/dts/ingenic/ci20.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>=20
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts =
b/arch/mips/boot/dts/ingenic/ci20.dts
> index 5361606c5e13..662796acda41 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -242,16 +242,19 @@ regulators {
> 			vddcore: DCDC1 {
> 				regulator-min-microvolt =3D <1100000>;
> 				regulator-max-microvolt =3D <1100000>;
> +				vp1-supply =3D <&vcc_33v>;

where is vcc_33v defined?

Unless [7/9] "MIPS: DTS: CI20: Enable support for WiFi / Bluetooth" is =
applied?

This way the patches in between can't be bisected.

> 				regulator-always-on;
> 			};
> 			vddmem: DCDC2 {
> 				regulator-min-microvolt =3D <1500000>;
> 				regulator-max-microvolt =3D <1500000>;
> +				vp2-supply =3D <&vcc_33v>;
> 				regulator-always-on;
> 			};
> 			vcc_33: DCDC3 {
> 				regulator-min-microvolt =3D <3300000>;
> 				regulator-max-microvolt =3D <3300000>;
> +				vp3-supply =3D <&vcc_33v>;
> 				regulator-always-on;
> 			};
> 			vcc_50: SUDCDC_REG4 {
> @@ -262,21 +265,25 @@ vcc_50: SUDCDC_REG4 {
> 			vcc_25: LDO5 {
> 				regulator-min-microvolt =3D <2500000>;
> 				regulator-max-microvolt =3D <2500000>;
> +				inl-supply =3D <&vcc_33v>;
> 				regulator-always-on;
> 			};
> 			wifi_io: LDO6 {
> 				regulator-min-microvolt =3D <2500000>;
> 				regulator-max-microvolt =3D <2500000>;
> +				inl-supply =3D <&vcc_33v>;
> 				regulator-always-on;
> 			};
> 			cim_io_28: LDO7 {
> 				regulator-min-microvolt =3D <2800000>;
> 				regulator-max-microvolt =3D <2800000>;
> +				inl-supply =3D <&vcc_33v>;
> 				regulator-always-on;
> 			};
> 			cim_io_15: LDO8 {
> 				regulator-min-microvolt =3D <1500000>;
> 				regulator-max-microvolt =3D <1500000>;
> +				inl-supply =3D <&vcc_33v>;
> 				regulator-always-on;
> 			};
> 			vrtc_18: LDO_REG9 {
> --=20
> 2.39.2
>=20