Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp710332rwd; Thu, 15 Jun 2023 00:33:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5IiHvlRR9Ek9AlQOgu7eE4LKIYBBpZMJppd6XRaIapqySp3Qxas+gEr9LuyOoJmOi1fmAu X-Received: by 2002:a05:6a20:428c:b0:119:38a8:63d2 with SMTP id o12-20020a056a20428c00b0011938a863d2mr4186138pzj.1.1686814414205; Thu, 15 Jun 2023 00:33:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686814414; cv=none; d=google.com; s=arc-20160816; b=KH1Wox3YfBIdwbrZnuvFiCQ5/wTONgK/M9EOv9vgzVUrGREIn+a+szsRw5VlTe87Ai ll/G+V/1vHxG10RCkVCC4jeRaVXTlNdJCLcz1StGQAsn/PBXc9YIubEEOsR+rD503j6j gsfu1n1Kx1W4FKUqmAVTInidw3rCIYuLb8Ih4xehJo5AVQUa4u41UI0RNp9yS6Dz9zgq 5U9nH9HIVtLYJNA3Tcsr6llouKTi0rvkVdA+0NRLXkrA8wEn/r/Moh7fphY9jai9twdU FEc93hfh4e4vcBVNrKfKp/FMOm/npU8p50eMjat+pqb+guYkFEC/KgiuhYgFt+HvcIw3 RjBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=4pnfniB0K5UF0JpZph98pTgNbFwLedwSk0p+yrq4x48=; b=klQW/MGHTPZqLzIaFrjNZLNUxxFUmNjdD/EklYREZ/Hkm6fnlObCcgQNTvy5cDipqV swB/FjqAMXAkUEQuIfn7UuHeynw9XhL+8Wr1qogn97AbrdDqQ8SaMAj9DmZOj4WCQE6r 09u5WYH6UD8YQ8I6dPrx0NXR4B2nE9CMu9IHk9maQB1c+YDMUbp4h9ndzqv+vtMm8emP cszOa2gFdLZ+EctvmGd62Z8W0l5aq5tNRck6NIM3ciCJwOGQk2IyJTf+AnqzLP9i1NqO JJ9kFMHTukvtu99ExgvicH2eZ1Dze5UBJ6ai7RkqFCe4ZAmvn7ajzQSVqhx8YU2u/vPe nTQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x17-20020a656ab1000000b0053ee9b2181fsi8550709pgu.118.2023.06.15.00.33.22; Thu, 15 Jun 2023 00:33:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244624AbjFOHIl (ORCPT + 99 others); Thu, 15 Jun 2023 03:08:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244199AbjFOHHv (ORCPT ); Thu, 15 Jun 2023 03:07:51 -0400 Received: from us-smtp-delivery-44.mimecast.com (us-smtp-delivery-44.mimecast.com [205.139.111.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7DE9198D for ; Thu, 15 Jun 2023 00:07:30 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-594-oWywjiogNEqfBUu3vDnHqA-1; Thu, 15 Jun 2023 03:07:27 -0400 X-MC-Unique: oWywjiogNEqfBUu3vDnHqA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2ABC33849534; Thu, 15 Jun 2023 07:07:22 +0000 (UTC) Received: from hog (unknown [10.45.224.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 11D322026D49; Thu, 15 Jun 2023 07:07:19 +0000 (UTC) Date: Thu, 15 Jun 2023 09:07:18 +0200 From: Sabrina Dubroca To: Jakub Kicinski Cc: Fedor Pchelkin , "David S. Miller" , Eric Dumazet , Paolo Abeni , Raed Salem , Lior Nahmanson , Saeed Mahameed , Hannes Frederic Sowa , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Alexey Khoroshilov , lvc-project@linuxtesting.org Subject: Re: [PATCH] net: macsec: fix double free of percpu stats Message-ID: References: <20230613192220.159407-1-pchelkin@ispras.ru> <20230613200150.361bc462@kernel.org> <20230614090126.149049b1@kernel.org> <20230614201714.lgwpk4wyojribbyj@fpc> <20230614230239.02c388a8@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230614230239.02c388a8@kernel.org> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2023-06-14, 23:02:39 -0700, Jakub Kicinski wrote: > On Wed, 14 Jun 2023 23:15:03 +0200 Sabrina Dubroca wrote: > > It's been 7 years... your guess is about as good as mine :/ > > > > I wouldn't bother reshuffling the device creation code just to make > > the handling of rare failures a bit nicer. > > Would you be willing to venture a review tag? Reviewed-by: Sabrina Dubroca -- Sabrina