Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 15 Jun 2023 09:21:43 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Lorenz Bauer <lmb@isovalent.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        David Ahern <dsahern@kernel.org>,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Joe Stringer <joe@wand.net.nz>,
        Mykola Lysenko <mykolal@fb.com>, Shuah Khan <shuah@kernel.org>,
        Kuniyuki Iwashima <kuniyu@amazon.com>,
        Hemanth Malla <hemanthmalla@gmail.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
        linux-kselftest@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 3/6] net: remove duplicate reuseport_lookup
 functions
Message-ID: <ZIq8B2ie8k4hMFa/@corigine.com>
References: <20230613-so-reuseport-v2-0-b7c69a342613@isovalent.com>
 <20230613-so-reuseport-v2-3-b7c69a342613@isovalent.com>
 <ZIiMKgt6iQwJ6vCx@corigine.com>
 <CAN+4W8jTTQqz2Fgzz4AndzpEo=Xteqisv88HqQu=j_VPcu3OVQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAN+4W8jTTQqz2Fgzz4AndzpEo=Xteqisv88HqQu=j_VPcu3OVQ@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUdtV1pwaTgrcUtFb24wdW51bmhocXU2UXdHNmJ2eFRXSXNOdFZsMXRQUzlu?=
 =?utf-8?B?VUZzU21iRHZyWGlyN0dIVGFZSjF5K3NPYXc1N094VFpwKzZaNklrSVRsZXhF?=
 =?utf-8?B?V2dlbklodGVVQVkwRHN1YUkrVTlvU2FzdzkxdytoY3hJY25vZWJwK2lSTVVI?=
 =?utf-8?B?NENTZ1YzVEtEZG80THIwM0FMcFM0WTMyNlhTS2RJSGt0TkI0U08yRFRKcHJQ?=
 =?utf-8?B?SGtXN2lZUG5HRjI3VkJBbSsrR2cyQ1R5djlnSjBjOU5xZ3BhM0JIVHQ4RnJL?=
 =?utf-8?B?ZEFVWkpsV0dnK0NaaS9mdjRoM0UwdHJmRUZqSE5EK1ZQQi80UGhzeVdYcndo?=
 =?utf-8?B?Mi9aMFF6V1h0ZUloVWk0V01DckdrMjdMNnNaZUdxd1BjeTk0cnkwdUdkQkpW?=
 =?utf-8?B?eVV5WHh5T3NraDdwU1VjdWlkakloT2toVWtkTVZyQ3Q0ZGV0TDJnSDRLZURw?=
 =?utf-8?B?dmRSNVZ4NUd2K0JTb1Z5ZGs0QzJaZDN4M3Z4RHpWbGlWR0Z3eXJSeXZLWkk4?=
 =?utf-8?B?b0pwYktXcjRaZXBXWElrREJrMjVQMnArTjJXbFZ5VWF0SFV3UUdkWDFaNDEx?=
 =?utf-8?B?ejFBQUs1eW80V280cCtDRUlTTGd5dnE2UHV1bFVVMjc3YlpQWTdnNXB5ZkJ5?=
 =?utf-8?B?Mjl0YXFWZnB5UkJtUk54WForLzRzNTUzeDNCeUZIOHU4dFFBVk9DbFpxVEtT?=
 =?utf-8?B?VXhrSHVwOUhkMXFJRytmbUZscHdSdXIwdDJ5VVZtVXhZL1U2TitQTWJvUEt0?=
 =?utf-8?B?Q3ZaWDRHUko4Zm0zeWtVN2VtQ2tYVVdQMnZkek9VOCsxa3p5Y2hvMWZrSHJT?=
 =?utf-8?B?K3dLL2QwMXVIVUFMQlpWUGQyS1Q5OEYyaHVzeXpXN1BzSmhlUXpVbkhTVVJB?=
 =?utf-8?B?a3FsYmVoYkFBbXZ5aG5tSjAyam5SRHBBWVZFRm1kcXBiT1F0aktJdGkzNm1h?=
 =?utf-8?B?QXdMdkkzekoxN0pwL1hFWVQ4UGVQTzhtRU9SOEtHU2ZGRGU3MGF6b09hQkRB?=
 =?utf-8?B?VGtsV2loWG5JTDVLZGcwcE9VSzRuSWF5MzFPM3V3cEFFNVJpaEJKSXNtNU9t?=
 =?utf-8?B?QjNIRFVCSlFJN2Rsalo0bWRibnZwYWNURFR3ZFRld0FIUFZYb2JLTDhFQy82?=
 =?utf-8?B?UlA1SzIvcjhGNlpISHdiRUpLNExmelpzWWFmM1JTUSsvYjltVDNjaS9rS2k0?=
 =?utf-8?B?dzlXU1FOZTRpbnNqamN1UUNtRWRZaVJ1Rm10UXg1Q0pFTytxdmVIcXZFWGd0?=
 =?utf-8?B?Zlphd3pKZGNENmxuRUo3THBwV3ZxdjhjT3ZMU2RMK2pQeCtCZzlqN1VqbnpM?=
 =?utf-8?B?cUJFSW1pRHM1ZVdVQjRMRTZ3WTlVd2YzNHJxUkpRT2ZRMHFqRm5pSlp6N3dl?=
 =?utf-8?B?L1ZtZUU3MlBqMTR6NncyY1p2RkRjRVFUSVlGckd5VG9lTkJ1dVpYV1ZyV2Rh?=
 =?utf-8?B?TDlGcTdZMnFoVHRUcDdMMUd3WXY0bmdkTVdjYVIvRnoyZksyLzdSUDB2Unpa?=
 =?utf-8?B?dVA2VjBsNEQ3RUY0M1hZRlVlQ29oQTg1eXk0ZDY4OHM3S1pVZXBuRlkyVWln?=
 =?utf-8?B?U3pic3FzZFdOVUlLQ3c2Y3VXYUdIa1V4TU5laHhRMDRnRzdlVVRaUlNicitD?=
 =?utf-8?B?Sm9QNVZsSkxyZ2NvZUVMRTdwT0hNb0lNV2hvcVJicXlPQkFkT1NERVR3cWtz?=
 =?utf-8?B?VDBoYmp5MGsrc0hraEhwYXFDRkprZ2RUVmdVZk5jTld4WEwzbWp0QVg5dktt?=
 =?utf-8?B?MGZ2TThkYXU5M0tmdlVtWVhWcTFGSEVjQ2RQTHN4Z3FBNlF4ZTl6ZjNRNzk3?=
 =?utf-8?B?VEZPengxVWtyTEhaVUlLeWhoZG85Yk9DREdpUnRKYStWNVBhYk43R1JqZU9R?=
 =?utf-8?B?YU1PR2lhTGJYendoYnNnejUvdTJzVEkvQkZWZlYzVHpScWloaXU5WFBteVdt?=
 =?utf-8?B?RDg2aEIyMmJiakZrZXVCWGs4NU42WFplWGx4cVllYXMrbW9SRk1uWkg0VDB0?=
 =?utf-8?B?YWwyYXpQODcvSVNpS2RzRitvNWhlUlNmRmV3MS9nQTlJSWhoZDBDMEFBN2xh?=
 =?utf-8?B?NUk4RTBaTDRPZVZnVWVjV2N6b1huVjcxVlM0MnVPeUJqcUNwSksvbDJySzdo?=
 =?utf-8?B?SUdzazZwWUNwakJGNHZ2NFBHbzVvdG81NjlTNHBYUHY5S3ZhRlVwRzRQam9l?=
 =?utf-8?B?VXk5QVo1S1k1MDhYeW1YTjd6OUtiZTdxVUcrS0hZL0ZrVjZLdXRVYlh6ZFFZ?=
 =?utf-8?B?YXd4ZDBoYTU5aXJDL1ZzQWRXdjhnPT0=?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af04220b-3f76-4086-4fca-08db6d7130e4
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 07:21:52.3646
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aBd2YQ5Qx7xU5uZ8vaPcD5N5Vu+L5/9qBM3Pt5edrkRMx8OWiFxSQ9hISQdapfYqOUQXv1ChjTOzRwbXzXWSZw+/mHv+Ye5NoCafuZYk99o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR13MB4758
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 14, 2023 at 04:42:45PM +0100, Lorenz Bauer wrote:
> On Tue, Jun 13, 2023 at 4:33 PM Simon Horman <simon.horman@corigine.com> wrote:
> > >
> > > +INDIRECT_CALLABLE_DECLARE(u32 udp_ehashfn(const struct net *,
> > > +                                       const __be32, const __u16,
> > > +                                       const __be32, const __be16));
> > > +
> >
> > Hi Lorenz,
> >
> > Would this be better placed in a header file?
> > GCC complains that in udp.c this function is neither static nor
> > has a prototype.
> 
> Hi Simon,
> 
> The problem is that I don't want to pull in udp.h in
> inet_hashtables.c, but that is the natural place to define that
> function. I was hoping the macro magic would solve the problem, but oh
> well. How do you make gcc complain, and what is the full error
> message?

Hi Lorenz,

sorry for the bother.

With gcc 12.3.0 [1] on x86_64 I see:

$ make allmodconfig
$ make W=1 net/ipv4/udp.o
net/ipv4/udp.c:410:5: error: no previous prototype for 'udp_ehashfn' [-Werror=missing-prototypes]
  410 | u32 udp_ehashfn(const struct net *net, const __be32 laddr, const __u16 lport,
      |     ^~~~~~~~~~~

[1] https://mirrors.edge.kernel.org/pub/tools/crosstool/