Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <76a641e6-64ef-a973-422c-de50d498e52f@collabora.com>
Date:   Thu, 15 Jun 2023 09:30:56 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH v2 3/5] media: mediatek: vcodec: Read HW active status
 from clock
To:     Stephen Boyd <sboyd@kernel.org>, Chen-Yu Tsai <wenst@chromium.org>,
        =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= 
        <nfraprado@collabora.com>
Cc:     Matthias Brugger <matthias.bgg@gmail.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>, kernel@collabora.com,
        Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Tiffany Lin <tiffany.lin@mediatek.com>,
        Yunfei Dong <yunfei.dong@mediatek.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org
References: <20230607205714.510012-1-nfraprado@collabora.com>
 <20230607205714.510012-4-nfraprado@collabora.com>
 <CAGXv+5HHARvkCYfjPjRKgyWuzv-Dt215z1=yA+_tw4hyasdGQA@mail.gmail.com>
 <f0018817-d47b-d772-ed9f-9126bf71a0d1@collabora.com>
 <83770481aa762b69738c27f9d9934dd9.sboyd@kernel.org>
 <90781ea3-d43a-6267-278c-184050fe456e@collabora.com>
 <d579dc00ed9877f9daf170134fe781e6.sboyd@kernel.org>
 <d2c11880-afc1-5c0b-229b-2a4080b22fba@collabora.com>
 <d97a0c8e7aeb4216b361839bc3c9bd54.sboyd@kernel.org>
Content-Language: en-US
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
In-Reply-To: <d97a0c8e7aeb4216b361839bc3c9bd54.sboyd@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Il 15/06/23 02:40, Stephen Boyd ha scritto:
> Quoting AngeloGioacchino Del Regno (2023-06-14 01:13:43)
>> Il 12/06/23 21:19, Stephen Boyd ha scritto:
>>> Quoting AngeloGioacchino Del Regno (2023-06-09 00:42:13)
>>>> Il 09/06/23 01:56, Stephen Boyd ha scritto:
>>>>> Quoting AngeloGioacchino Del Regno (2023-06-08 02:01:58)
>>>>>> Il 08/06/23 10:12, Chen-Yu Tsai ha scritto:
>>>>>>> On Thu, Jun 8, 2023 at 4:57 AM Nícolas F. R. A. Prado
>>>>>>> <nfraprado@collabora.com> wrote:
>>>>
>>>> The firmware gives an indication of "boot done", but that's for the "core" part
>>>> of the vcodec... then it manages this clock internally to enable/disable the
>>>> "compute" IP of the decoder.
>>>>
>>>> As far as I know (and I've been researching about this) the firmware will not
>>>> give any "decoder powered, clocked - ready to get data" indication, and the
>>>> only way that we have to judge whether it is in this specific state or not is
>>>> to check if the "VDEC_ACTIVE" clock got enabled by the firmware.
>>>
>>> Is Linux ever going to use clk consumer APIs like clk_enable/clk_disable
>>> on this VDEC_ACTIVE clk? If the answer is no, then there isn't any
>>> reason to put it in the clk framework, and probably syscon is the way to
>>> go for now.
>>>
>>
>> Not for the current platform, but that may change in future SoCs... we're not sure.
> 
> If you're not using the clk consumer APIs then it shouldn't be a clk.
> 
>>
>>> Another approach could be to wait for some amount of time after telling
>>> firmware to power up and assume the hardware is active.
>>>
>>
>> That would be highly error prone though. Expecting that the HW is alive means that
>> we're 100% sure that both firmware and driver are doing the right thing at every
>> moment, which is something that we'd like to assume but, realistically, for safety
>> reasons we just don't.
>>
>> Should we anyway go for a syscon *now* and then change it to a clock later, if any
>> new platform needs this as a clock?
> 
> Yeah. Or implement this as a power domain and have it read the register
> directly waiting to return from the power_on()?

A power domain would force us to incorrectly describe the hardware in the bindings
though, I think... so, Nícolas, please, let's go for a syscon at this point, as it
really looks like being the only viable option.

Stephen, many thanks for the valuable suggestions and the nice conversation.

Cheers!
Angelo