Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Subject: Re: [PATCH 5/9] MIPS: DTS: CI20: Misc. cleanups
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <20230604145642.200577-6-paul@crapouillou.net>
Date:   Thu, 15 Jun 2023 09:01:02 +0200
Cc:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, linux-mips@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        list@opendingux.net
Content-Transfer-Encoding: quoted-printable
Message-Id: <7895ACE7-2D31-4858-891A-44C2BC7B9D9D@goldelico.com>
References: <20230604145642.200577-1-paul@crapouillou.net>
 <20230604145642.200577-6-paul@crapouillou.net>
To:     Paul Cercueil <paul@crapouillou.net>
Precedence: bulk

Please find a more useful subject.

> Am 04.06.2023 um 16:56 schrieb Paul Cercueil <paul@crapouillou.net>:
>=20
> - Use the standard "ecc-engine" property instead of the custom
> "ingenic,bch-controller" to get a handle to the BCH controller.
>=20
> - Respect cell sizes in the Ethernet controller node.
>=20
> - Use proper macro for interrupt type instead of hardcoding magic
>  values.
>=20
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> arch/mips/boot/dts/ingenic/ci20.dts | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts =
b/arch/mips/boot/dts/ingenic/ci20.dts
> index 7f6e7a4e3915..b7dbafa1f85d 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -356,7 +356,7 @@ nandc: nand-controller@1 {
> 		#address-cells =3D <1>;
> 		#size-cells =3D <0>;
>=20
> -		ingenic,bch-controller =3D <&bch>;
> +		ecc-engine =3D <&bch>;
>=20
> 		ingenic,nemc-tAS =3D <10>;
> 		ingenic,nemc-tAH =3D <5>;
> @@ -422,8 +422,8 @@ dm9000@6 {
> 		pinctrl-names =3D "default";
> 		pinctrl-0 =3D <&pins_nemc_cs6>;
>=20
> -		reg =3D <6 0 1   /* addr */
> -		       6 2 1>; /* data */
> +		reg =3D <6 0 1>, /* addr */
> +		      <6 2 1>; /* data */
>=20
> 		ingenic,nemc-tAS =3D <15>;
> 		ingenic,nemc-tAH =3D <10>;
> @@ -435,7 +435,7 @@ dm9000@6 {
> 		vcc-supply =3D <&eth0_power>;
>=20
> 		interrupt-parent =3D <&gpe>;
> -		interrupts =3D <19 4>;
> +		interrupts =3D <19 IRQ_TYPE_EDGE_RISING>;
>=20
> 		nvmem-cells =3D <&eth0_addr>;
> 		nvmem-cell-names =3D "mac-address";


For better bisecting it would be helpful to split this into 3 patches.

And they are not really related to WiFi/Bluetooth.