Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Subject: Re: [PATCH 0/9] MIPS: CI20: Add WiFi / Bluetooth support
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <20230609082348.GK8160@alpha.franken.de>
Date:   Thu, 15 Jun 2023 09:08:32 +0200
Cc:     Paul Cercueil <paul@crapouillou.net>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, linux-mips@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        list@opendingux.net
Content-Transfer-Encoding: quoted-printable
Message-Id: <E3586962-A5A0-476E-8B5C-AFB1E1B0C4E6@goldelico.com>
References: <20230604145642.200577-1-paul@crapouillou.net>
 <20230609082348.GK8160@alpha.franken.de>
To:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Precedence: bulk

Hi Thomas,

> Am 09.06.2023 um 10:23 schrieb Thomas Bogendoerfer =
<tsbogend@alpha.franken.de>:
>=20
> On Sun, Jun 04, 2023 at 04:56:33PM +0200, Paul Cercueil wrote:
>> Hi,
>>=20
>> Here's a set of patches to add support for the WiFi / Bluetooth chip =
on
>> the CI20.
>>=20
>> WiFi works pretty well, provided it is used with the latest firmware
>> provided by linux-firmware. Bluetooth does not work very well here, =
as
>> I cannot get my wireless keyboard to pair; but it does detect it, and =
it
>> does see they key presses when I type the pairing code.
>>=20
>> I only tested with a somewhat recent (~2022) Buildroot-based =
userspace.
>> I enabled WEXT compatibility because the CI20 is typically used with =
a
>> very old userspace, but I did not try to use it with old tools like
>> ifconfig/iwconfig.
>>=20
>> Cheers,
>> -Paul
>>=20
>> Paul Cercueil (9):
>>  MIPS: DTS: CI20: Fix regulators
>>  MIPS: DTS: CI20: Fix ACT8600 regulator node names
>>  MIPS: DTS: CI20: Add parent supplies to ACT8600 regulators
>>  MIPS: DTS: CI20: Do not force-enable CIM and WiFi regulators
>>  MIPS: DTS: CI20: Misc. cleanups
>>  MIPS: DTS: CI20: Parent MSCMUX clock to MPLL
>>  MIPS: DTS: CI20: Enable support for WiFi / Bluetooth
>>  MIPS: configs: CI20: Regenerate defconfig
>>  MIPS: configs: CI20: Enable WiFi / Bluetooth
>>=20
>> arch/mips/boot/dts/ingenic/ci20.dts | 148 =
+++++++++++++++++++---------
>> arch/mips/configs/ci20_defconfig    |  47 ++++++---
>> 2 files changed, 133 insertions(+), 62 deletions(-)
>>=20
>> --=20
>> 2.39.2
>=20
> series applied to mips-next.

I think this was a little too early. Please see my review.

Best regards,
Nikolaus

>=20
> Thomas.
>=20
> --=20
> Crap can work. Given enough thrust pigs will fly, but it's not =
necessarily a
> good idea.                                                [ RFC1925, =
2.3 ]