Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <825f06c1-cf87-c0e3-a9fc-f4ec0edaa0f8@linaro.org>
Date:   Thu, 15 Jun 2023 09:49:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Content-Language: en-US
To:     Stephen Boyd <sboyd@kernel.org>, Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Evan Green <evgreen@chromium.org>,
        Georgi Djakov <djakov@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>
Cc:     Marijn Suijten <marijn.suijten@somainline.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org
References: <20230526-topic-smd_icc-v6-0-263283111e66@linaro.org>
 <20230526-topic-smd_icc-v6-18-263283111e66@linaro.org>
 <e2afd4bde3e85db358d50553a60a744f.sboyd@kernel.org>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: Re: [PATCH v6 18/22] clk: qcom: smd-rpm: Separate out interconnect
 bus clocks
In-Reply-To: <e2afd4bde3e85db358d50553a60a744f.sboyd@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 15.06.2023 02:48, Stephen Boyd wrote:
> Quoting Konrad Dybcio (2023-06-14 11:04:37)
>> The interconnect bus clocks are now handled within the ICC framework.
>> They still however need to get a kickstart *before* we call
>> clk_smd_rpm_enable_scaling(), or RPM will assume that they should all
>> be running at 0 kHz and the system will inevitably die.
>>
>> Separate them out to ensure such a kickstart can still take place.
>>
>> As a happy accident, the file got smaller:
>>
>> Total: Before=41951, After=41555, chg -0.94%
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>>  drivers/clk/qcom/clk-smd-rpm.c | 278 +++++++++++++++++------------------------
>>  1 file changed, 115 insertions(+), 163 deletions(-)
>>
>> diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c
>> index 6e7f0438e8b8..0d1d97659d59 100644
>> --- a/drivers/clk/qcom/clk-smd-rpm.c
>> +++ b/drivers/clk/qcom/clk-smd-rpm.c
>> @@ -498,13 +506,69 @@ DEFINE_CLK_SMD_RPM_XO_BUFFER(div_clk1, 11, 19200000);
>>  DEFINE_CLK_SMD_RPM_XO_BUFFER(div_clk2, 12, 19200000);
>>  DEFINE_CLK_SMD_RPM_XO_BUFFER(div_clk3, 13, 19200000);
>>  
>> +static struct clk_smd_rpm *bimc_pcnoc_icc_clks[] = {
> 
> Can these be const arrays?
Sorta, look below.

> 
>> +       &clk_smd_rpm_bimc_clk,
>> +       &clk_smd_rpm_bus_0_pcnoc_clk,
>> +};
>> +
> [...]
>> @@ -1332,6 +1275,15 @@ static int rpm_smd_clk_probe(struct platform_device *pdev)
>>                         goto err;
>>         }
>>  
>> +       for (i = 0; i < desc->num_icc_clks; i++) {
>> +               if (!desc->icc_clks[i])
>> +                       continue;
>> +
>> +               ret = clk_smd_rpm_handoff(desc->icc_clks[i]);
> 
> This API can probably take a const struct clk_smd_rpm pointer as well.
It would be great, but ideally we want to set r->enabled in that func
for !bus clocks (for unused clk cleanup). I could probably introduce a
separate function for the icc clocks that takes const.

Konrad