Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 15 Jun 2023 10:07:26 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Justin Chen <justin.chen@broadcom.com>
Cc:     netdev@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        bcm-kernel-feedback-list@broadcom.com,
        florian.fainelli@broadcom.com, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, opendmb@gmail.com, andrew@lunn.ch,
        hkallweit1@gmail.com, linux@armlinux.org.uk,
        richardcochran@gmail.com, sumit.semwal@linaro.org,
        christian.koenig@amd.com
Subject: Re: [PATCH net-next v7 08/11] net: bcmasp: Add support for ethtool
 driver stats
Message-ID: <ZIrGvsesltAc+izQ@corigine.com>
References: <1686781820-832-1-git-send-email-justin.chen@broadcom.com>
 <1686781820-832-9-git-send-email-justin.chen@broadcom.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1686781820-832-9-git-send-email-justin.chen@broadcom.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?e1+kRkfhOflWaGsnnKvCxi2xXs56whv9D8uj9Da0Fm2OcW+YoKoh2syZrmQU?=
 =?us-ascii?Q?x1lvV27RGVdg8C/WL8c+MJq7+pvrmiw3y45FySZ6LrGJRNRbnC8W4ajd7Mwb?=
 =?us-ascii?Q?m46jePE6lscbD9BbW2g7Lk0ITL1C5bwDnth8UysdVubZZ6+w4dbTrcbJPiRp?=
 =?us-ascii?Q?czSGPmQTYN+e1b0fpTAtdFBKg1Xq4n7A/Si/9duGP20viOxjnyWQDGh1GkB4?=
 =?us-ascii?Q?kRv9U7Npj5kg6o3Ct4jbeEO2s4Ac3j1RSQsUf8Dg45RN8APdkiiR2wHuWEd1?=
 =?us-ascii?Q?Lvg3aWT14jgZ8BjvB91q0+x36wymT5q0YLgVkh1F/XBOWCTqh1UouZQm0/tw?=
 =?us-ascii?Q?ZJu79+8vfJbq4Q+iXxoIeovwGsx4jSAW6YDAEXRMsL3BO3VyPmcGDRB0+cp8?=
 =?us-ascii?Q?+wuGnnwPTi6iX9mmovCSDHhdTv+1+XvD2WI86QGUD7GNgdJi+YX5GrCkAmT2?=
 =?us-ascii?Q?bXMMDCG6BRjsDKSL1AfiUPT7tMKa08zZVlAbsB78MgrWS++x5PLMGjje77yI?=
 =?us-ascii?Q?0SwGhgr3LrO280eiRU7W5Smr0ccFClx3CzZvn9R8m2cyPsgaKCwXchQy02Ks?=
 =?us-ascii?Q?2eLLo147a4+yOSAkxS2jY9ntue7U0RZZfX2zApJdN6/FxRcfDX93dmt20U7O?=
 =?us-ascii?Q?j6kkw14ZMfzO/2ciwRM4I3KL2kBZsz/1vmAiTiZzyQo0uBmQP9rb2oQGaHse?=
 =?us-ascii?Q?4JejA3MBvs85f3AfopfhIty3xTXFlkCUZkCi7uRhKtmw4SdYLUPPich2Vrz2?=
 =?us-ascii?Q?/mfJl3gUxQvBwSlkS+2RkVe/5nOP1c1x+gGFx71uw65bjvzYw9MtU8b1BUIY?=
 =?us-ascii?Q?Emr/aWaQm9c/DpFUQ1zOwZUq5joQH0BxiHvuFJQvTFMd4hm4ovnDTte5aIVL?=
 =?us-ascii?Q?Ds211f5ztp+S5PCH6KBaT0etrajXX+qezJtA1xdMAtFEL7oonsREO6TYLnWh?=
 =?us-ascii?Q?pkKtf7+nLb58kgo5m5YGeCWHUYmLiq1a2lhLAY98FFDQJ4515AWFJuj+c0pN?=
 =?us-ascii?Q?SuC6WvjAa1uXVS434m2xDZsgNaGw9foXpZyo4+JgMjj87yDkHnU76rnNcWcJ?=
 =?us-ascii?Q?LZGWJaEd/t8gI9zswO1PkyQDT/3figzBRzMytAQtbvxIrTBWhVZuFDFGAGFZ?=
 =?us-ascii?Q?FG0lsT2BoMvEw/dhzGzQ/YllbFRVDTBjfNlKfUKI1C+J3SeiLARgbVf/YIPh?=
 =?us-ascii?Q?/qNvrDHA12cCA7IS870hR8kezhYZuk3E3i0ZiOd88k4V2lp3yAFaU/HH/9o0?=
 =?us-ascii?Q?a2CoLbKLcgUnD4S65xqwghsioWfRrvHRpQ520TmhfBpbqf6l7a/Y4ehpewq8?=
 =?us-ascii?Q?EAnjBwU8RlbBKj+ZD53r7qLtq/p3Vi/8W9X83bzAm29NBmEkCJdOHsl4kHMh?=
 =?us-ascii?Q?sgNworlEi/lJH80BOG/O22uhNp3TWYhcdNuPnvZgaDOHwGBT1CxRAtJSyLVP?=
 =?us-ascii?Q?vWLZ7kfejtmJl7Q/YR6AlxsrmJxiNsar+johvpLrzZ/oPdvyXjgtbxu4TYz5?=
 =?us-ascii?Q?RKzVREeWp2h5Hamw2F1jnwsHwDqYReuCynh2mANmT8GZU8fO/k8ch0Ey03aR?=
 =?us-ascii?Q?1RQqAjAH2kCc/lxow4i4S82d1lCQZBy5xQm1rRF4iZpayUVrapXCsw1U++gP?=
 =?us-ascii?Q?0jpwv1Vnl1Gt9Z/XWE5BVmtSGgbwiWAkOovMEYeUL2e/rZveqL7+T6FLmIaW?=
 =?us-ascii?Q?3p8ZGw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8369c2e8-f5ac-42bd-bf0c-08db6d77932a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 08:07:34.2351
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W9s4hJFRj4+1bqvGsxhFWEEp3G/8O6MM2qNRPiGlQ7K8b7ARbiLrxIkRDcPeLZEPc9qzLQV11bK5FHerZomOv2qto4+xk6nP+Az5T/ppWI4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB6113
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 14, 2023 at 03:30:17PM -0700, Justin Chen wrote:

...

> +static void bcmasp_update_mib_counters(struct bcmasp_intf *intf)
> +{
> +	int i;
> +
> +	for (i = 0; i < BCMASP_STATS_LEN; i++) {
> +		const struct bcmasp_stats *s;
> +		u32 offset, val;
> +		char *p;
> +
> +		s = &bcmasp_gstrings_stats[i];
> +		offset = bcmasp_stat_fixup_offset(intf, s);
> +		switch (s->type) {
> +		case BCMASP_STAT_SOFT:
> +			continue;
> +		case BCMASP_STAT_RX_EDPKT:
> +			val = rx_edpkt_core_rl(intf->parent, offset);
> +			break;
> +		case BCMASP_STAT_RX_CTRL:
> +			val = rx_ctrl_core_rl(intf->parent, offset);
> +			break;
> +		case BCMASP_STAT_RX_CTRL_PER_INTF:
> +			offset += sizeof(u32) * intf->port;
> +			val = rx_ctrl_core_rl(intf->parent, offset);
> +			break;
> +		}
> +		p = (char *)(&intf->mib) + (i * sizeof(u32));
> +		put_unaligned(val, (u32 *)p);

Hi Justin,

GCC 12.2.0, in a W=1 build, warns that val may be used uninitialised here.

I think that, in theory, that can occur if s->type doesn't match
any of the case statements above. Perhaps in practice that cannot occur.
But, perhaps it would be worth adding a default case with some suitable
handling.

 In file included from drivers/net/ethernet/broadcom/asp2/bcmasp_ethtool.c:4:
 ./include/asm-generic/unaligned.h: In function 'bcmasp_get_ethtool_stats':
 ./include/asm-generic/unaligned.h:19:19: warning: 'val' may be used uninitialized [-Wmaybe-uninitialized]
    19 |         __pptr->x = (val);                                                      \
       |                   ^
 drivers/net/ethernet/broadcom/asp2/bcmasp_ethtool.c:125:29: note: 'val' was declared here
   125 |                 u32 offset, val;
       |  

> +	}
> +}

...