Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Subject: Re: [PATCH 0/9] MIPS: CI20: Add WiFi / Bluetooth support
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <C1924536-FA97-4E75-9D22-99E5AF24EE5B@goldelico.com>
Date:   Thu, 15 Jun 2023 11:14:08 +0200
Cc:     list@opendingux.net, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        Conor Dooley <conor+dt@kernel.org>, linux-mips@vger.kernel.org,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Content-Transfer-Encoding: quoted-printable
Message-Id: <A8EBCBA4-D9BA-4C2F-9C91-38128D06EDBA@goldelico.com>
References: <20230615084006.79194526F801@goldelico.com>
 <C1924536-FA97-4E75-9D22-99E5AF24EE5B@goldelico.com>
To:     Paul Cercueil <paul@crapouillou.net>
Precedence: bulk

Hi Pual,


> Am 15.06.2023 um 10:45 schrieb H. Nikolaus Schaller =
<hns@goldelico.com>:
>=20
> Hi Paul,
>=20
>> Am 15.06.2023 um 10:39 schrieb Paul Cercueil <paul@crapouillou.net>:
>>=20
>> Hi Nikolaus,
>>=20
>> Le 15 juin 2023 09:00, "H. Nikolaus Schaller" <hns@goldelico.com> a =
=C3=A9crit :
>>>=20
>>> Hi Paul,=20
>>> I was in holidays and could not review this series earlier.=20
>>>=20
>>>=20
>>>> Am 04.06.2023 um 16:56 schrieb Paul Cercueil =
<paul@crapouillou.net>:=20
>>>>=20
>>>> Hi,=20
>>>>=20
>>>> Here's a set of patches to add support for the WiFi / Bluetooth =
chip on=20
>>>> the CI20.=20
>>>>=20
>>>> WiFi works pretty well, provided it is used with the latest =
firmware=20
>>>> provided by linux-firmware. Bluetooth does not work very well here, =
as=20
>>>> I cannot get my wireless keyboard to pair; but it does detect it, =
and it=20
>>>> does see they key presses when I type the pairing code.=20
>>>>=20
>>>> I only tested with a somewhat recent (~2022) Buildroot-based =
userspace.=20
>>>> I enabled WEXT compatibility because the CI20 is typically used =
with a=20
>>>> very old userspace, but I did not try to use it with old tools like=20=

>>>> ifconfig/iwconfig.=20
>>>=20
>>> ^^^ great since not everyone is using memory hungry latest =
user-space and=20
>>> ifconfig/iwconfig is also available on some other OS so users like =
me=20
>>> can share scripts.=20
>>>=20
>>>=20
>>> But I had quite some issues with this series.=20
>>>=20
>>> 1. I could not boot my CI20 V2a board after applying the full series =
to v6.4-rc6=20
>>> 2. bisecting failed because vcc_33v is used in a patch preceding its =
definition=20
>>>   leading to DTC compile abort=20
>>> 3. after fixing I could bisect that "MIPS: DTS: CI20: Fix ACT8600 =
regulator node names"=20
>>>   is the first bad commit - although I don't see immediately why=20
>>>=20
>>> So this series seems to be severely broken and I could not even come =
to=20
>>> a test of WiFi and/or Bluetooth which the series claims to support.=20=

>>=20
>> Well, that's strange. I can assure you it boots and works here.
>>=20
>> Maybe it is a board difference; I have a non-square green board - so =
the earlier version.
>=20
> Ok, my V2a is the bordeaux one. That may indeed make a difference.
>=20
>>=20
>> Since this patch will actually make the various ACT8600 regulators =
work at their specified voltage, maybe the voltage on one of the updated =
regulators is wrong?
>>=20
>> Maybe change the regulators one by one back to their old name, until =
you find the one that is problematic? That may give us more info.
>=20
> That is what I also have though about but have not yet done.
> Will try as soon as I find a time slot.

I have reverted the whole patch (had only a conflict in wifi_io / LDO6) =
and now I can boot.

But do not see a WiFi or Bluetooth interface.

So it looks as if the CI20 variants are indeed different. Which would =
also explain why we
originally came up with two different solutions to add WiFi.

Next I will try to bisect the individual changes...

>=20
>>=20
>>> Comments to some individual patches follow.=20
>>=20
>> Sorry about the vcc_33v. Honest mistake.
>>=20
>> Thomas: are you able to drop this series from mips-next, or should =
I/we send fixup patches instead?
>=20
> Well, mistakes happen.
>=20
> Best regards,
> Nikolaus
>=20
>>=20
>> Cheers,
>> -Paul
>>=20
>>> Best regards and looking forward to a v2 for testing,=20
>>> Nikolaus=20
>>>=20
>>>=20
>>>>=20
>>>> Cheers,=20
>>>> -Paul=20
>>>>=20
>>>> Paul Cercueil (9):=20
>>>>  MIPS: DTS: CI20: Fix regulators=20
>>>>  MIPS: DTS: CI20: Fix ACT8600 regulator node names=20
>>>>  MIPS: DTS: CI20: Add parent supplies to ACT8600 regulators=20
>>>=20
>>> ^^^ should IMHO be a separate series since it is not directly =
related to WiFi / Bluetooth=20
>>>=20
>>>>  MIPS: DTS: CI20: Do not force-enable CIM and WiFi regulators=20
>>>>  MIPS: DTS: CI20: Misc. cleanups=20
>>>=20
>>> ^^^ these two do not compile=20
>>> The Misc. cleanups do not belong to this topic.=20
>>>=20
>>>>  MIPS: DTS: CI20: Parent MSCMUX clock to MPLL=20
>>>=20
>>> ^^^ this is only loosely related to Wifi / Bluetooth=20
>>>=20
>>>>  MIPS: DTS: CI20: Enable support for WiFi / Bluetooth=20
>>>>  MIPS: configs: CI20: Regenerate defconfig=20
>>>>  MIPS: configs: CI20: Enable WiFi / Bluetooth=20
>>>>=20
>>>> arch/mips/boot/dts/ingenic/ci20.dts | 148 =
+++++++++++++++++++---------=20
>>>> arch/mips/configs/ci20_defconfig    |  47 ++++++---=20
>>>> 2 files changed, 133 insertions(+), 62 deletions(-)=20
>>>>=20
>>>> --=20
>>>> 2.39.2=20
>>>>=20
>>>=20
>=20