Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp915895rwd; Thu, 15 Jun 2023 04:03:33 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7GZOITwO0byhCXKV23FbEC6nvywpR6iLGE3LGiNNy8jCGp//AXmJ9gPFelZNhnJeOOGPhx X-Received: by 2002:a17:902:ce81:b0:1b2:3f01:eb06 with SMTP id f1-20020a170902ce8100b001b23f01eb06mr17175593plg.0.1686827013111; Thu, 15 Jun 2023 04:03:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686827013; cv=none; d=google.com; s=arc-20160816; b=Wbg7ousoWJ3dnhg+DHtw3ytFPqbzWJMkMVExRTlCDopq7lgOD+IX74BGc1TNzO2BtJ k1qtsZk1BaH31KojxXXLjN39j+BsCUDZ4kCjx3QLCJyvRnpRpr1bVfAD1WFlVy3MDapc NpRyitP0ru6c7P4guzvC2ocRk47A8GLi5SP2h9r2x9wJXCgoZJqUO+kthVzCIKf5AfWK ANZqZHM0tExDpVXwb8DJodY7RL5VScXA+OPqdEgztL57+xTMDgIWBouBwpGubCEH/kk7 J5gBzu9tOE/YyiOLHiq2HaGYhprwXcIuN2ACRYwjFWN9MavOzyNJrUHFsz5wIj29+XhL fbJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=JE7U7o1t0HjyzKUyU1KoA5YOSsiMYQA+KDs2l+je2P8=; b=NZ5y0aI8jI+E4Nt9xrdWUeb6ao7GSPR5687K2U8rXrYCxPgXMZaTNEOBAmRQnVjqim V/6gTualbiJu/R76i5PMOOKL0x/0qB8TP5lilZPAiXv1fDefGwjHcjHkKu58a7hp0oXl akqIhfzr0c23nl3zqTFgrncGSRC/0iAgSYNkRSZltiaQ5H+SlGX6CqFnrcQ/pXRlbJSC 1aiXSCFiW9flJhemJJTS82xBquj+dJsJIvhb5UmiWc8YseLR+ZhnMfLh0s+Po/uRC/el 9A7NcXXaz2I7Sa7MYeWrv84MFJ0LZmnl/Vf9JipQlSzvPqQVzpWlWQTpvUwYY+yKx3/0 TPtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XQb1yjyu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d1-20020a170903230100b001ab23cb930bsi9620732plh.417.2023.06.15.04.03.20; Thu, 15 Jun 2023 04:03:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XQb1yjyu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245675AbjFOKu0 (ORCPT + 99 others); Thu, 15 Jun 2023 06:50:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240308AbjFOKuY (ORCPT ); Thu, 15 Jun 2023 06:50:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93D96273F for ; Thu, 15 Jun 2023 03:50:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0352C6377D for ; Thu, 15 Jun 2023 10:50:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 603E5C433CA; Thu, 15 Jun 2023 10:50:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686826220; bh=mmKn3ew/3ihNeUTsrH7kpRJDU9VC/tq1DF43WBYgUjc=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=XQb1yjyu7equ0BYhCU1QJjHdCwPx/7WS07cuh6Ee/ukzrWWJa1lOqiPrjFZ7bhIfN rqCUw7iOdeMlQ9Sd/UBrbOA+krlqf3GAn3GdEoyfc6UKwyzmCTNn7jghlDT3pBTU6l cWK/1mKjrVPpo/YRcAWseb2TvcyzHFORxlrToAV62W/je68U9PrS8+dftkAC64UZXW AWNzPahr7Pl+Rn2y1yaqaWLwv3imYKQklYwYL/6YjiIGiQ+78GTit/u4OfD34Idahr VZdGhjkog7/pya9NtGQ9RyKKftj1EPmI3MhfvHrdXxgAUurN34QcFeTsJoLkIES5Bs XDiN23PvR+y4g== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 3709AE270FB; Thu, 15 Jun 2023 10:50:20 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] net: macsec: fix double free of percpu stats From: patchwork-bot+netdevbpf@kernel.org Message-Id: <168682622021.15431.8579667893782171995.git-patchwork-notify@kernel.org> Date: Thu, 15 Jun 2023 10:50:20 +0000 References: <20230613192220.159407-1-pchelkin@ispras.ru> In-Reply-To: <20230613192220.159407-1-pchelkin@ispras.ru> To: Fedor Pchelkin Cc: davem@davemloft.net, sd@queasysnail.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, raeds@nvidia.com, liorna@nvidia.com, saeedm@nvidia.com, hannes@stressinduktion.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, khoroshilov@ispras.ru, lvc-project@linuxtesting.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Tue, 13 Jun 2023 22:22:20 +0300 you wrote: > Inside macsec_add_dev() we free percpu macsec->secy.tx_sc.stats and > macsec->stats on some of the memory allocation failure paths. However, the > net_device is already registered to that moment: in macsec_newlink(), just > before calling macsec_add_dev(). This means that during unregister process > its priv_destructor - macsec_free_netdev() - will be called and will free > the stats again. > > [...] Here is the summary with links: - net: macsec: fix double free of percpu stats https://git.kernel.org/netdev/net/c/0c0cf3db83f8 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html