Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp917613rwd; Thu, 15 Jun 2023 04:04:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5rI2xFcuprUZ+z3JdpMi6d5STfCH2UNTZg9fEvlj7/k8s+QIHxP2bx0Ydg7XS4UPKgYtgU X-Received: by 2002:a05:6870:37c6:b0:19a:49d4:6d05 with SMTP id p6-20020a05687037c600b0019a49d46d05mr14052451oai.54.1686827085080; Thu, 15 Jun 2023 04:04:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686827085; cv=none; d=google.com; s=arc-20160816; b=m02FPvvCHC4x14pDcHKkOBwXhIDgtZAtYmVVWnDgcpbi9Ju+VXAAQLUr6rF8Ad0Mmg n+ZOaCahi4tKDYX6WHJl2faegHhVPWmxBe1O9hE8dma1TqxcCxwPTiMB0t/DAWA75BOq Pc3revrdlv6kL4/DaUh38NhtgV/ckuA7mEtbzjrQ+sz0H9X6Lb0O0sIWPAXaLUH5+6ai Q/HHUDemGo4rwdE90Wa4JtGeyuXryxsMhuR/OfbdGL71y2GcSbd5hi1jDC+WtIJF7mzj 8Xd8gNfUs3cwg15fYwlFjbGJ3K0JBGcOt9kzTBAEHRxriLW/it8NDnFyi9sfQ66D76zF wevg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Ccfd6HP/rR8+fr/9984lF6hvcBFGy8oy9QTDbsX0CxY=; b=ip1Uw1udlCLYatEAJtXSPE0XBcsoXbRWvuQ0B1OWcCefdMiPaEezqO3QQVrbqGSuIB PrNqvhw0b4QRWj2QZKnkWSR2b4Px6HBQrDcH1BXaL+S9AkPljDAMcd9YfuQS0Qtg803F sR0uszs2f5ZlxGXk/U95T5+GPaVaPZ8X6lwkdLZOw0E8rt4pe6sZb2eGcm8GLWD/zGLI GWXCgQMJXMeA3xYQRCQi+MMzHsSUoPEd0jno5Ti0ObK2S1J5nG4CJGIwJD7g+4ZQVh2T aL2bwNssbhdt4kJz3aAKGo9CZAxp9kraR9CrNLnxJiqEOU0XsZlQYx52JXjc1IRb3H8m dbXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=QGXBWTJN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mz7-20020a17090b378700b00250db0f5689si12706841pjb.179.2023.06.15.04.04.32; Thu, 15 Jun 2023 04:04:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=QGXBWTJN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343654AbjFOKyH (ORCPT + 99 others); Thu, 15 Jun 2023 06:54:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241757AbjFOKyE (ORCPT ); Thu, 15 Jun 2023 06:54:04 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 144611FE4; Thu, 15 Jun 2023 03:54:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1686826443; x=1718362443; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=roTYgP3DrDdWNlW0RbVAYG9eUbAOFUhPXtFqT0roqYE=; b=QGXBWTJN3NnAwnzlZmydxZ55aNem8kNme9gcb8Y+vihK/UNWvTdxiIfO zv0B5xEDBH/I/A/yG8VwRAqd5oczxBdMr94MMxmau3t6UdS2k56fwFyBI SeGW23E034zme+8bzGlTV2A67G5WSt1Paco834dFNB57sCbStvZgDo+Qo uBR4t/pmJTQTBI/vHhwu4k/6n1De+2k4Qc3h/Grzx1IAp74YdYz8kqU53 AIM9Bn8ZTIhAJbC73klVmYIZC1APDPqwUAEUwgCA0nFwBypbQwGBgYZUP FqubZQeE7mExKJ07yyIMy+qsgGp6bjnBckh5OmT9JiZDMItqT5ytejBfn w==; X-IronPort-AV: E=Sophos;i="6.00,244,1681196400"; d="scan'208";a="218006732" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 15 Jun 2023 03:54:03 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 15 Jun 2023 03:53:56 -0700 Received: from m18063-ThinkPad-T460p.mchp-main.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Thu, 15 Jun 2023 03:53:51 -0700 From: Claudiu Beznea To: , , , , , , , , CC: , , , Claudiu Beznea Subject: [PATCH 1/3] pinctrl: mcp23s08: check return value of devm_kasprintf() Date: Thu, 15 Jun 2023 13:53:31 +0300 Message-ID: <20230615105333.585304-2-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230615105333.585304-1-claudiu.beznea@microchip.com> References: <20230615105333.585304-1-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org devm_kasprintf() returns a pointer to dynamically allocated memory. Pointer could be NULL in case allocation fails. Check pointer validity. Identified with coccinelle (kmerr.cocci script). Fixes: 0f04a81784fe ("pinctrl: mcp23s08: Split to three parts: core, I²C, SPI") Signed-off-by: Claudiu Beznea --- drivers/pinctrl/pinctrl-mcp23s08_spi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pinctrl/pinctrl-mcp23s08_spi.c b/drivers/pinctrl/pinctrl-mcp23s08_spi.c index 9ae10318f6f3..4013ffbfa282 100644 --- a/drivers/pinctrl/pinctrl-mcp23s08_spi.c +++ b/drivers/pinctrl/pinctrl-mcp23s08_spi.c @@ -119,6 +119,9 @@ static int mcp23s08_spi_regmap_init(struct mcp23s08 *mcp, struct device *dev, return -EINVAL; } + if (!name || !mcp->chip.label) + return -ENOMEM; + copy = devm_kmemdup(dev, config, sizeof(*config), GFP_KERNEL); if (!copy) return -ENOMEM; -- 2.34.1