Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp947732rwd; Thu, 15 Jun 2023 04:30:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4gLbdSSVCDaQfHvSLLDkkBuyp13FJ8tueDZuL/mlp4gb+mMKtrPTWUxg3u1wL9KCTfnZMZ X-Received: by 2002:a2e:8750:0:b0:2b1:cdb6:ea2e with SMTP id q16-20020a2e8750000000b002b1cdb6ea2emr7712746ljj.50.1686828626426; Thu, 15 Jun 2023 04:30:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686828626; cv=none; d=google.com; s=arc-20160816; b=W2kaJgXSAcFwHJCu5gjXDbFKngmXrQ8y8LAS6UHSVe/eTeCGksO7sD8mYQeD3W1b0H iyU9nUo2QrbR886g/APpOHY5fy7GfAxWt5IW1W0yfp3SfEQDlssqNLt0TAHipRNEILCG 0STPs+YbqIJVNBoLZP/Zj/k5KSAxGAMy06LmwXHqgv4Yu3L1GJ47tTKfV7XBwTUWatkZ V+5BFbVThd6dltvdp76GKe/mtmV/CQe3UXVTj6bDbelB3QHmIMw6Mw5aa+INLcsD2nTP WaaMSeSJ9vhEjYZjElxnqXCRjLkyVOoCN2mGM9f5KMM3Hrw9WoGJ91kge8xxDLCJ0du1 8eCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lfdHHTIjp6MAxObiEKWy93oQk//B2YbZ5Iyl+937rI4=; b=et1xWsokR/UeDc8K8SLzEPKajmf5fMmpdbsqOgpEzzs1Cjdp8S4vW5dVWdVxuRH2xR lbMmj04y/YS3Zx6+J3PuMr7n4lEoHkBm+rKVbmr7VQtsf1sDlEofSgqbqTtNxrwT5Qja S8UN0LThX0qHIY45hIx7doqj3zX7VH5lSaUbeX8NbKZRBOOM82V2HH5AhnsZ8nTzy46w AKgTzeAPSLMcspKA7hdu1esEfwBEm+Io4K+8pWY+0ziMkmeyreHcCSFCihq2BzeC87Cs YURYIr9bu+yYfgWMZ1lIVOhIHtuKFUHP6k+7BoyI8glDdQW7XWIgG9jZcNVNrX8B8IOV di4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=o7P8br4g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q21-20020aa7da95000000b0051a1ee010dcsi1256224eds.553.2023.06.15.04.29.47; Thu, 15 Jun 2023 04:30:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=o7P8br4g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343629AbjFOKyF (ORCPT + 99 others); Thu, 15 Jun 2023 06:54:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343540AbjFOKyC (ORCPT ); Thu, 15 Jun 2023 06:54:02 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28D9A2135; Thu, 15 Jun 2023 03:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1686826441; x=1718362441; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3v+xI5WPh077/j0cQYGy7LYrHkohpui4PXNg4lHsRLY=; b=o7P8br4gAIyeK5YDjN6hpuU9ARopmlcu1LKKeUayl1DOCV5Ri6Vlz0Nz /JXYeD/V9dptzhq5rqgZ++mW4irLNpmi0GQKQyJS1hfv2ps7f5caE4VqK 2fz3aDb/6Up4zPKGmkSS1/o11j5CJZ6YyvmYLhARLEHS5gUE+FkEz4c1D 6DcG4CQmKlJA3OpUfrndeND3I2wQN0+/0+zpUwAlI0TKhsFuxRak7Fb8V UXAIgyur2ihUNKDw+udeDe6Xf6Z9nv2fUBR3ohBTGTFMUVZ9e+2CBP9SC tFQGcjQlidwP3G5xLV2NSXp0fWvbZsztBzYhAq3EC1LF104HmD1+ZSG3l g==; X-IronPort-AV: E=Sophos;i="6.00,244,1681196400"; d="scan'208";a="218006713" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 15 Jun 2023 03:54:01 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 15 Jun 2023 03:54:01 -0700 Received: from m18063-ThinkPad-T460p.mchp-main.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Thu, 15 Jun 2023 03:53:57 -0700 From: Claudiu Beznea To: , , , , , , , , CC: , , , Claudiu Beznea Subject: [PATCH 2/3] pinctrl: microchip-sgpio: check return value of devm_kasprintf() Date: Thu, 15 Jun 2023 13:53:32 +0300 Message-ID: <20230615105333.585304-3-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230615105333.585304-1-claudiu.beznea@microchip.com> References: <20230615105333.585304-1-claudiu.beznea@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org devm_kasprintf() returns a pointer to dynamically allocated memory. Pointer could be NULL in case allocation fails. Check pointer validity. Identified with coccinelle (kmerr.cocci script). Fixes: 7e5ea974e61c ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO") Signed-off-by: Claudiu Beznea --- drivers/pinctrl/pinctrl-microchip-sgpio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pinctrl/pinctrl-microchip-sgpio.c b/drivers/pinctrl/pinctrl-microchip-sgpio.c index 4794602316e7..666d8b7cdbad 100644 --- a/drivers/pinctrl/pinctrl-microchip-sgpio.c +++ b/drivers/pinctrl/pinctrl-microchip-sgpio.c @@ -818,6 +818,9 @@ static int microchip_sgpio_register_bank(struct device *dev, pctl_desc->name = devm_kasprintf(dev, GFP_KERNEL, "%s-%sput", dev_name(dev), bank->is_input ? "in" : "out"); + if (!pctl_desc->name) + return -ENOMEM; + pctl_desc->pctlops = &sgpio_pctl_ops; pctl_desc->pmxops = &sgpio_pmx_ops; pctl_desc->confops = &sgpio_confops; -- 2.34.1