Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 15 Jun 2023 13:54:39 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Jisheng Zhang <jszhang@kernel.org>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Karol Gugala <kgugala@antmicro.com>,
        Mateusz Holenko <mholenko@antmicro.com>,
        Gabriel Somlo <gsomlo@gmail.com>,
        Joel Stanley <joel@jms.id.au>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: litex: add support for 64 bit stats
Message-ID: <ZIr7/5IJbPjOt0Kd@corigine.com>
References: <20230614162035.300-1-jszhang@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230614162035.300-1-jszhang@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vS7dDwBdh9Xl1PHoow7HQMEA8TE4IsYQcypxq6E0lWP31RQlsky01KmdtHwg?=
 =?us-ascii?Q?+KM0nraSVlTFX278bFIzcKEGq03PG03/l6P+p7IF8Rbm1OPP8v4RvFKBIAbr?=
 =?us-ascii?Q?HgsteETwM+AilwxcX67ZU17ZXV4eS1wTwX9AFPa5irrR1A1haQlsHMY5r2gv?=
 =?us-ascii?Q?CtD/tYv3dJVkzy6fWyLFCFJimWDou+y6xC2/rxtP3T7AxU2NQKps4CHIJzNe?=
 =?us-ascii?Q?hS6gMLX9zM6DzoRmBnVy7vuUhJFhDiQc0mM3sOjnsHa0GgRvINTeTTRKTTp/?=
 =?us-ascii?Q?rL6RKaXA1IRcQQClmaYte29wIYY6zysGpnLDB6mMhkGzY+HISnKbYSlDms2q?=
 =?us-ascii?Q?MRV0o/6lWTW264k7YV18QW4aEEiWYJP/Tznspz0e9o442Owmeq6AoMhFpq1B?=
 =?us-ascii?Q?Gc5rIv1Wz5TG07rXL2ZKkQCZE2bzSrz0dflkmSkV7oSkUM3nAvIw5RGxySPJ?=
 =?us-ascii?Q?wgSjBHbb2d86AGe9zZtnJLEL1zl9niCSiP+JeQJpKtgstLFFSofvFLnIv8ju?=
 =?us-ascii?Q?5aP/VMcDyjy8a7oFSrRZ8a0PoiIhiJv+D6cThEDEPwRCUYy49M0tuf+dXklH?=
 =?us-ascii?Q?evhexfH+PgkGGZRNJ/mPT4bA32yp1BG8NMSGelVEYhfKgQGHn0Bb1v4TmknO?=
 =?us-ascii?Q?sRTHry7DSMSmwpINn9p7MbVHyNWFPJkEKRWafR1Vq+KZCF3v6OmIlF2kRsan?=
 =?us-ascii?Q?fbm+26yKPb4+S5fd+cPmvfwl/TV62O1x/O+M8uJ+lhVWSFDmbtpaDlZ84LUY?=
 =?us-ascii?Q?lv8CTEW0scituEYKoD80/2Yj2qxmv9c70qsrvJXEvXmFjujecj8KYLOvvdln?=
 =?us-ascii?Q?5uiHQYMSB88JUtSx8Bf605/g1p/J2CbC8FOxol03tGuFFVmdyvKQRqprd/Ja?=
 =?us-ascii?Q?OebgqezFJhCstHxi68902tqDgc6TpRJaQt2C2FUbC4YUPTugc6L1NQg6VowO?=
 =?us-ascii?Q?r0EIZx+ptAwQ4/SC9bljHER+jaOPul33aB+OMJLTTQvIHX4TLf9fI2aLB5Nk?=
 =?us-ascii?Q?j7/MgTiA9NFA3G4NgfIXq7xsy45kA/Ra3icAiJahcHJaMk+QfxX3ja+Xt8sO?=
 =?us-ascii?Q?Yjr6EzQMvRtcUBUcYLzDhScDMnWaY3NNdTis+4kQYs8Salpm5jfR5BUu4rfY?=
 =?us-ascii?Q?pAj5tzGtocP5LHCDlcIr4IwS5rQVQTndBBI5L2lVqhCPcXOY/PtvSCX2LAdg?=
 =?us-ascii?Q?FZdI912zWVZoqosjCZWaFW7saEbA9E4x6EO9yL/pCGmjizxuqA8Dw+OBwSaH?=
 =?us-ascii?Q?Mf1GRzXveC07sfPE5WthKT+K0fpsdT9PxgTEP2S/pbuffOgf3PPYM7admMip?=
 =?us-ascii?Q?x+XA5nCUV/B3+OX8eU0fdepoNMMddyMjo3FzjNKQzZUTisuyWRA/igncLZGx?=
 =?us-ascii?Q?yEwpbhmYZmXFN4cgEt3wqSyiDtzUysNj8ZhN63bgXpDYOnLj33rx0aNdNr/H?=
 =?us-ascii?Q?v0/LCQMYOEGYEdfIt17rrjEZDDzzLALDvnYKgDPAlNIu4XOzUk2fan7n/1v+?=
 =?us-ascii?Q?rRgAGORGbE0z4vJHPG6ge0deH/Dd6FklLhsPQ2agakcvmO0BCyK/grMMVfEw?=
 =?us-ascii?Q?GRUoluxbRLlZGc/1nztI47jW6CkJACYqH4v/qjxBjsURS4BSDhy71bmd0THk?=
 =?us-ascii?Q?UKaK6v5wMFWT68nLlO+0XOR7LaSzsge9oB48SwM2h7CaQTAkrf4mMTQntzKn?=
 =?us-ascii?Q?wp6OVA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0fe1b880-d25d-4ba7-793b-08db6d975065
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 11:54:46.0866
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /vU2dr1oaI3S1pgmcklaAlXkfrTazWPqyg+odXkwV82IsvacwLApA7VdKENxQHGahW2/vBkNsqgfdjWI5zJ5YVr6x59lWiyT55J6Xv2HBfc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR13MB5990
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 15, 2023 at 12:20:35AM +0800, Jisheng Zhang wrote:
> Implement 64 bit per cpu stats to fix the overflow of netdev->stats
> on 32 bit platforms. To simplify the code, we use net core
> pcpu_sw_netstats infrastructure. One small drawback is some memory
> overhead because litex uses just one queue, but we allocate the
> counters per cpu.
> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>

Reviewed-by: Simon Horman <simon.horman@corigine.com>