Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Subject: Re: [PATCH 0/9] MIPS: CI20: Add WiFi / Bluetooth support
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <A8EBCBA4-D9BA-4C2F-9C91-38128D06EDBA@goldelico.com>
Date:   Thu, 15 Jun 2023 14:28:25 +0200
Cc:     list@opendingux.net, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        Conor Dooley <conor+dt@kernel.org>, linux-mips@vger.kernel.org,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Content-Transfer-Encoding: quoted-printable
Message-Id: <AA802E24-A97B-42B6-90A4-5ECB1E4D9294@goldelico.com>
References: <20230615084006.79194526F801@goldelico.com>
 <C1924536-FA97-4E75-9D22-99E5AF24EE5B@goldelico.com>
 <A8EBCBA4-D9BA-4C2F-9C91-38128D06EDBA@goldelico.com>
To:     Paul Cercueil <paul@crapouillou.net>
Precedence: bulk

Hi Paul,

>>>=20
>>> Since this patch will actually make the various ACT8600 regulators =
work at their specified voltage, maybe the voltage on one of the updated =
regulators is wrong?
>>>=20
>>> Maybe change the regulators one by one back to their old name, until =
you find the one that is problematic? That may give us more info.
>>=20
>> That is what I also have though about but have not yet done.
>> Will try as soon as I find a time slot.
>=20
> I have reverted the whole patch (had only a conflict in wifi_io / =
LDO6) and now I can boot.
>=20
> But do not see a WiFi or Bluetooth interface.
>=20
> So it looks as if the CI20 variants are indeed different. Which would =
also explain why we
> originally came up with two different solutions to add WiFi.
>=20
> Next I will try to bisect the individual changes...

It is this and not the regulator names:

diff --git a/arch/mips/boot/dts/ingenic/ci20.dts =
b/arch/mips/boot/dts/ingenic/ci20.dts
index e2221d44e4269..391be48e6427a 100644
--- a/arch/mips/boot/dts/ingenic/ci20.dts
+++ b/arch/mips/boot/dts/ingenic/ci20.dts
@@ -295,7 +295,6 @@ &i2c0 {
        act8600: act8600@5a {
                compatible =3D "active-semi,act8600";
                reg =3D <0x5a>;
-               status =3D "okay";
=20
                regulators {
                        vddcore: SUDCDC1 {


Now I wonder how it works without status =3D "okay" for you but not for =
me.

Does your test branch have additional patches which add this back?

Or does your board variant have better or different burnt in defaults =
than
my act8600 so that it runs without any driver?

The chip reads as:

ACTIVE
8601QJ
MD361

BR,
Nikolaus