Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1055570rwd; Thu, 15 Jun 2023 05:56:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5HWR6UuPLEDkvYEOwI7Zk0OCJjlzWIwugl38phBBHacMOxARUPbCLnv7N2+A+C2eO16FMp X-Received: by 2002:aa7:c557:0:b0:516:9f9a:a3a with SMTP id s23-20020aa7c557000000b005169f9a0a3amr12354720edr.1.1686833809786; Thu, 15 Jun 2023 05:56:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686833809; cv=none; d=google.com; s=arc-20160816; b=nKGTnIwd8cA8HAPuq4uJ10HkS3kN4zm+O+ntbb9xIjR2m+ZAcuy0VzoqgUDWFxpbiI 9gj28PMZWAFQkIWJmSZi4HVTR/8DrNhouAxYkpVnijeEdrvD1p6L+j2rEVR3j5IY2tHX FvkQF/djxtCArZYWE7xSUcY7IqDNRGZ0VameycBThds1568kQJ0G3fbdF+TMJXHKD/JJ 9W6nCauSf6R+ttkI7/rdSoSnQ25yWj+F5MkBr3U67WMvuhhdw2z9R55EHIMdqLPErCiB MhXo4/xUvqKTLztYa6ZK8Yhimhmc5mIaVmHqn8QpjMYtmj4dIVV9YCQGIZk2AMn5edJm eygg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=uaIhdmvUuSlALszbYYpfr4/xg82w2fYg/fbu4gtiFRc=; b=d2cltlSYeasSte9txVfYPTqV5J8WkUQu5hkdbj1WoNF+KFSm5/HZB3qU2jlObnALC3 B6HRcrPxqpX5EgQt5BYSo0Ud+vitGR0hKNncmdfYFAxuf93vOxree5mjaS9zyofL70TI O0pvUO5WQsGPzY0uXHgXKGyFREtULE+hLXdP16kIHtPuzJJGuzzBTcHlnwiEkA4jhzps Hi/Q0JysALdKdx8NGk+wubUKdtQRw7WyyCk1Rw9vd8CEbldOqe3jvNBWzLcfF8p6+/kX NyqqSOytM1T3XHRtT7H+LVSCpWJ6yd5eAArF577GII/Jhm8qniKDyl0uNDFIDVXBDFGj G3Mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hvEow0ZH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i10-20020aa7c70a000000b00514a244290fsi315418edq.310.2023.06.15.05.56.23; Thu, 15 Jun 2023 05:56:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hvEow0ZH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245385AbjFOMuF (ORCPT + 99 others); Thu, 15 Jun 2023 08:50:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245355AbjFOMtt (ORCPT ); Thu, 15 Jun 2023 08:49:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25C262126; Thu, 15 Jun 2023 05:49:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AEF46625CE; Thu, 15 Jun 2023 12:49:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DFCCC433C0; Thu, 15 Jun 2023 12:49:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686833388; bh=HM9QW1ikx4EuJYt+6nVJniUFb4xtHPyQLNFeKRRhfHw=; h=From:To:Cc:Subject:Date:From; b=hvEow0ZHKEwQzuT8JwSEbRj3CWwl1VS3v2SVeSkGQYCjPlNwOm63B6ylLPT00IPOk HgAJsVXawicgSu+UzO+s+j4/HMSIausAcbhBnDPqe4+8Mb8SZpDJT8+vLD2Hh0LN2V t2Ru7eZ36grvORvPf0dAqhkf30vEY5ZdCM5oZoCSXSz8tkndU4Y/7vSr+k0FK6C0J0 O/J9FJQ8lOr3gYy68rL4Qq4dLJ4vnW3h6kQF7c+g9PaOIMDvukUdm/65BgF02YaTk6 eTJhw7uBFb0rV9LYKBXhgu87ynbcaI4KE6qWl2Qzm7mMw2b9M6jxUl5kcHDmaQysc8 VXa8bskFdtX2Q== From: Jeff Layton To: Chris Mason , Josef Bacik , David Sterba Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] btrfs: update i_version in update_dev_time Date: Thu, 15 Jun 2023 08:49:45 -0400 Message-Id: <20230615124946.106957-1-jlayton@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When updating the ctime, we also want to update i_version. Signed-off-by: Jeff Layton --- fs/btrfs/volumes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) This is just something I noticed by inspection. There is probably no way to test this today unless you can somehow get to this inode via nfsd. Still, I think it's the right thing to do for consistency's sake. diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 841e799dece5..c62570b6eb0f 100644 --- a/fs/btrfs/volumes.c +++ b/fs/btrfs/volumes.c @@ -1918,7 +1918,7 @@ static void update_dev_time(const char *device_path) return; now = current_time(d_inode(path.dentry)); - inode_update_time(d_inode(path.dentry), &now, S_MTIME | S_CTIME); + inode_update_time(d_inode(path.dentry), &now, S_MTIME | S_CTIME | S_VERSION); path_put(&path); } -- 2.40.1