Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1169283rwd; Thu, 15 Jun 2023 07:13:53 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7V+nVDofoTKjqUusNypWiGTZahqyiqcs1b5UvY/7KzqvIHAhptxDNgKxPh8OAlLfSKyqfc X-Received: by 2002:a05:6512:3288:b0:4f2:34f1:cf24 with SMTP id p8-20020a056512328800b004f234f1cf24mr10202798lfe.22.1686838433290; Thu, 15 Jun 2023 07:13:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686838433; cv=none; d=google.com; s=arc-20160816; b=V3WQ/pziX+Z9R+h6R3rr6zZKJPIKft3eWze+BhD2szx55rEyWA9sjet6Zz457Vsz2N 8py7JDVEsWDvFqkJM83IBuj0ZpM1WNrsviL/jU6Z073s9dR1L5+hwJby14/8Szi/gWeM 5wG+S+bB2AbiLaB58+S2hORRqsYEmzDF7sp86SDBn/Ti3uV9pCa5jpoIFl7NjK8vUzNl kvqcA44GkVdExYV93QGLaemhFIqsBFqaBv4xKdVGR474CgktgEQC+cg2sPllYrVtfOeu O+edRaBgYeYGc+45tKQNViVQSkcXcGbnCschnp47n54XXNXx/PUr89CzxIL63pxEtukR 2+gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=sDHNO1PAXesphIz4ZpeHBoKhTalH641Kmbj+FZZsCa8=; b=RKgURr49px9GbNMaiTKjSvjs8Gvknd0mc7nIEYUh2/AHGWzY9BRGtiTCds1Lk7G1YG n42R5fWx/xyZQrkCwCy80H9p7u8HcPfYbce0S6RBrQ9ho6tCNy5G2yEmsHr0RA9z6wQE JM2GV2VosfCSSXzNgQDE9JUMfWd/vl7crEYHcASlDXAEblwm12KpRkXF3qsL3SKGluIn qkBTlAmGuEy1uC2DEBgwm2x6rq4MkRc9WukUmHHO5IZJ4k7UwVcbvzGnEvm26LlcK5AV 1i0uidSRvkgaBv0lvYbpwYpZ/bR+TnZH0UMC7jKZRhlCVwt3a2Uq2w+hxReDLX72hUQ+ sQoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="SZ2j3/pq"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a23-20020a17090640d700b009827a0ca95dsi2034801ejk.136.2023.06.15.07.13.26; Thu, 15 Jun 2023 07:13:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="SZ2j3/pq"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344720AbjFOOGG (ORCPT + 99 others); Thu, 15 Jun 2023 10:06:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344716AbjFOOGF (ORCPT ); Thu, 15 Jun 2023 10:06:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9D3F1FE8 for ; Thu, 15 Jun 2023 07:06:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5C1EA62D90 for ; Thu, 15 Jun 2023 14:06:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5466C433C0; Thu, 15 Jun 2023 14:06:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686837962; bh=2M6qrF4ORzCFN2c/lRhl6bHd4E8kwP4xtKpvVV/KLPQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SZ2j3/pqpnU3o0tWYY25t99Y4mtVRiNp4oN92bIm4SGfe5/v0MZI4RdQ1BuSrNUyI LKqNNYvYRHa7W62924yI+Oam42zxLrno6NgnmKv0xBem/Q2Z7XfSQHNh5GggpRLoVq euBJj5ihapWfib7GEbcoSVn7VELv/pYcEhsoz79HLG1baXAG7sI4tkas7UTSameS0K V4qRtM1xMt7234aPLA09cm3wLgpx/S6Z1c52XWvtsd7+r2orcPSpJa5u1Wq1Tu6UdC 4xZUpScsLiwj0zxdz8/tuR26Y4Mcan6RHALDjjbprZqXGkz5zDtPVzihNxBc+AAIxG D122hUsy/SxuA== Date: Thu, 15 Jun 2023 15:05:57 +0100 From: Lee Jones To: Amelie Delaunay Cc: Maxime Coquelin , Alexandre Torgue , Liam Girdwood , Mark Brown , Amelie Delaunay , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH 2/2] mfd: stmfx: Nullify stmfx->vdd in case of error Message-ID: <20230615140557.GG3635807@google.com> References: <20230609092804.793100-1-amelie.delaunay@foss.st.com> <20230609092804.793100-2-amelie.delaunay@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230609092804.793100-2-amelie.delaunay@foss.st.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 09 Jun 2023, Amelie Delaunay wrote: > Nullify stmfx->vdd in case devm_regulator_get_optional() returns an error. > And simplify code by returning an error only if return code is not -ENODEV, > which means there is no vdd regulator and it is not an issue. > > Fixes: d75846ed08e6 ("mfd: stmfx: Fix dev_err_probe() call in stmfx_chip_init()") > Signed-off-by: Amelie Delaunay > --- > drivers/mfd/stmfx.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Applied, thanks -- Lee Jones [李琼斯]