Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Jadav, Raag" <raag.jadav@intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     "linus.walleij@linaro.org" <linus.walleij@linaro.org>,
        "mika.westerberg@linux.intel.com" <mika.westerberg@linux.intel.com>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Sangannavar, Mallikarjunappa" 
        <mallikarjunappa.sangannavar@intel.com>,
        "N, Pandith" <pandith.n@intel.com>
Subject: RE: [PATCH v4] pinctrl: intel: refine ->irq_set_type() hook
Thread-Topic: [PATCH v4] pinctrl: intel: refine ->irq_set_type() hook
Thread-Index: AQHZn4gBPXOZzjOwf0Shiugls1EKsK+L15oAgAACIqA=
Date:   Thu, 15 Jun 2023 13:35:19 +0000
Message-ID: <DM6PR11MB2779FD7F6DF3A0126DB85E4B8C5BA@DM6PR11MB2779.namprd11.prod.outlook.com>
References: <20230615125022.27421-1-raag.jadav@intel.com>
 <ZIsOvBGLJTCo45jp@smile.fi.intel.com>
In-Reply-To: <ZIsOvBGLJTCo45jp@smile.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ySQw1xrrAARAkwAmEWxsKbM9rPXe8sS5URqRepmxODKrLOxN/0xhHzbK9jWN?=
 =?us-ascii?Q?DsTKLETT94mo4Fkx8SVBY2F1XjI/oQmvA4X2acsJKLgY7aad6lJdR2mHPuze?=
 =?us-ascii?Q?olaYMh67NC5Uypi2d48H9mAM5BuGbHR6tBLYWPIh5Eo9NBGgTGEuJSajdrpx?=
 =?us-ascii?Q?QbxWwb3iRA0DeH2LJkaUzhOiS21NoODbhZGurLHkJUdfXEOai2YVcjfN0bZZ?=
 =?us-ascii?Q?ZUG9uOECoHqsRqsyBFs7lA7TDX7Ne1psqTnTGA+EBNNvpz3KMWhVsH6+ussK?=
 =?us-ascii?Q?ECZgPmWi+GamllHcy/k8ZnCxVT9/9eiEJe3YcAuEm3rayI2WwMOCYV9z75QN?=
 =?us-ascii?Q?2HIheb8/FzN+uydK7aCWCKqXx6CXLPcCrTugJkYhv3fYxaaLmgBAM9gpAxEK?=
 =?us-ascii?Q?c0oN5XOmu/UonedyM/MX9VdjMGcCa2yvDO3ebHFLoVtg30InYxCg8ZcMzF+b?=
 =?us-ascii?Q?MKgG04syFYmppAKc7DyxJRyE1pRBlRKrt7cdlbJ97D/UfeqLztSIy+osb7dw?=
 =?us-ascii?Q?W48q+aJi37kO+/ceaS/9Zavgbt3kFXNLpDwA1YUy9pbs3xQ3UFSxLuT3tsTR?=
 =?us-ascii?Q?98nU4aI90/PBcf4umVKc0aW2aIjjaRDCMauykzb9d0ujmQWTuUJPS5opVLM1?=
 =?us-ascii?Q?RavZ0jgYFG8/nGl2Plkofmw/wXOHAoFfdJ4JgDjnRBG+cATfMZMH2gdE+yBe?=
 =?us-ascii?Q?0PGBKA8nVwp+xOKiz78Um6kjlpF9EYtuuhBYU/kfWs84IBXr6oRwSMh1lGjH?=
 =?us-ascii?Q?aZmth/2nespyADfdEtM2l+xC3qmo7wtsgCLOwN2veIH8n6EG/CRCheD/hBZ3?=
 =?us-ascii?Q?+uMjq3nrdaRaARfVZpEX1GyXRGHoqE/ZKsip9ZfrJj8AiSw2AGORlWDdurnn?=
 =?us-ascii?Q?xbQfLmOUjugl8dtrr+LBUJcsmjKQbwENrQikihVh49CA9FLe6fepnOi465WL?=
 =?us-ascii?Q?kX+kP0ZNIx0DhfNNVIjvdOCkv9WiN+w3KMhBmzVHxdnJi3JcWXhCkp/1hRUA?=
 =?us-ascii?Q?PomiEtHeHRUv53oyFAHLKK/2FDZ3Fnw4OYGmg4az3ufsIy9gHvAm3WOteg9n?=
 =?us-ascii?Q?+RF1G9bENQfC93yO1wihPiGw3yT/KifrUpgCyLYRkMLxQa9sz6Y8jicUoKHD?=
 =?us-ascii?Q?NH4XAcVIlHE6g18uPCcrYcT7752x0HCZlMHW2Dwdow4xw+q8fyPl/S2nuo9q?=
 =?us-ascii?Q?1cXzziT75+CA9uEDdc7O12veCb1TVh2ftyNUXdsLdwhX8Yhx7wbVx55s/Vnv?=
 =?us-ascii?Q?uNaH5k8csx/XoWaYN3uOulSKrm7cJFlwCOLPqg7BHb3sL+6BewriBrhkS0Bd?=
 =?us-ascii?Q?rdiw8VaW8RoAuxBiJwd1PRNh8VWl/+zYMlLb1KrWpLFvJDVMLDI7cKJf5vML?=
 =?us-ascii?Q?xeII4QlQ2uTeAX3D4erVBUJxk3vNG8XZ05H4CPWz7Os7cwIy12lc/qyOGthu?=
 =?us-ascii?Q?WkwQz64jGOe7kmBGQI3aJ63V+dTC91H8caHCSnM7M3+keYdFRfdHAsULrM9b?=
 =?us-ascii?Q?DSiQdxGfC/Jw0Sv+54rronb67gIHmpoZkzNG9B2TYGxOLYgrlfLgFsCNa4iU?=
 =?us-ascii?Q?JP6yapoILhNxSZYCjKs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2779.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b1e860c-74bf-462c-2964-08db6da55cab
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2023 13:35:19.4490
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 35jTNLQKP4tjA+9OPFykyoyAe19h7oFOcywWe/hcholfoiZ1A3UGYYrZ9dpi2YzSq4aLWhy28AEX72GzWr2dEw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6939
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Thu, Jun 15, 2023 at 06:20:22PM +0530, Raag Jadav wrote:
> > Refine ->irq_set_type() hook and improve its readability by:
> >
> > - Reducing scope of spinlock by moving unneeded operations out of it.
> > - Dropping redundant PADCFG0_RXEVCFG_SHIFT and including it directly
> >   into PADCFG0_RXEVCFG_* definitions.
> > - Utilizing temporary variables for common operations.
> > - Simplifying if-else-if chain.
>=20
> Two questions out of curiosity.
> Do we gain or lose bytes with this?

add/remove: 0/0 grow/shrink: 1/0 up/down: 33/0 (33)
Function                                     old     new   delta
intel_gpio_irq_type                          317     350     +33
Total: Before=3D10469, After=3D10502, chg +0.32%

> > +	value =3D readl(reg);
>=20
> > +	value =3D (value & ~PADCFG0_RXINV) | rxinv;
> > +	value =3D (value & ~PADCFG0_RXEVCFG_MASK) | rxevcfg;
>=20
> Same question if we change this to be similar to the current code, i.e.
>=20
> 	value =3D readl(reg);
>=20
> 	value &=3D ~(PADCFG0_RXEVCFG_MASK | PADCFG0_RXINV);
> 	value |=3D rxevcfg;
> 	value |=3D rxinv;
>=20
> And I would keep blank lines after readl() and before writel() since we h=
ave
> more than a single line in between.

add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-9 (-9)
Function                                     old     new   delta
intel_gpio_irq_type                          317     308      -9
Total: Before=3D10469, After=3D10460, chg -0.09%