Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <763cc719-f62d-529c-a1fd-75cb2554a84b@kernel.dk>
Date:   Thu, 15 Jun 2023 07:37:36 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] tools/io uring: Fix missing check for return value of
 malloc()
Content-Language: en-US
To:     cymi20 <cymi20@fudan.edu.cn>
Cc:     "ammarfaizi2@gnuweeb.org" <ammarfaizi2@gnuweeb.org>,
        "asml.silence@gmail.com" <asml.silence@gmail.com>,
        "io-uring@vger.kernel.org" <io-uring@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20230615125045.125172-1-cymi20@fudan.edu.cn>
 <34898926-681e-1790-4303-e2b54e793a62@gnuweeb.org>
 <ec762677-f8d4-94ab-e7b3-adee45a052a1@kernel.dk>
 <F5DC6786-D8E5-435F-8FDE-ABD4DD692367@fudan.edu.cn>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <F5DC6786-D8E5-435F-8FDE-ABD4DD692367@fudan.edu.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/15/23 7:26?AM, cymi20 wrote:
> Actually this checker is driven by inconsistency, it find almost all
> callsite of malloc() in this module has Null check, except this
> callsite.

1) don't top post
2) don't send html emails

But more importantly, actually check the code before making wrong
statements like that.

The patch is pointless.

-- 
Jens Axboe