Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alexander Stein <alexander.stein@ew.tq-group.com>
To:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        Marek Vasut <marex@denx.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Markus Niebel <Markus.Niebel@ew.tq-group.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux@ew.tq-group.com
Subject: Re: [PATCH 1/3] dt: bindings: add bindings for TQMa93xxLA SOM
Date:   Thu, 15 Jun 2023 16:46:20 +0200
Message-ID: <6315067.GXAFRqVoOG@steina-w>
Organization: TQ-Systems GmbH
In-Reply-To: <1bf1890f-d24c-12a1-217d-27579a2464a6@linaro.org>
References: <20230609132915.634338-1-alexander.stein@ew.tq-group.com> <20230609132915.634338-2-alexander.stein@ew.tq-group.com> <1bf1890f-d24c-12a1-217d-27579a2464a6@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Precedence: bulk

Hi,

Am Freitag, 9. Juni 2023, 17:58:17 CEST schrieb Krzysztof Kozlowski:
> On 09/06/2023 15:29, Alexander Stein wrote:
> > From: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> >=20
> > TQMa93xxLA is a SOM variant in the TQ-Systems GmbH TQMa93xx series using
> > NXP i.MX93 CPU on an LGA type board.
> > MBa93xxCA is a starterkit base board for TQMa93xxLA on an adapter board.
>=20
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching.
>=20
> It is dt-bindings, not something else.
>=20
> A nit, subject: drop second/last, redundant "bindings for". The
> "dt-bindings" prefix is already stating that these are bindings. One
> bindings is enough.

Thanks. I'll update that.

> > Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> >=20
> >  .../devicetree/bindings/arm/fsl.yaml          | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> >=20
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
> > b/Documentation/devicetree/bindings/arm/fsl.yaml index
> > 2510eaa8906dd..8048c7f6a299d 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> >=20
> > @@ -1219,6 +1219,25 @@ properties:
> >                - fsl,imxrt1170-evk         # i.MXRT1170 EVK Board
> >           =20
> >            - const: fsl,imxrt1170
> >=20
> > +      - description:
> > +          TQMa93xxLA and TQMa93xxCA are two series of feature compatib=
le
> > SOM +          using NXP i.MX93 SOC in 11x11 mm package.
> > +          TQMa93xxLA is designed to be soldered on different carrier
> > boards. +          TQMa93xxCA is a compatible variant using board to
> > board connectors. +          All SOM and CPU variants use the same devi=
ce
> > tree hence only one +          compatible is needed. Bootloader disables
> > all features not present +          in the assembled SOC.
> > +          MBa93xxCA mainboard can be used as starterkit for the SOM
> > +          soldered on an adapter board or for the connector variant
> > +          MBa93xxLA mainboard is a single board computer using the
> > solderable +          SOM variant
> > +        items:
> > +          - enum:
> > +              - tq,imx93-tqma9352-mba93xxca # TQ-Systems GmbH i.MX93
> > TQMa93xxCA/LA SOM on MBa93xxCA +              -
> > tq,imx93-tqma9352-mba93xxla # TQ-Systems GmbH i.MX93 TQMa93xxLA SOM on
> > MBa93xxLA SBC
> xx sound like wildcard which you should not use. If you open the product
> page, it also suggests that.

xx is a wildcard only for modules TQMa93xx, depending on the soldered SoC, =
but=20
not for the mainboard MBa93xx.
You are right that there is the ordering number MBa9352LA-AA, so the=20
compatible would be "tq,imx93-tqma9352-mba9352la". But the actual values fo=
r=20
the wildcards is copied from the soldered module. So using a TQMa9351LA wou=
ld=20
result in MBa9351LA-AA, although the mainboard is identical.

Best regards,
Alexander

> Best regards,
> Krzysztof


=2D-=20
TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht M=FCnchen, HRB 105018
Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider
http://www.tq-group.com/