Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 15 Jun 2023 15:49:23 +0200
From:   Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To:     YueHaibing <yuehaibing@huawei.com>
CC:     <bjorn@kernel.org>, <magnus.karlsson@intel.com>,
        <jonathan.lemon@gmail.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
        <ast@kernel.org>, <daniel@iogearbox.net>, <hawk@kernel.org>,
        <john.fastabend@gmail.com>, <netdev@vger.kernel.org>,
        <bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <maxtram95@gmail.com>
Subject: Re: [PATCH net-next] xsk: Remove unused inline function
 xsk_buff_discard()
Message-ID: <ZIsW47S1Pdzqxkxt@boxer>
References: <20230615124612.37772-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230615124612.37772-1-yuehaibing@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9dEdqS3WdSXnGLUE8VtnkNOBBWbOFqoS+Mcry/8SzAK3Dr5FhZ0LziZen66D?=
 =?us-ascii?Q?18y6iy/UGfC98ZNSjHLYp7xk1VrhWgVb91UPSoY1DhQlWSfwlkCO/odoiELm?=
 =?us-ascii?Q?pL/nJHJe0DSQ5S7MInIkbZZHLVzroLAFgDvCGke37rAGT6awEH7sBfcd23zi?=
 =?us-ascii?Q?uK5fTQgDfnLADtPE9yFaCKzzGCEkLtyHdInHFjV/CLfHpFSl+us+SEZkln13?=
 =?us-ascii?Q?iyQbUiTmd6LpGKPcP+KixaS6q5tzkCYpLZauoEDIiyPGLtvR7icZm2W71XcU?=
 =?us-ascii?Q?CSo8kzvYhMfLSEsNijFw/vDrfm3UmCpOk0i7XZT1ZK7VRjTs2ZPkhl/+UU97?=
 =?us-ascii?Q?J9F9M8yV51c6DSlSN/pwBeC39qIOEw+6AKEq1l6fov05vQE93GbuCkCqncKj?=
 =?us-ascii?Q?R4oiuDuaH/YJKhiJb6VVyBYlRZmI5vHiEKpfAn3FIRS/bVeFXtHVdQ2e0Exn?=
 =?us-ascii?Q?LXxPBf7buSCYG4PCaEXN2oTHHUlklKwGWilx0trk3AABPsQI6XzIaC36CqRj?=
 =?us-ascii?Q?zsCMRtt9DH9nUnTAdAX2inM+ExQgvQKIgKF8aaKDWLILtEggfIfjbJumx8u9?=
 =?us-ascii?Q?tMUFyK1Al6q69as+aeWY5GWdKZsh5+/eEEg5ZriAyQBHKhUYBIf1UJn+v6RA?=
 =?us-ascii?Q?wEgIzZNI9KjLe0iOsPM38huslhTZNu8pEoeT/ol9LgBSqtIE5iBtMfudXhuB?=
 =?us-ascii?Q?Vb6iXhJctL3s5z84IDmZbPFAAnWo79t5fKAPy+F5Eoht3xDxR3yx5sRmTl17?=
 =?us-ascii?Q?QoLLFJ18gbgDTqHAWZYDb7axHjSEnufIfG8xXRX5EItJjDVDDzg0xTp8udpz?=
 =?us-ascii?Q?NPiTt9JI+8nG3itGBihZcTWmLjvhhhmkerXS/kQBhn/lgij2o3LC2uEsbRL/?=
 =?us-ascii?Q?VbiljiR3L692+7Cg9ppOxWo4Qzn1Pu6ZrOe+noLm+9LPbrFhgcAlLfPNDG0m?=
 =?us-ascii?Q?I2K78O5pGDxexs1Ed2ycpTo41K441KWI7ghv6hEcFl0LasijRBkvgG+BXRFk?=
 =?us-ascii?Q?HIYZt84eVqTIPYLmlQIRepd79Kpiisl1CmubuLD65y/+kQjN517yyZY9Gb1T?=
 =?us-ascii?Q?i09nlme11xyPxklE8wANSzrNfkKteJsPpmGUAC6qNYuKVq/QfNGqJEg/NILz?=
 =?us-ascii?Q?ok75u/uzUUNXyBmy5EoKrvqcYlTXm4Nf70uBxuUpiJ+sydneqHTNZCVuIgGh?=
 =?us-ascii?Q?OpVXY0KVcBot6/BKAu9jNtFwsI1Ntikvalc7FXig5pJbTbn7TUGt6ZnKIllz?=
 =?us-ascii?Q?5ovTOgEpBcoDQq1POlOiYenHGGqR1XDzPd5Ly9S20Ml3FF5ZMy1J4usU024w?=
 =?us-ascii?Q?SYyHaFin4jfrd2txszG35P9WWu9dvDIq7Ef5BgiqE5e5rmquFOI5csVEdkIB?=
 =?us-ascii?Q?8Ynr0YZcLEMVWJHHnV9EVKt8hS4W2PRqUgagBQ9dq7IuGOs70h8PchVjpObo?=
 =?us-ascii?Q?iuPFOY99UdItdh/XnQbx/6ggW2sFqw+G+XgBeZpBKa5FRy6dInmn8J9JTzSD?=
 =?us-ascii?Q?V3ADIHE86zfIFTCb0fMumrt49DpZf3aBOCflTHvsbpHP8GvM3I6gXqp1nLnG?=
 =?us-ascii?Q?tpwAlMM0PqqKlWef5eI4uXQoQty5LDThZyLuwcbT8RUjmHywhTrRSghQny5j?=
 =?us-ascii?Q?6w=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 54fa059e-c67f-4533-5251-08db6da75848
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6117.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 13:49:31.3211
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9r0Sp2Ed0nzrV6S+2M7Qu8hMk9inbNmr/MtmwDMq7ffwAn1oi7xhynYQwchLikbq1oqzMUpqqY9CBBN+8iQKxu8kbY/9NN7GUN4331m50Vc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6450
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 15, 2023 at 08:46:12PM +0800, YueHaibing wrote:
> commit f2f167583601 ("xsk: Remove unused xsk_buff_discard")
> left behind this, remove it.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Yeah this is a stub for !CONFIG_XDP_SOCKETS...

Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>

> ---
>  include/net/xdp_sock_drv.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/include/net/xdp_sock_drv.h b/include/net/xdp_sock_drv.h
> index 9c0d860609ba..c243f906ebed 100644
> --- a/include/net/xdp_sock_drv.h
> +++ b/include/net/xdp_sock_drv.h
> @@ -255,10 +255,6 @@ static inline void xsk_buff_free(struct xdp_buff *xdp)
>  {
>  }
>  
> -static inline void xsk_buff_discard(struct xdp_buff *xdp)
> -{
> -}
> -
>  static inline void xsk_buff_set_size(struct xdp_buff *xdp, u32 size)
>  {
>  }
> -- 
> 2.34.1
> 
>