Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <4594248c-b7c5-46cb-7d02-063c8235f5d2@roeck-us.net>
Date:   Thu, 15 Jun 2023 07:45:14 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [RFT] Prototype of new watchdog
Content-Language: en-US
To:     Christophe Leroy <christophe.leroy@csgroup.eu>,
        Oliver Neukum <oneukum@suse.com>,
        "linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20230615104137.20304-1-oneukum@suse.com>
 <20230615104137.20304-2-oneukum@suse.com>
 <1282253f-29a4-f6ad-8d7a-36efb02e040a@csgroup.eu>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <1282253f-29a4-f6ad-8d7a-36efb02e040a@csgroup.eu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/15/23 07:29, Christophe Leroy wrote:
> Please explain what this driver is.
> 
> Is that a driver for a new type of pcwd_usb ?
> Is that a new driver for an existing equipment ? Why a new driver then ?
> 
> If it is an evolution of the existing driver, please do it in place of
> the existing driver so that we see what is changed and what remains.
> 

Agreed, this should be a patch modifying pcwd_usb.c to use the watchdog core.
Any cleanups should be sent as separate patches.

Thanks,
Guenter