Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8504c5e0-cddd-4a1a-4b61-627bcdfad434@amd.com>
Date:   Thu, 15 Jun 2023 11:09:55 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Cc:     yazen.ghannam@amd.com, linux-kernel@vger.kernel.org,
        tony.luck@intel.com, x86@kernel.org, muralidhara.mk@amd.com,
        joao.m.martins@oracle.com, william.roche@oracle.com,
        boris.ostrovsky@oracle.com, john.allen@amd.com,
        baolin.wang@linux.alibaba.com
Subject: Re: [PATCH 1/3] x86/MCE/AMD: Split amd_mce_is_memory_error()
To:     Shuai Xue <xueshuai@linux.alibaba.com>, linux-edac@vger.kernel.org
References: <20230613141142.36801-1-yazen.ghannam@amd.com>
 <20230613141142.36801-2-yazen.ghannam@amd.com>
 <9d0adc21-5b71-a949-fc6d-95dd7ef6f0a7@linux.alibaba.com>
 <cd4fc492-074f-290f-81ac-cb65715c51b0@amd.com>
 <fcb4a4a9-b266-6135-48f1-c00957ca4dc2@linux.alibaba.com>
Content-Language: en-US
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <fcb4a4a9-b266-6135-48f1-c00957ca4dc2@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cktlSHhWMzFwcGx5Qmd1d2NVUG12c21xa241bTZKZWRHMUlBRmphVlpEWXlo?=
 =?utf-8?B?ei9YNk5aYksvZVRjclBWekUvZVdrWDZtMkVKMFlNRWI2TW1TUDZFbldNOXFs?=
 =?utf-8?B?SHpieWpETkZ4SU9UeUhMNTZqTlc3RUd4V0ZkNnJuQithT1FMeFFMM0RxTUhC?=
 =?utf-8?B?N1d6YVk0ZG0vWEdybFBSdHhtRElIb1hRRjlCby9yVXU0em9CMExVZTQwdDYx?=
 =?utf-8?B?eFhhbXBwVDV4QnVlOWNJenc4Vi9CaFRuVG5oYzRtcHZCTFhFSG9QNWJLR2sw?=
 =?utf-8?B?M2s5VEcyalFZOG1OUCt4TXl4aThrZXpJNWs0U09HdHFRQnhxNHgxTVkyLzZU?=
 =?utf-8?B?cW4wSElzSlNTWEZ2WnZvZ3BPemhvS1lOMG55elhHSmQwTElYNlBXVlVEc1hW?=
 =?utf-8?B?V1R3WExaNmNzQ3FNOTdFU0luR3RheFh4SnMzR0piOHoxNGoyT3cvcUVuLzJD?=
 =?utf-8?B?ZW85K0YybVhHL0w2M0N0QnRqWXo4UzYzbnRBZnRVVWxDdVJZMWZzVjdQcmov?=
 =?utf-8?B?YzllU3k5YVVMVXJabkZlV1plUVRXZk9DaUJ1OWZaSVNQSHZrZy9yUWFsKzNh?=
 =?utf-8?B?dG8xa3JHWU5ta3dzWFl1cmljWDZHT05oMHNqbzVJdXpPMXN3VWhSa29VZmE3?=
 =?utf-8?B?STFES0ovS2VnMFVDaGR6bE9wSkFQQlhOcEdBd3ZvMk1tenZ4NWtrK2NMdVZi?=
 =?utf-8?B?YVg4OEVGVnVKbk9mbjIyVXdZM0VhSVpyTVpQUFVtSlFTSVlPenVkalZpTGY2?=
 =?utf-8?B?cXVMcU56RWsycndyWTlKbTkvSmZqNytyazFwSjB3K1FkSnlBcnQ3YXVWTFhQ?=
 =?utf-8?B?YkNUZU9CL2tsbG8wUUt6aTRFTlJHem4xSWZoV2tJdzBmZ3d0dExDNGp1UWIr?=
 =?utf-8?B?eXlvR2pOeDFySHR1c2FaUTNwV0ZyNUlUbEUyMXkrVTY5bDNaS3dTYVJCZFMw?=
 =?utf-8?B?Q2FjLzVtc3FVQ1QzZm1kcHNmVllxREhYRU5jc0NQNDU2eVMwd05oenhTdFRD?=
 =?utf-8?B?OGR5RWgwTzZxc0xHdmNMQXc3UTQ0SHlzSGlPTkVwTnZlS1pkWlRHUHpEYy9Z?=
 =?utf-8?B?NGFROXBXS1FkYjJhdThudy9xaEhmeDJwbzBBOG5Nay9ySjlEeTkyMDVaVU5W?=
 =?utf-8?B?bGZIV3dsd2VpVUJtdVdkZTlHRzRtOW04Z2x2VURjSDN5WER2dk4wQVIvb3RB?=
 =?utf-8?B?US9zSEZiQ24xTGNKalJOUDVSOExBM1FwdndDUlNoSisyUGxkS1p6SEpuSENY?=
 =?utf-8?B?cVhseWRCdGNJZmJIUnlCV3ZDUDRXTm1xMmNOUTVFKytWWm53TG84cHkweTB5?=
 =?utf-8?B?VWNYR0xmQzBwcm9qZ3UvV3FXM1J5V3JHU2tRc0lZSHRsL1N1aTZzVS9DaFo1?=
 =?utf-8?B?cE04cGU5OVRuaXIwT25DS09qQWxjODMzTlJ4MDBWc3JvYXlHakdFTmtYUE9W?=
 =?utf-8?B?alEvMlVyQTFiL0QzTU9TT0tGNVVjVjVtK2NCSy9RMWZKYzhLUHNOVi9ubUpC?=
 =?utf-8?B?Z3pmbFZldEJWL1czTmFtL2VuRGpnUFcvNGF6WlY2YWc5SFo3b1JpemY5RU1j?=
 =?utf-8?B?ak1PRjFHUTlmSEdlUG9NdmtwZ1Z0b2cwVWpiMmFEWVA5ZE9HVXNOWHdDa212?=
 =?utf-8?B?cVBWcm5oa0V6WFBodVRacEh3QzBYOHlhQ3l1WVVXK1BNbGFVbldOUDBVZWRW?=
 =?utf-8?B?MGFEUGNwbUNVblJ4OW9Ka2xvSFBJSElTMmxXTlkxeHc1bytTeXd6MHNpMmly?=
 =?utf-8?B?em1lZzBrcGY3TkNlVVpnK0R5Y2tDQXN1ZVByZFNKZjhpNkxtY1NpZ0t1WGRz?=
 =?utf-8?B?bVNYQjNSSkxkNmliaUFrSE5OVUd6SDdyalVnbHZoVEphL1NmTmdyK0ZHMmh5?=
 =?utf-8?B?dlIvWU5BckNnRUpnbEhUVklhRkZiYTUxY3daK0JxTHlEcjVSUFdYTCtqUllE?=
 =?utf-8?B?OXhCOXE1dEk1QnRFblkvcjlQM2VodlFSVjJMNm1KQUZnd2VYclB4RXFuV1dl?=
 =?utf-8?B?SmVzTlBoU05xazlGVCt0czlyTTVzeWNBSExOSXNMbTh0NEJyd2FUWDlJV2Z1?=
 =?utf-8?B?dFg3Sm1yZWp5ZFovb3dzaEJTVm9PZjZmQTNEOWlQWC9DMVRWQ2JTQzZhRkVw?=
 =?utf-8?Q?e7Y2Hj8cbr41cXiNCZ9G/P1Df?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32e685ea-d4ec-4662-60ea-08db6db29645
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3109.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 15:09:59.8242
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JoitwXhigtC+TAfB8U0iW9HKXKflOHO//LAte9q+29MYDvR5Hcv/rJgDrDHhFCoI0JhMgL2tYoIP00gTs6uJ3Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8406
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/14/2023 10:03 PM, Shuai Xue wrote:
> 
> 
> On 2023/6/14 23:06, Yazen Ghannam wrote:
>> On 6/13/2023 10:06 PM, Shuai Xue wrote:
>>>
>>>
>>> On 2023/6/13 22:11, Yazen Ghannam wrote:
>>>> Define helper functions for legacy and SMCA systems in order to reuse
>>>> individual checks in later changes.
>>>>
>>>> Describe what each function is checking for, and correct the XEC bitmask
>>>> for SMCA.
>>>>
>>>> No functional change intended.
>>>>
>>>> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
>>>> ---
>>>>    arch/x86/kernel/cpu/mce/amd.c | 30 +++++++++++++++++++++++++-----
>>>>    1 file changed, 25 insertions(+), 5 deletions(-)
>>>>
>>>> diff --git a/arch/x86/kernel/cpu/mce/amd.c b/arch/x86/kernel/cpu/mce/amd.c
>>>> index 5e74610b39e7..1ccfb0c9257f 100644
>>>> --- a/arch/x86/kernel/cpu/mce/amd.c
>>>> +++ b/arch/x86/kernel/cpu/mce/amd.c
>>>> @@ -713,17 +713,37 @@ void mce_amd_feature_init(struct cpuinfo_x86 *c)
>>>>            deferred_error_interrupt_enable(c);
>>>>    }
>>>>    -bool amd_mce_is_memory_error(struct mce *m)
>>>> +/*
>>>> + * DRAM ECC errors are reported in the Northbridge (bank 4) with
>>>> + * Extended Error Code 8.
>>>> + */
>>>> +static bool legacy_mce_is_memory_error(struct mce *m)
>>>> +{
>>>> +    return m->bank == 4 && XEC(m->status, 0x1f) == 8;
>>>> +}
>>>> +
>>>> +/*
>>>> + * DRAM ECC errors are reported in Unified Memory Controllers with
>>>> + * Extended Error Code 0.
>>>> + */
>>>> +static bool smca_mce_is_memory_error(struct mce *m)
>>>>    {
>>>>        enum smca_bank_types bank_type;
>>>> -    /* ErrCodeExt[20:16] */
>>>> -    u8 xec = (m->status >> 16) & 0x1f;
>>>> +
>>>> +    if (XEC(m->status, 0x3f))
>>>> +        return false;
>>>>          bank_type = smca_get_bank_type(m->extcpu, m->bank);
>>>> +
>>>> +    return bank_type == SMCA_UMC || bank_type == SMCA_UMC_V2;
>>>> +}
>>>> +
>>>> +bool amd_mce_is_memory_error(struct mce *m)
>>>> +{
>>>>        if (mce_flags.smca)
>>>> -        return (bank_type == SMCA_UMC || bank_type == SMCA_UMC_V2) && xec == 0x0;
>>>> +        return smca_mce_is_memory_error(m);
>>>>    -    return m->bank == 4 && xec == 0x8;
>>>> +    return legacy_mce_is_memory_error(m);
>>>>    }
>>>>      static void __log_error(unsigned int bank, u64 status, u64 addr, u64 misc)
>>>
>>> Hi, Yazen,
>>>
>>> Which tree are you working on? This patch can not be applied to Linus master ?
>>> (commit b6dad5178ceaf23f369c3711062ce1f2afc33644)
>>>
>>
>> Hi Shuai,
>>
>> I'm using tip/master as the base.
>> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/log/
>>
>> Sorry, I forgot to mention this in the cover letter.
> 
> Ok. This patch itself looks good to me.
> 
> Reviewed-by: Shuai Xue <xueshuai@linux.alibaba.com>
> 

Thank you!

-Yazen