Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Ruhl, Michael J" <michael.j.ruhl@intel.com>
To:     Joe Perches <joe@perches.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "apw@canonical.com" <apw@canonical.com>,
        "dwaipayanray1@gmail.com" <dwaipayanray1@gmail.com>,
        "lukas.bulwahn@gmail.com" <lukas.bulwahn@gmail.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "david@redhat.com" <david@redhat.com>
Subject: RE: [PATCH] checkpatch: Include GEM_BUG_xxx variant in the excluded
 check list
Thread-Topic: [PATCH] checkpatch: Include GEM_BUG_xxx variant in the excluded
 check list
Thread-Index: AQHZnuBLo8//l5DYL061VraX79fiSq+LGOsAgADel8A=
Date:   Thu, 15 Jun 2023 15:04:43 +0000
Message-ID: <IA1PR11MB641820FC52D35D1CECE6830DC15BA@IA1PR11MB6418.namprd11.prod.outlook.com>
References: <20230614164955.1319870-1-michael.j.ruhl@intel.com>
 <b777a049b3817c7eee364310aac89470e9ea882e.camel@perches.com>
In-Reply-To: <b777a049b3817c7eee364310aac89470e9ea882e.camel@perches.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?w2lNGFU39/T+8AsEDmUjgxaUTs6veL8hv5mwOE7iovztwbzQgTgIbsh5B9gv?=
 =?us-ascii?Q?NklfxspX5/7E42EzZ52bPtsPYf5Jvos3vBgVctQDCGIaLx7rmPjqTvN8noYx?=
 =?us-ascii?Q?isFvJu6F81HDjZKLn96SniKstItWIMm0SDbvEHQnEGqNUl3Ydy/Nh0ho5CC8?=
 =?us-ascii?Q?8w8ykB/KZTbFN70SqQLuOtnJLhpnXLOS7j2fgNSl6MF+TqFT4Th7rQ1YHfm/?=
 =?us-ascii?Q?s92LlEhiqfIaSvxgK5+4JdKn0X1WQrFsNZu/jEePE4yAqibLcGm7ob/8mgtZ?=
 =?us-ascii?Q?TgARhHEVQWAdy1WVlNZsLhJtWx96FygEN9BoUOl9NhW2TWTlQGIgm2F6dOib?=
 =?us-ascii?Q?56N6gVy7FVM2VbMrIrHOLV+xu8UwoWCikphEdovwgBPHu2gDpLVOEZFbUMqd?=
 =?us-ascii?Q?ozNkl2BYfQ52DEGL7x279LOm2e7CDJvCp3nrwcW6qqjCSnvjXaxEtDHzCYp4?=
 =?us-ascii?Q?EdFTRh9fCdxki8hPvOulZRImJ4/WqN2hHhA4CeCfzWVJMU1swmgvddpjOsay?=
 =?us-ascii?Q?Bml/H2kyDyxHV8ZkskoLZ8PoP5ht7iM2Hh4bsHdrwb+5wZX1sLZrhpeKINWS?=
 =?us-ascii?Q?HJYPgG3N8+UvXkuYy2J6tdRFZhT6NnGnGo5UG4dMi83kpZFEaIJTibGXk+Ld?=
 =?us-ascii?Q?onTqnVy4mqdcStoFAbKHtVJbndxPyzkRzc5LnK/ilHC04OtdRrnqknwDQ12p?=
 =?us-ascii?Q?eg5YHlPsYritppbDKYEHnV6uotjrEyAP1Ddv24iFeJP82J4yi2F5JZFQaz0m?=
 =?us-ascii?Q?7LgMrrG8eW8Innw+cuVn1AIkBaxEyWBTzqs/mx6aathAA/Z0mSMKoCvh6K3o?=
 =?us-ascii?Q?LEkLfIa/h1xdh0Owpn8n+bcR1x3gK3ZI31PPs+UC6mU6S1ivpb4+ZF5D+rwq?=
 =?us-ascii?Q?WXhdGqb04/B+DmSXu94YOV+0uZl/eFPjoxwzO4zBgwQYX3NTZrR0rfLFOVtV?=
 =?us-ascii?Q?2QVmTF87HFq34RdxHBzviVNvQ5OQB5kePqSFaldG78PWWEFfKR8fzps8osgT?=
 =?us-ascii?Q?NfZVgmn1e1uWu91UPwh9uuy+PZLGkUw8GkkauQEKduYMetHcV6iWQffhO3Ha?=
 =?us-ascii?Q?iRFLUF3SIuIRd66itbvxSESjJPWyJCW7e14AuBgkFHSg5qpdmE3vZxwLh9Oa?=
 =?us-ascii?Q?+jD6Wy2EevHKLLtHjQhDnkukbr6FyluPZyUgTL0++Xb1OGWMMR+S+F9NOofZ?=
 =?us-ascii?Q?a32b51svyADZgg6xq1iACuvRNA6CgvkMdfad3gy6mLd2F4BzunfSZ5C4bgIZ?=
 =?us-ascii?Q?yWkZqNxM+NzYpsVp1DHQDCPlnis6dNe5OdrkpkIxInUQq99W28QHyFyRLhZF?=
 =?us-ascii?Q?UBp2NYG1wta0Zph/rQUaZWrul7JBkyh9Yg54awUSb6U9rGDCE9050PG8h/j9?=
 =?us-ascii?Q?+Tkzu+aHlxUgqe7XHd6dFLoIORKazn2gXzndTdrltj6ZgJE8asuMRAMmzuzB?=
 =?us-ascii?Q?7PJ19/KxAiC0Jukn/hdSmLqdQu1KKdHHkv3CzFCO4EZ1QAjtL5t3RhXHlNBF?=
 =?us-ascii?Q?AVXnJIa5OIq1+txCNsMYgd1zEOGH8kUrdwmz+BkFAqw5X84tuNrYdGU4xQ9Y?=
 =?us-ascii?Q?w0eIfLOqwKss9qYSVKl2h/sYXUs3UxzXzxrLO66X?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6418.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: babdcf8f-33db-4b05-a45c-08db6db1d9aa
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2023 15:04:43.1483
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DgKg93w/PgadNWabLa8Zb60ZFn8O4Ib5cXtRUJYjRmpMXlbsR/auI9C+uo7lfjxdSW9GRdC1NZ+nSuOjg0Y7YkiFNbjYwTaN+FQh+4y4800=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4622
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>-----Original Message-----
>From: Joe Perches <joe@perches.com>
>Sent: Wednesday, June 14, 2023 9:47 PM
>To: Ruhl, Michael J <michael.j.ruhl@intel.com>; linux-kernel@vger.kernel.o=
rg;
>apw@canonical.com; dwaipayanray1@gmail.com; lukas.bulwahn@gmail.com;
>corbet@lwn.net; david@redhat.com
>Subject: Re: [PATCH] checkpatch: Include GEM_BUG_xxx variant in the
>excluded check list
>
>On Wed, 2023-06-14 at 12:49 -0400, Michael J. Ruhl wrote:
>> GEM_BUG_ON is usually compiled as WARN.  You have to change to
>> debug configuration to get this to be BUG.
>>
>> checkpatch flags this a WARN level issue.
>>
>> Since this is a i915 local debug macro, allow its use in checkpatch.pl.
>>
>> Fixes: 69d517e6e210 ("checkpatch: warn on usage of VM_BUG_ON() and
>other BUG variants")
>
>Not a "Fixes", just an additional check

That makes sense.

Do I need to resubmit without the Fixes?

Thanks,

M

>>
>> Signed-off-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
>> ---
>>  scripts/checkpatch.pl | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
>> index b30114d637c4..d3ddde4cd63e 100755
>> --- a/scripts/checkpatch.pl
>> +++ b/scripts/checkpatch.pl
>> @@ -4821,7 +4821,7 @@ sub process {
>>  		}
>>
>>  # do not use BUG() or variants
>> -		if ($line =3D~
>/\b(?!AA_|BUILD_|DCCP_|IDA_|KVM_|RWLOCK_|snd_|SPIN_)(?:[a-zA-
>Z_]*_)?BUG(?:_ON)?(?:_[A-Z_]+)?\s*\(/) {
>> +		if ($line =3D~
>/\b(?!AA_|BUILD_|DCCP_|GEM_|IDA_|KVM_|RWLOCK_|snd_|SPIN_)(?:[a
>-zA-Z_]*_)?BUG(?:_ON)?(?:_[A-Z_]+)?\s*\(/) {
>>  			my $msg_level =3D \&WARN;
>>  			$msg_level =3D \&CHK if ($file);
>>  			&{$msg_level}("AVOID_BUG",