Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <11412b24-c107-247b-5e6f-1a95a737a9f7@lwfinger.net>
Date:   Thu, 15 Jun 2023 10:45:26 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [RFC 1/1] wifi: rtw88: Add support for the SDIO based RTL8723DS
 chipset
To:     Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
        Yan-Hsuan Chuang <tony0620emma@gmail.com>,
        Kalle Valo <kvalo@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
        Ping-Ke Shih <pkshih@realtek.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        Emil Renner Berthing <emil.renner.berthing@canonical.com>
References: <20230615142044.1357257-1-heinrich.schuchardt@canonical.com>
Content-Language: en-US
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <20230615142044.1357257-1-heinrich.schuchardt@canonical.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/15/23 09:20, Heinrich Schuchardt wrote:
> Wire up RTL8723DS chipset support using the rtw88 SDIO HCI code as
> well as the existing RTL8723D chipset code.
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> 
> On my Lichee RV Dock board this patch is enough to make The RTL8723DS
> work. But unfortunately after running some time the driver crashes.
> My impression is that the crash is not specific to my patch but must
> be hidden in one of the existing functions it is invoking.
> 
> This seems to be related to not checking pkt_stat->pkt_len.
> 
> My kernel was built against v6.4-rc6.

Heinrich,

Martin Blumenstingl has written a driver for the 8723ds chip. It has been merged 
into the wireless-next tree, and will be in mainline kernel 6.5. In addition, it 
is available at https://github.com/lwfinger/rtw88.git.

Please try it to see if it files your crash problem. Several users of rtw88 have 
reported success.

Larry