Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Veerasenareddy Burru <vburru@marvell.com>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>,
        "kuba@kernel.org" <kuba@kernel.org>
CC:     Abhijit Ayarekar <aayarekar@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        Satananda Burla <sburla@marvell.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH v2] octeon_ep: Add missing check for ioremap
Thread-Topic: [EXT] [PATCH v2] octeon_ep: Add missing check for ioremap
Thread-Index: AQHZnzpDxg+7kcTPbkOyYcqZVs5lAK+MAdhw
Date:   Thu, 15 Jun 2023 15:44:33 +0000
Message-ID: <BYAPR18MB24238F63DCDC1A7DC3679F4ECC5BA@BYAPR18MB2423.namprd18.prod.outlook.com>
References: <20230615033400.2971-1-jiasheng@iscas.ac.cn>
In-Reply-To: <20230615033400.2971-1-jiasheng@iscas.ac.cn>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yePpEZr7l61EO7jUtTggfDu+udYIvfW/6k3MWI1sMd5EW8gnBG+4Ssb+2NCB?=
 =?us-ascii?Q?dX5h8Z6UVXSRkqSGKQfDLYG23CqFwIVl74kI8SF3ULuW7PRsQNYKyPgdW4aO?=
 =?us-ascii?Q?3eKRi8cpHBfj0bAnYUDGFduPkZSD0Rb32pE0VaLQV71QYL5tkN4EBFVgKGYB?=
 =?us-ascii?Q?BUkJnwvLQ5nO7hNT8NfplHOYfgP4d0J9QBO4DFgX6TAPdvxaNTVFhDfvnRt0?=
 =?us-ascii?Q?BYNBVpEV+vvjjTmeb7HoIYZO65ljQRUhsqBYQw8qL1HDa0nptAQ+46nuECj0?=
 =?us-ascii?Q?mqtnsG0wSJx9mNAwuUw0UL971LsS+9paA0yls5z6rng/B5CdOjOBqWXuNTjX?=
 =?us-ascii?Q?CcyRhUISoQ74B5El3jPeNbf8dAHDwWn5L5JWhIoMVKpMGS0tsXtz4r5svE1v?=
 =?us-ascii?Q?HAOsn9zfaIxFn+an1yhjav+06nuwiaXgqyev0TESSlgxhjn9cd7DZfKwKI6y?=
 =?us-ascii?Q?JffJ/3VTjvDGdq0SZVUTox2f3kUjYXzV6dWqcS9sax06sjg7DTI9+1uWJkKk?=
 =?us-ascii?Q?U7+WzaYG8AB9Bu1TxPLkqnZMC0WVxNd95QLI5Qtw6a/eKyWGTFm8LZ30XOgJ?=
 =?us-ascii?Q?M2ZB6Dk2RynNb+Gw+/Qu43G59kdguno1k4RWeiRbENFybOl5LFe5sHZOkrgh?=
 =?us-ascii?Q?wQBCX9p7PMTBuz2h+u9B4oqr3+Pce3szok2O9Og8jjciOblFkoGJZrLbyzLz?=
 =?us-ascii?Q?K3TG/oPmfdnw5SEr+54BKGVMA4gh2pMlnKwea/FLWaXYivG8j6uDZzM5uS3p?=
 =?us-ascii?Q?/5VnIEHdK7FZ727lIyzxcBANQFOJWQksHOgZkV8LOs0Ts9nqFmJaYjWTceKo?=
 =?us-ascii?Q?EKkMEEE5Qb3DPZJndv8iCCYlbpaZ+VeqGTrx2eOGNSUb00Lfze71v5oxtSNI?=
 =?us-ascii?Q?COMx04EdEkTNlDk+n3BflrccheSqHfpGticnmd78skoThHUBgvKc4Q+PFtFJ?=
 =?us-ascii?Q?MRwhh7meRuwaaZ5ds+fbDjX8AV2QzA+SndvLOJyaYltcXLmtNTC/fgSk93IG?=
 =?us-ascii?Q?L5KrVWk+m58Lu2siKyO9LIQIK3viYwOMi0q3roOlA/tHouJeL/6fiKF2UfsB?=
 =?us-ascii?Q?D752ws4x3//NAL4hD9byyi72SHpHTTIXINhcCmsvKQGFuVsixYxYHnDyJKtQ?=
 =?us-ascii?Q?/zVQvJJJKmds1QWVbUxxlTxRCcJ71/AUMfI6uY6L1IhpP4iDU76fK/8P08yw?=
 =?us-ascii?Q?JZApXzWqTb8ZMaf0cEyHf92/hHpokIBa4JYCbdSL2MbJI2e7l4OVL9x8lUJ7?=
 =?us-ascii?Q?QuzJb/ZqS6qkL6YE50jX5fEiLK1Hv6JTt3HcfqAZaJa2o6N6nCuzk+5Qx4LH?=
 =?us-ascii?Q?8pbaRgrCjnhdCQ6q4P82Lqjg/rw1q5uzS9p9IWBoIDKjQ5jRxRg6G+2Swrh1?=
 =?us-ascii?Q?FaX9nhVP89/A/ZhAzp+LPVuPLR6eGMPZaIccZcpyS/8nOzj5IoigTIB8nK7W?=
 =?us-ascii?Q?oHIKVmOukbrM/6vYO0e6/8P9iFotImxk9LPOBlSZEcghiYdhiEybV4PA6sP4?=
 =?us-ascii?Q?Db6MBdaimBgvMsAislxC4tk8typDbKTMkosi6td82JWCT8lmU+J4Ow8FmMLs?=
 =?us-ascii?Q?MznKSwl4CEPF8zMw7B8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR18MB2423.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a7b0cab6-2113-4d2c-cb86-08db6db76a7f
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2023 15:44:33.5800
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5qutoQZX3DbR7oUQVxASqT6oLuR2y1dNp8XJlmXx8UPMXh162GglOlp8pcfQMst8WeWCBLZzSz7tZI/Z4hMo1w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR18MB4265
X-Proofpoint-GUID: xexj5cxdyT4fs9Jic5aDng3A4lt-Xo_F
X-Proofpoint-ORIG-GUID: xexj5cxdyT4fs9Jic5aDng3A4lt-Xo_F
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-06-15_12,2023-06-15_01,2023-05-22_02
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> Sent: Wednesday, June 14, 2023 8:34 PM
> To: kuba@kernel.org
> Cc: Veerasenareddy Burru <vburru@marvell.com>; Abhijit Ayarekar
> <aayarekar@marvell.com>; davem@davemloft.net; edumazet@google.com;
> pabeni@redhat.com; Satananda Burla <sburla@marvell.com>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Jiasheng Jiang
> <jiasheng@iscas.ac.cn>
> Subject: [EXT] [PATCH v2] octeon_ep: Add missing check for ioremap
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> Add check for ioremap() and return the error if it fails in order to guar=
antee the
> success of ioremap().
>=20
> Fixes: 862cd659a6fb ("octeon_ep: Add driver framework and device
> initialization")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> Changelog:
>=20
> v1-> v2:
>=20
> 1. Rewrite the error handling.
> ---
>  drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
> b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
> index e1853da280f9..43eb6e871351 100644
> --- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
> +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
> @@ -981,6 +981,9 @@ int octep_device_setup(struct octep_device *oct)
>  		oct->mmio[i].hw_addr =3D
>  			ioremap(pci_resource_start(oct->pdev, i * 2),
>  				pci_resource_len(oct->pdev, i * 2));
> +		if (!oct->mmio[i].hw_addr)
> +			goto unmap_prev;
> +
>  		oct->mmio[i].mapped =3D 1;
>  	}
>=20
> @@ -1015,7 +1018,9 @@ int octep_device_setup(struct octep_device *oct)
>  	return 0;
>=20
>  unsupported_dev:
> -	for (i =3D 0; i < OCTEP_MMIO_REGIONS; i++)
> +	i =3D OCTEP_MMIO_REGIONS;
> +unmap_prev:
> +	while (i--)
>  		iounmap(oct->mmio[i].hw_addr);
>=20
>  	kfree(oct->conf);

Ack
changes look good. Thank you.

> --
> 2.25.1