Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c9f885df-4650-248c-3708-9250a0b530dc@amd.com>
Date:   Thu, 15 Jun 2023 11:34:21 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Cc:     yazen.ghannam@amd.com, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org, tony.luck@intel.com, x86@kernel.org
Subject: Re: [PATCH] x86/mce: Schedule mce_setup() on correct CPU for CPER
 decoding
To:     Borislav Petkov <bp@alien8.de>
References: <20230417162006.3292715-1-yazen.ghannam@amd.com>
 <20230615152031.GCZIssPyJjGcikn9iA@fat_crate.local>
Content-Language: en-US
From:   Yazen Ghannam <yazen.ghannam@amd.com>
In-Reply-To: <20230615152031.GCZIssPyJjGcikn9iA@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WW9nSDBRMTd4aXFaOWcxQVBBeXpJRWN2cmJwUjVGNXEzeldLRHFzRTEzNXg5?=
 =?utf-8?B?Qlk4b09obHdEQ2ppZUI1SSt1eWhLQk43QThDdm01UVY4TnpjUGlrajllcDkv?=
 =?utf-8?B?OFhySmFCYjMzcCtxQzZuRzRnNGJ2YVBJeWo0cGgrdVdQYkFTS2cxS3hodHoz?=
 =?utf-8?B?RmVVN0pZTGswR21nVzZTMUFVSlhTMkEzNmZLSXo2SGd6S2lrQ2ZGSVJCRXk2?=
 =?utf-8?B?VUVQUDJCSGYvZlBHK2l3QjVaYVBlazBocnRUY0NweHFzWEwxRHpwTWE4SG9E?=
 =?utf-8?B?ek01QmdlVUJaUlNUeHRQc3NDNlZUZW1HN0M4MUN1WWVhcjdhejdLUnB6dk9M?=
 =?utf-8?B?Q3ZyakxhbGp6V1hlZ1lxaHVnejlPYytPWG9ibHVJUk0vRlRoNk14ZFh0Qy9J?=
 =?utf-8?B?cWxuc0ZIeUdGa3lkcGJtUEtDckZCU2FLQ1h5YVRnUVlpazJqUDVmdFN0cnlG?=
 =?utf-8?B?dVd4RERmbGVmbWRHYlp3ckUrUEtIdDBHUmd6OVJHZTVadFVDcjZCbkErRklR?=
 =?utf-8?B?bllpdzUzSXNIQ1E4azFaRGVqWWJyajJaMm56USt5UE5sSHRwTUpVNk0rTklO?=
 =?utf-8?B?czlleFN2emtUakRwNUVPU0FvOFhUT0N0NnVMR0YzQnpULzJzdWdXcEJjOWpx?=
 =?utf-8?B?Rkd4VExLa3NibWpubWF2MFg3WGNYalVUbmx1VzRNdS9vbHNlREhSeU1uVUlz?=
 =?utf-8?B?dysxTUxzNlpKUlBEcHVKZlNBcHBnalVSQjZEU0RSRS81S21nTTdaV2krMGkr?=
 =?utf-8?B?QnpRdFZEZ1BhRmZ0V3V5OGpzb0J5bGprY2tJaVcxNVdGOG1IOXYxYW1rQXo3?=
 =?utf-8?B?R0xreHk3K1NsTDd2Slo1T0tkWis0MXN6VDBnTFpleXNNMWlyL2c5ZFFYdU1P?=
 =?utf-8?B?UEUrVzFMcGcyQUpYRFpDTGpPaWlMUCtmeHo2M2hmV093UmRZSEdMelg1T3Fv?=
 =?utf-8?B?bjUxU2FjQjcrS3JWTmVvMFhwWjJ4SkF3bFk3WE54MWU1SVRFN0pEUDYxR0Rn?=
 =?utf-8?B?c2lqQWZ0dWg5T1hTWmhLY1JLYzdtd01ZM0NvMklDeDRmbGYzdE9KMGxPRjJC?=
 =?utf-8?B?UVI2ZHZGcUVqSVVYdDNYcmRDUFNLdUNPQ3VWck1xa2w2d0d5Q1ppSExJU1hX?=
 =?utf-8?B?WVF1SkUvVHR5cGtZT2NJSlpIeGNsNkRvYklIVGgyalZFZmRJa2FBT0JNblFG?=
 =?utf-8?B?aE9YMGNTbUkvOVdFUHlMM3gzYkF1cjBqNmhwc0o5K0lhTVFwUHgzS2dFTUlk?=
 =?utf-8?B?akp4OHJrU0dCdXNGKzVCNFplYTJJazJrdzJobmZ4OWZsQ2FOT2V5cytKbTk0?=
 =?utf-8?B?dUVFVEhIVmN2d20xYmpnUit1TlJXU2xMUHFzQnc2dHIxNHdaT2ovMVlIMzln?=
 =?utf-8?B?ZCt6Y0hDeVQ5TllJZHh4VGJYcEJGMVBYTGdQeHdsbG5JbVM1cm1DdHY4YnRz?=
 =?utf-8?B?a0JydDJpanp1WGdoUjdKSFVJRzZ3T1dpK3o4bzVDM0tXOHpROWpnSGtvOHJa?=
 =?utf-8?B?L20xMW9MZ0wveW9lbU1Vc0ZTaldJYjZjTHc5RUNlMUk1cXhLSDNscUs5Q2hO?=
 =?utf-8?B?WEp2UnpuSVgwN0Nhd01IcDZOeVE2L1lqMmFmWHljLy9xais1R3lYV2tIZVFB?=
 =?utf-8?B?TndNcUZseGRYdDk0WDk5Tkh2TjU2Y1pnNzhjMmZkc2t6RmM4Y0gzTnV1TVg3?=
 =?utf-8?B?VFJJSmg5OUpiaHJmcWdEREl2RVRBZ2VVYjZ4UE55SXRTc0ZPR2xsTFVibVZY?=
 =?utf-8?B?THhjTFFIWllrNVBXaHR1dFQ2NXdvTThQMFhJaEFTaklGeFp0bzVnVmJ3TlJO?=
 =?utf-8?B?TDd4a3krdEo1YzVsSWVFUXFmbXlJRlQ1aTdTTmZSbkxYREZXSVM0U1NCc2lV?=
 =?utf-8?B?TUF5cUhsVFFkVitvellsQjB6bkRROXAvdms1dGFzZ2QycVRPLzRVYXI5LzZQ?=
 =?utf-8?B?ZmxVaVptV1p6Vm5PV1hqRFFhc2pXOXFjeXZLRlMxN3lpTGlBMGJZekZyZWw1?=
 =?utf-8?B?OHhuYTBRblNHTjA2NC8xOFZ6MGNjU1JEeVVDbWlES0xvNVdOei9aRUV4UXNE?=
 =?utf-8?B?K281bVk2SFhoM2JhV00xNHVEVGZYeVFWK1AxKzJKOUl3Y28xZWFKaVg4VWRh?=
 =?utf-8?Q?sxuWSrb4rVTQwjjDYak5mvKwR?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e106e636-3e88-4be7-174c-08db6db5ff64
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3109.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 15:34:24.6148
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hj9iWeS6wHOxRJCDZl49m3jLMO7kFHpWKOFjQ4+dzP3EzV4CJLaYfERkhOcMpfYdXeDVcv9m2/257EA4X9PAbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6042
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/15/2023 11:20 AM, Borislav Petkov wrote:
> On Mon, Apr 17, 2023 at 04:20:06PM +0000, Yazen Ghannam wrote:
>> @@ -97,20 +102,13 @@ int apei_smca_report_x86_error(struct cper_ia_proc_ctx *ctx_info, u64 lapic_id)
>>   	if (ctx_info->reg_arr_size < 48)
>>   		return -EINVAL;
>>   
>> -	mce_setup(&m);
>> -
>> -	m.extcpu = -1;
>> -	m.socketid = -1;
>> -
>> -	for_each_possible_cpu(cpu) {
>> -		if (cpu_data(cpu).initial_apicid == lapic_id) {
>> -			m.extcpu = cpu;
>> -			m.socketid = cpu_data(m.extcpu).phys_proc_id;
>> +	for_each_possible_cpu(cpu)
>> +		if (cpu_data(cpu).initial_apicid == lapic_id)
>>   			break;
>> -		}
>> -	}
>>   
>> -	m.apicid = lapic_id;
>> +	if (smp_call_function_single(cpu, __mce_setup, &m, 1))
> 
> I can see the following call-chain from NMI context which is a no-no:
> 
> ghes_notify_nmi
> |-> ghes_in_nmi_spool_from_list
>      |-> ghes_in_nmi_queue_one_entry
>          |-> __ghes_panic
> 	    |-> __ghes_print_estatus
> 	        |-> cper_estatus_print
> 		    |-> cper_estatus_print_section
> 		        |-> cper_print_proc_ia
> 			    |-> arch_apei_report_x86_error
> 			        |-> apei_smca_report_x86_error
> 				    |-> smp_call_function_single
> 
> 

Right, but in practice SMCA errors are not reported through GHES at 
runtime. They will only come in through BERT at boot time. There aren't 
any plans to change this, so the NMI issue won't be encountered.

I can include this info in the commit message and/or code comments. Is 
this okay?

We can solve the NMI issue if it ever comes up in the future. Unless 
there's an obvious change to avoid this now. Any suggestions?

Thanks,
Yazen