Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1518523rwd; Thu, 15 Jun 2023 11:34:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7kMWdvOYUXT6JVtQGPpfCM8Bf0kVW9PuOzPMKWR3dEIvhf2i4zahB29aEA0hJ55arvJ9Z8 X-Received: by 2002:a05:6359:69d:b0:129:c2c2:4447 with SMTP id ei29-20020a056359069d00b00129c2c24447mr12582332rwb.4.1686854065407; Thu, 15 Jun 2023 11:34:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686854065; cv=none; d=google.com; s=arc-20160816; b=iR178jU5wgPPeDJDVJyCKcGp/zxsWfQG787P0iFY/fnrZcsfLngfbpFfnDgUIxPJB8 Z79Nc1IiBZTp6IFGSTytqOWXt3tmYgHBDjzX/MAqmz31VZXSqoTBPlUk5W/OINi9D0Ce NvTBt87C39HbV2pIEApDhWtNjDO9cqWlcU2jPPhE+/edbdaOtQAAQy5BoQX6pPcqKRKI p/VOP4V7yUq7K1Wz4/9axjPCc2SBx32aDbDPFmSTA6nXwxtLK07Kxv/DjMH1hFSWicrW ckFrgwHyiHpv0uzIUHOV2cDtyVMfJHCv27AZ7rAa9OC6fIfAuFOsLa5sulfhT+o3AUMX ku5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=oI5Ov5oLGA7KuyFwkEzDeO1r/Z1IJ+FGWr3qf0+vA/E=; b=Z0juhi7lFUKecdtMFlc+viiCPrrKRo1pYDRUYMXlJjqRLiTbK7z6cEXPCoL6giGAlR PzxzEyesd3gB615TjOUqsJMN97Gmn73k5yXRCri34gKl84MJu/6ZxLdqRZAPLhhgKgbz UiPk17h4nH6wlEqbnpdXBRuwd4BpFraeAdB1MzdowQovHwXaXp+80sryIXA5Ks71Kv77 B5c/hvVf60w0cc2L3/sgCZH5QJNl+Ertr8HuIOn0BhupSysq27BqxJgsYO0eaL97ODH/ SgeJtxOBjVoDSUp5o9FAHATUKwjCdNmCfe+NRuDWja/SLwDnGpLwL3T3aL9JOf2IYath zIfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iTmnYVDX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id az9-20020a056a02004900b00543a6cf2b55si9817268pgb.527.2023.06.15.11.34.13; Thu, 15 Jun 2023 11:34:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iTmnYVDX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237672AbjFOScB (ORCPT + 99 others); Thu, 15 Jun 2023 14:32:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233801AbjFOSbt (ORCPT ); Thu, 15 Jun 2023 14:31:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E48653C06 for ; Thu, 15 Jun 2023 11:30:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 12E36622FF for ; Thu, 15 Jun 2023 18:30:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6CF9C433C8; Thu, 15 Jun 2023 18:30:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686853820; bh=IWpeb4Kgm1UamkNtsT5+DO7vNDUGgUuD0Dyst6XKCz4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iTmnYVDX+9wbjvHsbaVRPyrv7MPXOPRDHzBhk9XOtcxMnlW9qUfRnHR6k5Wt3ToGj i0n8EumMCCHjTpq7p2c0CT33nIZnNnjJvinpRpaZEGtYA2OWoE1iFypxj+ksGr2jnh YsIvrP6/vk9xb2bPZ+XHmNmZvDCpWdpPBL8vHgNtZ5TUOAYja2UfEE8VsTnx6Dyvpy oeuxHmKCgDLYCAPP3PYqtrtlUO8hEexjRAu6Z3FJIH345Jw7DhXeuyl/i0yfnINOY7 EgDX8QB9/b5KlWReXOCgYvYIBohwpl4MWc8evhDJAhAbZQcDCzUZwYctnAdQaRWn/D NOzgh+NknLiJw== Date: Thu, 15 Jun 2023 12:30:17 -0600 From: Keith Busch To: Breno Leitao Cc: Jens Axboe , Christoph Hellwig , Sagi Grimberg , leit@fb.com, "open list:NVM EXPRESS DRIVER" , open list Subject: Re: [PATCH v2] nvme: Print capabilities changes just once Message-ID: References: <20230615094903.1341683-1-leitao@debian.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230615094903.1341683-1-leitao@debian.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 15, 2023 at 02:49:03AM -0700, Breno Leitao wrote: > This current dev_info() could be very verbose and being printed very > frequently depending on some userspace application sending some specific > commands. > > Just print this message once and skip it until the controller resets. > Use a controller flag (NVME_CTRL_DIRTY_CAPABILITY) to track if the > capability needs a reset. Looks good. Reviewed-by: Keith Busch