Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 15 Jun 2023 21:55:05 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Konrad Dybcio <konradybcio@kernel.org>
Cc:     lkml <linux-kernel@vger.kernel.org>,
        Bjorn Andersson <andersson@kernel.org>
Subject: Re: [PATCH] regmap: Check for register readability before checking
 cache during read
Message-ID: <274a7a7c-ca6c-44fe-8f7a-e19aaf86a86a@sirena.org.uk>
References: <20230613-b4-regmap-check-readability-before-cache-v1-1-b144c0b01ed9@kernel.org>
 <ea63420a-a08d-3610-b01f-61dabe56d2df@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="pWr7QM6a1Q/bnGPH"
Content-Disposition: inline
In-Reply-To: <ea63420a-a08d-3610-b01f-61dabe56d2df@kernel.org>
Precedence: bulk


--pWr7QM6a1Q/bnGPH
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jun 15, 2023 at 10:45:53PM +0200, Konrad Dybcio wrote:
> On 13.06.2023 22:07, Mark Brown wrote:
> > Ensure that we don't return a spurious cache hit for unreadable registers
> > (eg, with the flat cache which doesn't understand sparseness) by checking
> > for readability before we do a cache lookup.

> this patch breaks using regmap_field_force_write() on fields that are
> parts of registers marked as write-only (e.g. by regmap_access_table.no_ranges)

> Is that intended?

> What's the recommended fix?

Ugh, let's just drop it - it's just an optimisation.

--pWr7QM6a1Q/bnGPH
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSLeqgACgkQJNaLcl1U
h9APfgf+NgEsBtwozjnOrmA9FCn/MC2Rx1p/fIKyit0rpv0+2i25lZqwWHoRZ3uu
nErEQ2Fif8fWFNpSVSzyBuBrI2Q4se+C+Huoi/G51jEo1jlgNB1WyA68aewFWguD
QHXRi1Vt5COUYZMDhAZC4/4V9Lxx3FVe8317YIOwGDiDSacuyh+1+9SpBvimX5rj
apGeYx5rTM74nKIZQMNncpu2oIVZ86HpjDdWpUJy9tDu4oiHPqdRGfv0/FBwm3gV
5Vui/RlF0HApanO13Fe34jqIlgByb2S8J+ZRyKDufmM8BN1JGPjJwmPVr1wjyjzI
hJ1u/bPENJQsOi7vlpOwIvHIE3vqoQ==
=dxCs
-----END PGP SIGNATURE-----

--pWr7QM6a1Q/bnGPH--