Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1712763rwd; Thu, 15 Jun 2023 14:43:28 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Fi7HlFBrCEAs/OA0WJwJ99W9J19R0Cf6dIINaV6NtHHJmJQXh0X/MtQ33yecI3Pt53W0F X-Received: by 2002:a05:6358:ecf:b0:12f:1018:e3df with SMTP id 15-20020a0563580ecf00b0012f1018e3dfmr9921rwh.6.1686865408252; Thu, 15 Jun 2023 14:43:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686865408; cv=none; d=google.com; s=arc-20160816; b=l/4YfxPh9WAzPp+Rt2VHBbiCKNepgHEx4LGQ/3TpEmbtVOUtJF9xj0ug9UETVHq8Kx BjUjvk3fd5hzCfERvQsHOvUMWnjcpwZUT/QTI6sf9qhehy0qcs2tDNPAzXA+SFPNYELX 9WkL+ZjKdUFWaUWgRytB/vULFX0k6LdafVExm+ZrnQlz9aorjwabvpIaJjJnLfRUtX2y /MxrEg8T62InCBoMHS4cXA7e8m3hj/MORCIa2DtPNL7d0+NGjFvmyTjwj92nfdvFRhAB LCA7OBpEC46W9kdaxTEnOH//hKqy5iZIpQEVVMFkCsUpBVIzCpyrwcWlFPgl1Ipkq3Vu 8UVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:message-id:in-reply-to :subject:cc:to:from:date:dkim-signature; bh=S2y2ag2VSA5iJWjnLMJgW21sD26IXOkwRb84bIEjNFc=; b=CtCyrrjA1zfypuW7pdxARw439XzrGSwce3ShEaTadKt2NPxJaUCtRJ0J+jv5b4YCbu aGmOLPjD3saqG4zf1yMF486UCvvV/S0ML4rgzxIVJ24hMmvh5Dg0CwsmXA674ttZnIeW 9kNgqKCoeOcXv86WK7/VXxeJ376f8Z7DK3OgtJQE0P1AUY54WxHScDHvNKzI4HV4/W4s 0PSfpgipH5b+HXnwkQmaKBY4rLHMccCJhC26Xvejw3Ay76pF2W1sB6ig0dnah+B1RKih om56/cLYVZmezw0WvVD9rdb39ikJziYnK4EuPdOy/OBCDSXw0QEaAQ8pYZtA+r0gZ3Pz 2R+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=xQ0UEfbe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id az9-20020a056a02004900b00543ae670bbesi10056307pgb.794.2023.06.15.14.43.13; Thu, 15 Jun 2023 14:43:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=xQ0UEfbe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229649AbjFOVW0 (ORCPT + 99 others); Thu, 15 Jun 2023 17:22:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235249AbjFOVWW (ORCPT ); Thu, 15 Jun 2023 17:22:22 -0400 Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7976D2962 for ; Thu, 15 Jun 2023 14:22:20 -0700 (PDT) Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-5703cb4bcb4so1196037b3.3 for ; Thu, 15 Jun 2023 14:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1686864139; x=1689456139; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=S2y2ag2VSA5iJWjnLMJgW21sD26IXOkwRb84bIEjNFc=; b=xQ0UEfbeHsvyF9P9GSzV8sPaDnCduWem82QRocOPVTimyNaz+TtzXunPSdeRzXvvAi vai/I3V4xnGwkuPBK2C8BxgXmG/grI3PNJPpvIXErHwA9uzmeBRdld+oVJisQfogsxl0 vGLKSwM0YFacwx/AmX5Id6XW9gRfBLJoOHHDKed5GhoMi63Kk25c1kBjAvC4IVlUHe3e oelGGGI8RCOSrTPLR5K32xFZslyRFLZPbM5b3aFNmrO++aNzcuug8bpdMx1IF1HOO2ol NHDhCqI2eK44IOXmk4glSuyplwnvkIK/n7XkQCIImv5fgRh6qF4f64HAb8zfCbRE0z7D 2CQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686864139; x=1689456139; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S2y2ag2VSA5iJWjnLMJgW21sD26IXOkwRb84bIEjNFc=; b=kqQylgoja4ynKyyMz/Evsu9IlawHt3wX03Zdxmkwoye1jWt/pEUGXJOO4snegcHvp1 +FX21tjTr6WPSOhOiJ1SJ6TBUkNBeZGXtuBrP3EoC3zFiB+Vk5+A0oWqhRUhPRT7QqWY 2sKUPc99lBxdVLA4kgBeYh9RXS/Qr9utApnhrI5lcoxaTEODHS5lMp2Imq/4LKBPZfV5 D21ESZXd8l33m3MPi1llSYSkfa9G0zqmp+R4xfiAKNf0tqBgT97+FeABDihLYHi5s5DU m7Jvsj5DhfnMWmozeW7H2wmNzgzKtIj6/3j4D/lvnrIOspqoofm2gRaNzHCcIqaO2T1j uQTw== X-Gm-Message-State: AC+VfDw7zLxxQqHnH6ydNPWln4W/juXoL94lL5EBQ7SePxsRUHteMCUD 722mxbQg0wo2dFjK6m1xUA9WYg== X-Received: by 2002:a81:83d3:0:b0:56c:ea2c:5cb2 with SMTP id t202-20020a8183d3000000b0056cea2c5cb2mr5787878ywf.49.1686864139515; Thu, 15 Jun 2023 14:22:19 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id s189-20020a0de9c6000000b0054f80928ea4sm4626438ywe.140.2023.06.15.14.22.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jun 2023 14:22:19 -0700 (PDT) Date: Thu, 15 Jun 2023 14:22:15 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Nathan Chancellor cc: Hugh Dickins , Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Peter Zijlstra , Russell King , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Greg Ungerer , Michal Simek , Thomas Bogendoerfer , Helge Deller , John David Anglin , "Aneesh Kumar K.V" , Michael Ellerman , Alexandre Ghiti , Palmer Dabbelt , Heiko Carstens , Christian Borntraeger , Claudio Imbrenda , Alexander Gordeev , John Paul Adrian Glaubitz , "David S. Miller" , Chris Zankel , Max Filippov , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 07/23] mips: update_mmu_cache() can replace __update_tlb() In-Reply-To: <20230615155059.GB3665766@dev-arch.thelio-3990X> Message-ID: <76b41825-30fa-b9e8-d043-2affcba24317@google.com> References: <178970b0-1539-8aac-76fd-972c6c46ec17@google.com> <20230614231758.GA1503611@dev-arch.thelio-3990X> <344a4da-3890-45fd-607e-b5f85ca6ad48@google.com> <20230615155059.GB3665766@dev-arch.thelio-3990X> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Jun 2023, Nathan Chancellor wrote: > On Wed, Jun 14, 2023 at 10:43:30PM -0700, Hugh Dickins wrote: > > > > I do hope that you find the first fixes the breakage; but if not, then > > I hate to be the bearer of bad news but the first patch did not fix the > breakage, I see the same issue. Boo! > > > I even more fervently hope that the second will, despite my hating it. > > Touch wood for the first, fingers crossed for the second, thanks, > > Thankfully, the second one does. Thanks for the quick and thoughtful > responses! Hurrah! Thanks a lot, Nathan. I'll set aside my disappointment and curiosity, clearly I'm not going to have much of a future as a MIPS programmer. I must take a break, then rush Andrew the second patch, well, not exactly that second patch, since most of that is revert: I'll just send the few lines of replacement patch (with a new Subject line, as update_mmu_cache() goes back to being separate from __update_tlb()). Unless you object, I'll include a Tested-by: you. I realize that your testing is limited to seeing it running; but that's true of most of the testing at this stage - it gets to be more interesting when the patch that adds the rcu_read_lock() and rcu_read_unlock() is added on top later. Thanks again, Hugh