Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d3a85517-18c1-5793-133e-196bc2f546d5@intel.com>
Date:   Thu, 15 Jun 2023 15:04:03 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.11.2
Subject: Re: [PATCH v4 03/24] x86/resctrl: Create helper for RMID allocation
 and mondata dir creation
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>
References: <20230525180209.19497-1-james.morse@arm.com>
 <20230525180209.19497-4-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230525180209.19497-4-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGVlYU84MVNrT243MGhZWG1UbzBPZERPOTh3SWt1SlJiMWdZbWtHd01aZzFK?=
 =?utf-8?B?K2lPakhoNlFIRy9sdExTa3BabzhKVENCMzlwdnphYnRhUjUvUzJJUS9nQUFZ?=
 =?utf-8?B?WlhuWWNVc0JCK2hFOFYvKzR6VHNScnFiZC9aMnFHMDJtK2o2ZXRoM3RGM0V6?=
 =?utf-8?B?dm43Z1hUaE1FS1dsTll5T2hhdXorK25uM3V3YnNEd09pYzcwS013V0VyVEhF?=
 =?utf-8?B?M3lTaDhqQnFnNjRlQXpnQjkwL3FNV09OVDRnSTdUYSs5RE44UlNyVmtxbjN2?=
 =?utf-8?B?YTNDZnVocUIrMkxkb3V1NGtPeVRaeXZXaWJFOWFtTEZzdi9HU2J1Y2lOckNi?=
 =?utf-8?B?d3FmeDRaWHdhbTR1WkpGVXZ3VlBJSCtwd2tLUnVOUXIwRXhTMUgwTFMvUExw?=
 =?utf-8?B?WUd6Um5aOVhCRUthKzdQSVgybnh3Yk1kUVd2cEVabXBZNkRGckt6dkdNTDNt?=
 =?utf-8?B?NzdobzJqZ1R3UG9LQ2lIbFlJU0dqNG16N2YxeFRmZTl4L1g1ZU1TSnkyem5r?=
 =?utf-8?B?bjVOT1pjc3BkVXJrRG9Nb25lUTF2bmplRjErbDhocDZPbEhtMUg0UlJWVWZY?=
 =?utf-8?B?UFZXcGd4VUNKUEdDTS9uQ01EMitoeXJVRmZiUVJxVFZwanc2bVErWmFNc1Uy?=
 =?utf-8?B?d3Q1NG5NNExOaUNKZWQzY0xUTlA4SkpyNDRUbHkwZ01USEZMMW9xRCt3UlF6?=
 =?utf-8?B?dEhETE1aTlN4QW5yd2pvSW9TV1A2YXovS05WNUlhUjRzeGhzQU1tRGs3aVg4?=
 =?utf-8?B?NEdPZk5kdGpsSGVKanA2WUdGaTVWd1RFbXpYeEJjTWFBQjJrY0pDOWRnN21D?=
 =?utf-8?B?dHI0aElQelF3cDU3T3psUnBiSG9BOE8wQ1BXWnlzejJESUVQOWdzcTZTVW5D?=
 =?utf-8?B?RVgvYnpxQlpISk05bDZ5YXBEQU1yTkZIZG9XT0I2WWcrMExhZEpack84MFVO?=
 =?utf-8?B?c2pXV1NKR1ZPRGg5a1hueDUxU2RueWoyckxCRjIwYmNCUDZHTHk5eW1keUNs?=
 =?utf-8?B?RnBaZzZuRGo3cGlqbnJTUFZLTzZwUHZSdi9UUC9FNC9CeU40dUpCTm9uZ0lu?=
 =?utf-8?B?V2pKSFNvQ1VlQ28yWlF3SGlVSVc1WndiMnk1WGxBTmpSeHNWY3E3OS9DNUls?=
 =?utf-8?B?WVlvb2phajRScm00cFhIWXVGTUVKNkNmb2I0dGw3Z2M5Um5ZWVB0QnJnR3dr?=
 =?utf-8?B?QXBES0hoZWErWXNDU3lydkY1dDVlS1pJZEZ0alZOeTlZTVFQbzVpSFg3ZWVK?=
 =?utf-8?B?ekRSdmRlUnlZdjBKVDN5MnZnKzNjeUI2aC8ydWFXNlFUR3hGVGJ5WllDUkph?=
 =?utf-8?B?eGh1eWE5K0tFd0p1ekFZaStSUktXcVhEVEZ2UXpZdFVYcTJNK05IaUdyUEZn?=
 =?utf-8?B?aXF2ODZ1NWZYQlVIbmtiODZZaE52Z0tQcGVKWnlKbkNDYW1mKzRRSkdMYUtP?=
 =?utf-8?B?OW5NMzl2VXV0a1RmdU5kWnN3SHQzRk90N25jTDZyTUpDY2JGd3VGZjRleW9r?=
 =?utf-8?B?VGdIMG5NVXM4dHhKLzlQZmZTV3c2aWRjZVF6REhFWXZMQ2lDeXdBZGQ5Vllh?=
 =?utf-8?B?YWE3WWF6aWdWUXdvc1VLdFdrenFCRUUxRmNFaXRIbHN1L1ZFOEJUR3dadlJ1?=
 =?utf-8?B?YnphU0R5UmZPeTgzYkIzNW9PdUdXV1lGQ2xTSlBNZ2N5UGVkaDliRTdYWHgv?=
 =?utf-8?B?OFd6RjRQdCt3RStWNlVrUjZPWEZiQlhDT2JVcHRwa2JaeWttRTR6WW9YYlpq?=
 =?utf-8?B?NVFaU1pmb2ZBbVlkVjFKV1NjZUlLMzBlTmtXcGF5Zk5vVllRYjFOT2Zld2l4?=
 =?utf-8?B?Mm1YN2VuZERyRSs0TDhadE95L2tVdWNuQm5Ua3ltRWd1TUxZNnd1WVZ0czk5?=
 =?utf-8?B?cmwveUxFYVFFV1RoSUhyR3hvSG9qdHhYM3RId3dPNUVnRnA1ck5UdXRCcmRI?=
 =?utf-8?B?dzhOMm45d1NQTHNJNEtCU2pZeWhPNGlEOWY2aXRoSEdSc1J0N24vWDA0S0w1?=
 =?utf-8?B?aG5xNGdpU0RRai9jV0pkZG9hcVpVbXZHa3JLZVltazVJa2JxMXNPL0NsTE9q?=
 =?utf-8?B?ZW9RY2d1b0RnSjk5cjZFWmprNEFFY2hzYWNuUGxnVXdPNVRHK0NjMm1NeXlN?=
 =?utf-8?B?bkVIY2k0U1J5WWtuV2l6S1hXdlYzdEVsTVJTWHl2VEFmV1U2ckFWVXZqL3Zo?=
 =?utf-8?B?dFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d90f8ff2-91dc-4855-5343-08db6dec6f60
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 22:04:05.3312
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l7qWqsed/mZuFzA6JrkvRnalwrzhNBPkupw8mR+SdFpnRAvqHEXtbKkhD0Ub5WM1jV+iXZhZxL5GnCWX0OH3oLEJgMTcCBPGQdUa+5V7duM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7511
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi James,

On 5/25/2023 11:01 AM, James Morse wrote:
> When monitorrring is support, each monitor and control group is allocated

"When monitorrring is support" -> "When monitoring is supported"?

> an RMID. For control groups, rdtgroup_mkdir_ctrl_mon() later goes on to
> allocate the CLOSID.
> 
> MPAM's equivalent of RMID are not an independent number, so can't be
> allocated until the CLOSID is known. An RMID allocation for one CLOSID
> may fail, whereas another may succeed depending on how many monitor
> groups a control group has.
> 
> The RMID allocation needs to move to be after the CLOSID has been
> allocated.
> 
> To make a subsequent change that does this easier to read, move the RMID
> allocation and mondata dir creation to a helper.

(nitpick) Could you please swap the two parts of the sentence to make the
changelog easier to parse? "Move the RMID allocation and mondata dir
creation to a helper to make the subsequent change that does this
easier to read."

> 
> Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Signed-off-by: James Morse <james.morse@arm.com>

Reinette