Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <caa21966-967c-77c0-c2ca-8747677e186a@intel.com>
Date:   Thu, 15 Jun 2023 15:08:07 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.11.2
Subject: Re: [PATCH v4 06/24] x86/resctrl: Track the number of dirty RMID a
 CLOSID has
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>
References: <20230525180209.19497-1-james.morse@arm.com>
 <20230525180209.19497-7-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230525180209.19497-7-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NW1NUHBPekFVZDh5c1NjRW9LdUJJK0RSMWNWSitvOEV6ajd1RzI4bUJCcWIy?=
 =?utf-8?B?Um8wcm9CMnU4TTA4SytvenFWempTdzRucytYa3lXK09iREh2VTdZQlhMVE8y?=
 =?utf-8?B?NUFWdDVtdW1EaXdDUEt1K0xudFRNdTd6TFBRMmF5alBZdDlmaW52UktRQ1NJ?=
 =?utf-8?B?N25pa1NPbVcvR3hQSVhRRlNNL3ZHOWs0SU51V0xRK2pqZmVaVEZucU5MbmpN?=
 =?utf-8?B?ZmdnbmRuNGpJcTRxYUJvY1BqUVNjT0gzdXFNZ0xWZmQvQjlUa2d4Q0g0a0NM?=
 =?utf-8?B?Y0pkRHI3eGpNaVZCSGdYUVBsTzVEdUV3WCt4bzJrYzRrQ1B0NncrWnFNcEho?=
 =?utf-8?B?UVg5ZDB6TmJVQU1GMXU5Y1NHcHpsbEgvdE4wbG1vSzhYNmQ1Rk43c2hzZ003?=
 =?utf-8?B?R2cvWmZqVmUyVG1DNkxiUEhDOTRqVC9WM3pzSFlXQUtaWjZGMWR5U1V5TGV3?=
 =?utf-8?B?UTBEQ3ZsY3M2WnllOHJrbVNYUlp0TEhLS3FNNjIwQkhrQWo4N1dBMjBQUklh?=
 =?utf-8?B?T3BUQ3hFeFVabWx3aHVVNW1CWWpVQkRPbmV5VUNvOVpUZlVZcmR2aFpaVFpL?=
 =?utf-8?B?MFRoeFpWSkNsNVY1Nzc3SGMxUDVHWDJBb2VmZFhLN2orYW5xOVZFUitEY25s?=
 =?utf-8?B?SFJULzlpc2tTNHVVQlRqdDFvQm9tM2l0Sk50Sm9XdzNlYVNnRVJGdnBUUG1J?=
 =?utf-8?B?WjBVSkR5QWlhYUdVK08rWGYyYUF5U1NXK0lGcTMyQ1lyajZwT1RuRm1CbWY3?=
 =?utf-8?B?enAzcHJSbTlBd3B6MndWM1pRT3BrSG15TFlTTnVxSUlhSmRKTHlkemNDT2VB?=
 =?utf-8?B?RzNna2d4a28zV3Y1aW4yZVQrUmxPUU1keFNDK0xqU2hKR3MweHVDdG9FT0py?=
 =?utf-8?B?U0laSmQ4bU9tWnJ0YVRTSGhOMEZTekppYjgxR3Uwa3JCSmM4QlYzTmFrcEtv?=
 =?utf-8?B?YkE0cmlTWWtEd1FrdGlwTFNtUDhsaVBXNWowbWt0Um52d1hzc1VTVlIzS0Vw?=
 =?utf-8?B?S2NLbU9ZWGdETWhHbTBlZVdtUjlnZktYNEFTTnd1b2thMDJjSGh4ZFN0NS9F?=
 =?utf-8?B?S2JBWjMzTWxIMWhqYys4ZmlBUmFpL09BZGdkdVpVLytKaXdNOXhUc2lLMGxC?=
 =?utf-8?B?VHh3RVBaQkxPRVZLdmwvK0k3d0JWcUs3cDVFVTlaWmtrenJ0WEdJMTRZWnJ6?=
 =?utf-8?B?ZlNxY2pTUXdiNCtxZ0FCYXZicnU1NVB0R2NwOHM4R1g5WGJkaFM3dEkzeXEz?=
 =?utf-8?B?dWwvaHYrRVFnVjhNNWllMXhBcnJPWUM2MFNkNSs4ZTFuWTdMdi8wQXVXeG13?=
 =?utf-8?B?TkRvYWxPUE1nK2dxWDJTSjRydGh5RHdOTks2dWR6OGF0UUI0STdPbjJyeUI5?=
 =?utf-8?B?dnZ1ZE9ZMDdTYXRqSU9zcisvQmt6cmNqcnMvOHMrZjhUZitFbTlONGdQU2l1?=
 =?utf-8?B?bXlsYkk1RGFpVTZpN0txaWljeTlCdDR0MmZSTzJpMnRxd0YrWXh0bzhZSW1M?=
 =?utf-8?B?T1JuRDJXNkFWV0xidTh6WGdrb0NIRG5LR3lzN0E1NXRvWlp5eTFVSjFpOVdM?=
 =?utf-8?B?cGp0QmpORFppN1d2czRyVUJHVWhmKzZIMjhxUFluK1diWmh6c0JLdmVkVDd1?=
 =?utf-8?B?Rys5anpGWUdsZDZ3blRsc0ptY2VndkNOUmdYVXMrWTBKNDBnMmhRME0wRFV5?=
 =?utf-8?B?TE1yTW4zMEUvakNMekVkQU5ycVVMU1NwU2Zqd0ErSkZ2eXUrQ0hBRVBvMm5V?=
 =?utf-8?B?WFBUUUY5ZzNHa3BVQTM0bnJlZWZCU2FCcDcycGdYY25rSXBiS1dzcHA4RjVB?=
 =?utf-8?B?dFp4Tkg0YWZrbVNkbzFpaEZCMzJ4UWJRUHZVM0ppSzIxUlpDVjljZ2toNDk4?=
 =?utf-8?B?U1JQL255RGFzV2M4MjFxKzlYVzIrZ3A4TUJPd1FvUS83MzVDN0lqVXNpNjBl?=
 =?utf-8?B?cU5yZDUwTEp0c1hpeWl6ZHowanl5RnY5U1BkdW5GcE44V1lCOHBpYmhlQjhX?=
 =?utf-8?B?QmJFRTVGK0pVWTRVL0tuTFAvVm5QOUl6YStQTEJHMng2TGxJR04yWGR2VG1t?=
 =?utf-8?B?SjU3ODMvTDlkUU1xbUo3STltRExEdVpLSnQvQUE0eHhLNkVsZ2Fyemp2Y0F2?=
 =?utf-8?B?bTh4YXJSNlZFb0plWXphZTBYY3RZeUgvdllFZkNXUzRkK202b0NBWGRPNlp3?=
 =?utf-8?B?ZEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 81a2f2f2-d4e3-406c-5d50-08db6ded0115
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 22:08:09.7512
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WzXURPr0fbInfYbfQDnAVoBFKmenIn+nlF4aeti1NGbHqcS8h+yAdvC5BsJzY2oiC9/gCj1cyvMAUDUmPEr7LJMfa/3+n1pvr1i+QH4HEJM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5108
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi James,

On 5/25/2023 11:01 AM, James Morse wrote:

...

> @@ -391,6 +407,8 @@ static void add_rmid_to_limbo(struct rmid_entry *entry)
>  	u64 val = 0;
>  	u32 idx;
>  
> +	lockdep_assert_held(&rdtgroup_mutex);
> +
>  	idx = resctrl_arch_rmid_idx_encode(entry->closid, entry->rmid);
>  
>  	entry->busy = 0;
> @@ -420,6 +438,9 @@ static void add_rmid_to_limbo(struct rmid_entry *entry)
>  		rmid_limbo_count++;
>  	else
>  		list_add_tail(&entry->list, &rmid_free_lru);
> +
> +	if (IS_ENABLED(CONFIG_RESCTRL_RMID_DEPENDS_ON_CLOSID))
> +		closid_num_dirty_rmid[entry->closid]++;

Wouldn't this always increment the counter, whether the entry is
dirty or not? (Although ... the later change where entries are
always dirty may make this correct ... although I would still
expect the if statement that precedes it to change).

Reinette