Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <348034b1-7bca-a8cf-b5bc-36c656de0bd3@intel.com>
Date:   Thu, 15 Jun 2023 15:09:12 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.11.2
Subject: Re: [PATCH v4 08/24] x86/resctrl: Allocate the cleanest CLOSID by
 searching closid_num_dirty_rmid
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>
References: <20230525180209.19497-1-james.morse@arm.com>
 <20230525180209.19497-9-james.morse@arm.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230525180209.19497-9-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGlWSWREdER0VzZQcEdyMnBmY2ppVWVuaTlCQm5hMVpQaXRMTlBqb0cyUnBa?=
 =?utf-8?B?NUFQU2ROQkIrOXYwVWlyWm5aYTMzeFNHM3l5WHl5eDg1d2pYSE9iWmloRG5M?=
 =?utf-8?B?Nm5Bb01BZXZUbkNFU1JhQTg3Z0IvVmUxNVdZYzUyK1BySk9zdU9JMGxobWN1?=
 =?utf-8?B?dS9YcHdPWFpSYXQ0NnFuNXBDL2NHcXR5NG4vSnp1OUJaOENoUnJOTzRSQmJo?=
 =?utf-8?B?dVdrSG9NcGU0MXdtSU5xaFBkcXRNRWdXQU05blM4djRSYXdLY05YQkJRZHJ0?=
 =?utf-8?B?aUFPWXk5TENjbDlYekI1RzZjVDJjUGpSWkY0eUxTUERzeDdnRmR6MFBxNHFN?=
 =?utf-8?B?YUMyVXZjcVdBRCtVNlZRU0tFTWtyRXZFV3lob0JJNEpwVTVCdCt5TFE4dDFM?=
 =?utf-8?B?dW9iTlVDQmc3SGk0K2FqalJVdGgvZzh4Qjh5RUhGNzhqZ2ZGcXJycm5YalUy?=
 =?utf-8?B?NU9nVkt6NUQ5MnNRYndaa2EvNzBieWJTaVJKdFNMVHUwbzdDTk9wMjEzbEM4?=
 =?utf-8?B?NGE3M2plNUNxbFlsdWVvSnFzRWlUc1NzSnlpTUJkZ0xuQWhDa2FXa1dNVVBt?=
 =?utf-8?B?dVdrOHpTbzRoTlVWZlpLVWgwUDhnNS9TSExEK1djdDA2bU9XTkxmZTdyUlhv?=
 =?utf-8?B?YnZwSTlqR1NFaU1tN3MxaFpsLzl2MkxxQ0R1dHJ3bnFSeWoyaWpBVGZsYzdp?=
 =?utf-8?B?QkkwbTU2WE9wL2JOV2xkWGFubkljZjVOeWFqRUN4TVJvRklGYmI2QlFST2V6?=
 =?utf-8?B?d282UVhkL3V1SEtYTUl2WlJjMWgxUlJoQ3JYWXNTbXhJU0YyaTRnelZ6WjYv?=
 =?utf-8?B?eU9pSjdEZTdUL3dkeUY1SkhGQmNTOTNORjdrUVhtN1dGZEpoTDlGRUZmV1Zp?=
 =?utf-8?B?S1JXdFAyMmZSVTh4am05V2txZ1N3VFdyOTJHQ3VVTmZCSDBmSHF2bytvckNE?=
 =?utf-8?B?THlGZmhUdERibG43MVg5d040dWpuWVdwUkxndTNMWWlmeWFGdXo2TmZSdTAy?=
 =?utf-8?B?aVlSRWVnaXBZNm1Ya0JxRk1vTDdMalZ2MGltVXBQWGd2WmlMd1Y4aGhuUzFY?=
 =?utf-8?B?M0hpblUyU0h1Mm9hSlYrNUpNZytDaDV5NUJKbzEydk15dS9YbWZjN3VKa20w?=
 =?utf-8?B?dURVRlVNME1VbkM3dHFSMTh6VW5tK0F4Z3dhSVBwT3ZqeGdQWVNpQ244SUZC?=
 =?utf-8?B?UytzTlgrMzRQdXR0M1EvVXY4WkQyc2ZZZFd3MGFJL1B6UnM5RlM3NzdvSWhV?=
 =?utf-8?B?SGMrU0JvWkU5M2pYVCtBZjY3dTc1d3RBWHhlWkhtSXY0NFk2ZFRiMFMwYkgr?=
 =?utf-8?B?NlBqUlY5WkIvWTQyWllnb1oybzlEa3F0Zng0UDRQT1c2RWRQK3NSSmpQdlF3?=
 =?utf-8?B?YlhyRWZOMFV1dmVmanp0VGd6MEw2WFpSSC9uNFdPWVBFYVJDV2NhY1I2RGly?=
 =?utf-8?B?Z090Yy9FTkdlc0t6UU9Vd3loUm9pNEhLT3pzM0p2NWhmME92VzBIcUpJckNK?=
 =?utf-8?B?dTVHR2g0ZHRPbXZWUmRQei9OM0VtZXQvRDFtenBBWVB2aFVQeFhDMUQwaXdM?=
 =?utf-8?B?YndKbk1WVmI0SUZZME8vUFBiK0R0VHhUSUlTaldmUlNLS2toUlFqZ0Vyank2?=
 =?utf-8?B?OFEzcE5EaWFHUGJIVS8rcnRwK2ZybWxoSlVhQnlGUEZYRHpMbVZPN1d2SVpH?=
 =?utf-8?B?WCtjYi9tTm1hUkJDeENzV2xXQ1YyV1NOU1hBRm1nMVVrb2JtQXMrZEZyWHNH?=
 =?utf-8?B?by9OSytpQUovSzBzN01GQmY1Kzd1c3ZOWGZTL1VCeDJ6UDdwclliQkNHRXBp?=
 =?utf-8?B?OWZjMy81T1dNNEMwZVlPV3gvYnRib3hWSmR2RjI4Q1ZFbDhkN3VBaEdtenpL?=
 =?utf-8?B?MXVTb3JSNVdtTFdTQnFwQzhpSjFZenBkSHMzbWlIck52TmlJOFRKNFM4UUtu?=
 =?utf-8?B?MDBBWjNvT056QVpFN1VDUUp3L1kyUVZWQjliZ1VTa0oyZytlYnFrdW1UVU9V?=
 =?utf-8?B?c2JoNjhQSTRJeE1RVlJ2ZDFtTlNucExjRjYwaDBVUHhpZHpIT1FYR1NMM3Bj?=
 =?utf-8?B?cERPSndNRG54RzlMQkpvN1VoZzQ0NHBzblF2YTR5TkJUKyt3ci9lQWFKM2RN?=
 =?utf-8?B?cU84VmUwQzh2b0NqbVgxTlVnNmVYcVBmK2pMWW9KMFk1cjQvdzFuNG5mNXdm?=
 =?utf-8?B?M2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4efb1c57-dc4d-4391-b7bf-08db6ded27d6
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2023 22:09:14.7827
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nJ/vSbcT7vkwsCZP0J3Rs4Ph0Mvc3QunwW5J2IsQd55wo3BfdnTToglO+7yPf6v+J1w6OnC+RY/Kv4pdQeCl4ONR7qQ21a5sUfnsYXJUOjY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5108
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi James,

On 5/25/2023 11:01 AM, James Morse wrote:

...

> diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
> index 1e7fa40ee471..128d4c7206e4 100644
> --- a/arch/x86/kernel/cpu/resctrl/monitor.c
> +++ b/arch/x86/kernel/cpu/resctrl/monitor.c
> @@ -379,6 +379,51 @@ static struct rmid_entry *resctrl_find_free_rmid(u32 closid)
>  	return ERR_PTR(-ENOSPC);
>  }
>  
> +/**
> + * resctrl_find_cleanest_closid() - Find a CLOSID where all the associated
> + *                                  RMID are clean, or the CLOSID that has
> + *                                  the most clean RMID.
> + *
> + * MPAM's equivalent of RMID are per-CLOSID, meaning a freshly allocated CLOSID
> + * may not be able to allocate clean RMID. To avoid this the allocator will
> + * choose the CLOSID with the most clean RMID.
> + *
> + * When the CLOSID and RMID are independent numbers, the first free CLOSID will
> + * be returned.
> + *
> + * Call when CONFIG_RESCTRL_RMID_DEPENDS_ON_CLOSID is defined. If not, call
> + * resctrl_closid_alloc_first_free() instead.

I was not able to find where resctrl_closid_alloc_first_free() is introduced.

> + */
> +int resctrl_find_cleanest_closid(void)
> +{
> +	u32 cleanest_closid = ~0, iter_num_dirty;
> +	int i = 0;
> +
> +	lockdep_assert_held(&rdtgroup_mutex);
> +
> +	if (!IS_ENABLED(CONFIG_RESCTRL_RMID_DEPENDS_ON_CLOSID))
> +		return -EIO;
> +
> +	for (i = 0; i < closids_supported(); i++) {
> +		if (closid_allocated(i))
> +			continue;
> +
> +		iter_num_dirty = closid_num_dirty_rmid[i];
> +		if (iter_num_dirty == 0)
> +			return i;
> +
> +		if (cleanest_closid == ~0)
> +			cleanest_closid = i;
> +
> +		if (iter_num_dirty < closid_num_dirty_rmid[cleanest_closid])
> +			cleanest_closid = i;
> +	}
> +

Reinette