Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Jun 2023 07:30:51 +0800
From:   Yixun Lan <dlan@gentoo.org>
To:     Lucas Tanure <tanure@linux.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Nick <nick@khadas.com>, Artem <art@khadas.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 5/6] tty: serial: meson: Added T7 SOC compatibility
Message-ID: <ZIufK7uK0ZrsVTZ3@ofant>
References: <20230615182938.18487-1-tanure@linux.com>
 <20230615182938.18487-6-tanure@linux.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230615182938.18487-6-tanure@linux.com>
Precedence: bulk

Hi Lucas:

On 19:29 Thu 15 Jun     , Lucas Tanure wrote:
> Make UART driver compatible with T7 SOC UART.
> 
> Signed-off-by: Lucas Tanure <tanure@linux.com>
> ---
>  drivers/tty/serial/meson_uart.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/tty/serial/meson_uart.c b/drivers/tty/serial/meson_uart.c
> index 2501db5a7aaf..0208f9a6ba7e 100644
> --- a/drivers/tty/serial/meson_uart.c
> +++ b/drivers/tty/serial/meson_uart.c
> @@ -796,6 +796,10 @@ static const struct of_device_id meson_uart_dt_match[] = {
>  		.compatible = "amlogic,meson-s4-uart",
>  		.data = (void *)&meson_g12a_uart_data,
>  	},
> +	{
> +		.compatible = "amlogic,meson-t7-uart",
> +		.data = (void *)&meson_g12a_uart_data,
I think you are trying to follow previous s4 scheme - to introduce a new
compatible string, while I think it's not necessary or even wrong, this will just
make the dt_match_list longer but without obvious benefits..

as Conor already raised this question in previous dt-binding patch[4/6],
how about just using 'amlogic,meson-g12a-uart' which is the first compatible
introduced.

if people agree, we could also drop 'amlogic,meson-s4-uart' since it use same
compatible data as gl12a, anyway it should be separated into another patch..

> +	},
>  	{ /* sentinel */ },


>  };
>  MODULE_DEVICE_TABLE(of, meson_uart_dt_match);
> --
> 2.41.0
> 
> 
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic

-- 
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55