Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3a241bc5-0fb9-7d80-1746-84c822a81a27@intel.com>
Date:   Fri, 16 Jun 2023 09:00:30 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v3 00/21] Enable CET Virtualization
To:     Sean Christopherson <seanjc@google.com>
CC:     <pbonzini@redhat.com>, <kvm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <peterz@infradead.org>,
        <rppt@kernel.org>, <binbin.wu@linux.intel.com>,
        <rick.p.edgecombe@intel.com>, <john.allen@amd.com>
References: <20230511040857.6094-1-weijiang.yang@intel.com>
 <ZIufL7p/ZvxjXwK5@google.com> <ZIumMeRxDzzcKpUh@google.com>
Content-Language: en-US
From:   "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <ZIumMeRxDzzcKpUh@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cmdxMWJnZFIvd2RDNW5sSklLWnByUThuazcvWTRpcjhCOTJFa0lCbFVzME9i?=
 =?utf-8?B?R1lmRzE3YTkvUmZwUlpVNmpsVkxXVTdtUWxUTFVTck5zT3F2OVQ4MUVZRzlL?=
 =?utf-8?B?b2RnOHgxZXErYmRYS1NKSzFzcURqVUNxN2tjUGVJdlRUZVFLemNsdGlLd3VN?=
 =?utf-8?B?Wi9mWlQ0UmpodTRiUXowSkdHWWR2OFJYU2hwRlhUYURhRk5za0QvNmp5cXoz?=
 =?utf-8?B?dXYyZFhLckwxUFJlNmZ5ZWFmWW1RUjhpd25TUklGanBFM0FJcGwzZmkrYXhQ?=
 =?utf-8?B?eUpCdGVKa0dNakZmY24wSDB3cGJxbWh0VHdBUzkycktTalZMdGoremo5Y1B0?=
 =?utf-8?B?eTVlV3hFeUcwQkpaemNZd3hDbDNEUjZmdXBURHZYSXBTckdyTDdkdmtUbmVD?=
 =?utf-8?B?d2lRZ3dSbWdocC93ODBCVTFQUzRVUHZKVmhZcTV6eitnZm1DWUs5VEhGQ3Ft?=
 =?utf-8?B?T0ZXazdlOFRNMDBscnpLOVVBUWZMbFJzd0lKNWFSUHpNOGNjN0FoMVhGUGkr?=
 =?utf-8?B?bTF4bGJyRUk5SVhmTVZRR211K2NNUjZORWlwWXJpVE5URkF1dU5ad0FLUi92?=
 =?utf-8?B?d2hsaFpkRVMzUEg1UVYyYTJRL29iWGdhYUdnNDh0MnNhbGdQSEswbENKQU9a?=
 =?utf-8?B?bmZMbTlRd2dyZUFVZGRqTzdqWUptbS9NaGs3WUNBc3M3ajJkbWQzcXl0dXZO?=
 =?utf-8?B?T01yQmhrV01QM2Z3ZGtMZkptekl4ZXJYTzAzYWZtTmV0aGFiVEFmOXJLTExZ?=
 =?utf-8?B?SUN2MkxJOXlPSUNrWkpramx5dmhNczZJRmFyd2F1eUs1bFpNMlhKUU85eWVL?=
 =?utf-8?B?MzAyMzJ5YitBVHNvclNlSGw4QUdHU1lWOFRueE9LY0xYUHNaOTFtVERkOTdP?=
 =?utf-8?B?c081YXlpT2M5TzJTYTA2OHVrZWN3anI2WHY2WldDQ2RxS05uaGNzaGcrTXVF?=
 =?utf-8?B?ZXRPZjN1dURuSTBzTU1aRWRDanFuR3h3QVU4RGdRTnNPN3B0UXY1djIxaFYy?=
 =?utf-8?B?VFZQY2VvL2VSQXhqQmY1OU0xWHZCQ1NwM3VTbjFBaFBsOVBib1dLenpzUy84?=
 =?utf-8?B?TW5nSTZEUEtoekV6QS9JME91NzdZZG1pc2hEL2pwcGh5TzU3dlI5am5xN3Yr?=
 =?utf-8?B?ajMvWDlleWNoNXN5R0xZSnoxcFEzdUZNZmxuaWxiWmtsOXBCY0YvWUc0RURR?=
 =?utf-8?B?UUJ2TFlCZE9FWTJYd2ZCTS82Yk9kQzh2a1lVMmxUb1NRWEExWUpGNFBvdEFa?=
 =?utf-8?B?RFhqcVc1cWpOUUFaS296UzZoUE9XKzdGT2RvcXV5NWlWOWw5OGpqQVNMVW1m?=
 =?utf-8?B?VFF0b3BDZEhjdkw3NGJjeTVweC9SVlFlaWdpWURHYU9pOFZsRGxPTDRQakhT?=
 =?utf-8?B?cDBKNnk4Q0pRUVUvWFVqS1RBcHZyNXJSTk9iakh6amRUUFY5Q20za0RwTXpk?=
 =?utf-8?B?VHdBNE1saVh4R2tYSkM1VW5IUlhqQklYaFJiWDYxckliVFNMeUI0bXFCalAx?=
 =?utf-8?B?azRDUUV2WEJoU255Q1hmRVF4UmtnVVJqMWNCMGpJOWJKSy9HSVJSdlExN2hy?=
 =?utf-8?B?Tzh5ZU93OTVQd1dRL2lGMWwvS0NjalcwaXZMWlF6b1B0SEJyNWZzSXBDTjIy?=
 =?utf-8?B?b2pldDRpWENEZms4SVEwdzZzbGY5VFRQSlpnbzc4S3hIaE9iZnc0Y0ZHU1Ji?=
 =?utf-8?B?VWdvd0l6ak45bkhsaHpqbHAvKzJwZEtDdzhWOE9PcFBCSnM0Q1IwM2c0ZEhE?=
 =?utf-8?B?aVlCZk4yVmZMdHlzMGRRT3ZTcXVhbmJnM21PVllEVURDNDA0TkJoNGtrcWtR?=
 =?utf-8?B?Y0dQVXZ2M1pwZzJlZHkvdDMxVFEra1BZK3d3cExxQjRzTy8yWTkzNEhNeDJM?=
 =?utf-8?B?cVhPWkZEYXNGQVBIK1RVRHRZQmMyclpDN2pCbUNNaTF1MVJpeXRLK2p6bXBU?=
 =?utf-8?B?MDgzWEhVNUpLemxuZ3VzMVJ2U052VjlSK1BkMzUwcjhudUpOdG9xOGlYUnNF?=
 =?utf-8?B?bGZ5aUx3TmNOQU9LZk5WNGh2c011UDZEZUFKNnZhY0w0cDlpSzJQTDNvS2lE?=
 =?utf-8?B?YW9UTnZKRmxvMnRmVzQ1N1QxUDJjYkxlRTRUZjNIVXJGL1IzZjZWc2xQaFI5?=
 =?utf-8?B?dkN6SEs1cXpHYmpURXpjVnpNbC9SOW9SK29rdURRMTQ0bXJybU85T1I5NC96?=
 =?utf-8?B?N1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c9a7b338-c0c0-4437-b83c-08db6e051a0b
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 01:00:39.7083
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UUiX+ZZXmYwS4PeET7p5p8QItZ3xJICIRIpy9hIhOeNOeoYQGyrkPyXVYr7twKzYpjnA9lZsdYlR8RT1A5pD7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB8022
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/16/2023 8:00 AM, Sean Christopherson wrote:
> On Thu, Jun 15, 2023, Sean Christopherson wrote:
>> Your cover letter from v2 back in April said the same thing.  Why hasn't the patch
>> been posted?  And what exactly is the issue?  IIUC, setting CR4.CET with
>> MSR_IA32_S_CET=0 and MSR_IA32_U_CET=0 should be a nop, which suggests that there's
>> a KVM bug.  And if that's the case, the next obvious questions is, why are you
>> posting known buggy code?
> Ah, is the problem that the test doesn't set CR0.WP as required by CR4.CET=1?

Thanks for taking time to review this series!

Yes, due to CR0.WP bit is not set while CR4.CET is being set.

The check is imposed by patch-12.

I'll add the fixup patch together with next the version.