Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <2e467eb4-d680-df7b-9174-b9d6b6071a63@intel.com>
Date:   Fri, 16 Jun 2023 09:37:45 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH] iommu/vt-d: Fix to flush cache of PASID directory table
To:     "Zhang, Tina" <tina.zhang@intel.com>,
        "dwmw2@infradead.org" <dwmw2@infradead.org>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "will@kernel.org" <will@kernel.org>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>
CC:     "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20230615071613.690639-1-yanfei.xu@intel.com>
 <MW5PR11MB5881C833CBC14D106DD9A8B5895BA@MW5PR11MB5881.namprd11.prod.outlook.com>
Content-Language: en-CA
From:   Yanfei Xu <yanfei.xu@intel.com>
In-Reply-To: <MW5PR11MB5881C833CBC14D106DD9A8B5895BA@MW5PR11MB5881.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmJWamFXV0tYZG1weWg3UUR5TEUrZjk0R2oreWpxSFBlb05MbHBkZkxPb251?=
 =?utf-8?B?RjFITDg5MFRZc21JSlBoa2txamRqRUZjZlZsODIvZUZTVDM5OFhrSmRCT0do?=
 =?utf-8?B?RFRzY1MwUDNTNUpVd0pLbUdWemZqTDFpTnAxbkNoTU5DU3pTUFJtazM4TkNT?=
 =?utf-8?B?NjhSRXpFMFprQWxzOHY4UVc4clUzaWM0cnc3Z2NKNjZmYnpocGRSbU9OK2Ji?=
 =?utf-8?B?M0ZHNkVDTjlwb3grSnB4WFYrR1diaTZKaThzNm5mNTBUbDNCNG5jNUltMjdt?=
 =?utf-8?B?a2pvSWF1T3hoWDZEUFpsTFVFKzNpcTUwaW0yMUhLWW9rZW96MkJDblNPQWMz?=
 =?utf-8?B?ZnNWYWdUUXdueWtWazhUem1oTzdBT0FsdzM2c09KVENNZWljcnNKRHpSSDdJ?=
 =?utf-8?B?Z1VXWWZ6KzNNMDg5L2NnMzA2TTg5WTNwamMwUW1RTEN1K3BkakRxdWpaZUxu?=
 =?utf-8?B?MlFiMUJxcHBNc2M2V09qWUFUMnJEQk9XRVFaMlpIQitKU1Iwc05Vcm1UNUI3?=
 =?utf-8?B?d2VuTDVsTnlwSUJUbkVHZG5ZUWtMNlF1N0tSd3M2R0tVSlBld2w4QW1SMXQz?=
 =?utf-8?B?d2Jic21PWXR6cDcrYklISGIvOFF5cWx4V3dYOHpqWU1QL0N3bkQ4Y2l2bm9D?=
 =?utf-8?B?eTV3YXpHOHhFUS9Kd2ROSDFpSHZDSUo4VEd1NlR4cmhJbTU1bVhNSDd0NHdN?=
 =?utf-8?B?NFhwYkg4ZDNjcURCekdaSzlUR3ZVaU5oTDJTKzFqUDNWalVXWDJleTgyd2pp?=
 =?utf-8?B?MGZZbHZTNTR5c0FlRm04QWpCUXg0Vld6eUFaR0Z2UkQ5WGxpS1lnc3hENU10?=
 =?utf-8?B?YWtuOUJiUVVoOWhWYm5MdHQwSW9zdXNLUi9IRjcvUHc0RzJpaDFEa3I3aTB5?=
 =?utf-8?B?a1R5TVhSeE5UaTdkN1lQYmNLM2w2aHoyN1pzVjFpYzBTTHNML1JWbklJU2wv?=
 =?utf-8?B?Q0k5Y0k1L3Z2MVdkRTdOS2VkcWErQms0VXpLWlFwTVdHeEJUa3NtUTQrdHox?=
 =?utf-8?B?dWFzUktpNkRPbFl2U1VuckMzYlp6QzRqc2Y4WCttdjNGVHdNdVI1a2M3aTlv?=
 =?utf-8?B?L3FMSitDL1U4ekg5WXJpaXJLdWNIQXhxcWNLcFlZUWdGY0VSZTA2TUEwVnhm?=
 =?utf-8?B?Zmg3NkxCbllvaThEdjA5a3V4WGlEcStLTnBDZUFIRUhMRzNBOUdBaUxzcnE1?=
 =?utf-8?B?ZzdwQ2lMQkU5Nm9NNllmYks3R2trcFR1RFR5UHA4QjMzSlpybjM5R05RWWs0?=
 =?utf-8?B?STdyY2NRekFaUWpvRmd0TWRNeitEYW1FenhOdklPTGdGaEd5ODkxYk82akpo?=
 =?utf-8?B?WGtYMktZZENra3o2MjVSS0NzeURYcVJiTXYwVjQwR2N3RFpMeHZoR2x1bGtn?=
 =?utf-8?B?U2F6YVdkKytaRUJoUVhwSldFZGhBb1hMNXh0STA2OGw0bjExZXBoY2JXcG9V?=
 =?utf-8?B?VGhRSW1CeWpmbUkxU2Vvckg4alpkT2NYMDBIM3VxazhqWlpYVzNBc1VoS0NQ?=
 =?utf-8?B?UFZOYVhBYXdyK3NQR1QrdzMySnlyMitob3dyNVpiUjhudXptWmZZOVFjRTdE?=
 =?utf-8?B?U2dQS2Z5NUwxZUZPYVM5ZzFScTkxM3VkQU01YkRYenZRWm9lUkZoZWZUUTNM?=
 =?utf-8?B?RjlxZ2UvdS9XbjhmZ1V0aWdmUzF2T2xBRFo0ZTJRSFA0RjNpYlZOVnFsVThL?=
 =?utf-8?B?eHRlK1J6VUZUZTVpS2tzUkhZd2QvVEdVQ0E4c3JSZ1p6R25tb0FVWDlXcTlp?=
 =?utf-8?B?alFSRWFkMmhMUXV6RGE2WXVtbWFVTGVweVd4bVNmczl2eU1Ec3Bjc2s0cmNY?=
 =?utf-8?B?SjF1MnJnR2pvTUdNWng3UEZMcjVQUWpYNWp2eXRJR2tGQ2N1NXA3V1NRTlVp?=
 =?utf-8?B?LzlxSlFVR05JbGZlVlBrSVdLMWRHU3lLRUhjOUtkQkplTk9GeEs3dDA0VlpL?=
 =?utf-8?B?K3BFazVZcExzQ0VaeThDQ2VMelQ1TkVTek9rQ2lNOXFMYWluekdtQVppR3Mx?=
 =?utf-8?B?ekhFM0RLQWl4aktuUjFPcVhLUGdCWnI2bTFxQ3RyTEdhaTZIanlQdkU2Qzc0?=
 =?utf-8?B?TCsveVhlMWJwcE1WdXVaVGNtUlg3a0pHcmVhUGlaS0tRZGlobFNWN1JBKzhF?=
 =?utf-8?Q?WhR4bpxIAv0TNyapKNmCOQlhI?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6714091c-d5df-47ff-3146-08db6e0a4e92
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4138.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jun 2023 01:37:55.4784
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bIVgM2QWFP8coeHeJ/0SLdbkn7Or6QbOpubqQbdW9DAR1AprYOGFk7VpyPqWgRW+VJQXgfdd80eKmkwv+BnUHQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5029
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/16/2023 7:43 AM, Zhang, Tina wrote:
> Hi,
>
>> -----Original Message-----
>> From: Yanfei Xu <yanfei.xu@intel.com>
>> Sent: Thursday, June 15, 2023 3:16 PM
>> To: dwmw2@infradead.org; baolu.lu@linux.intel.com; joro@8bytes.org;
>> will@kernel.org; robin.murphy@arm.com
>> Cc: iommu@lists.linux.dev; linux-kernel@vger.kernel.org; Xu, Yanfei
>> <yanfei.xu@intel.com>
>> Subject: [PATCH] iommu/vt-d: Fix to flush cache of PASID directory table
>>
>> Even the PCI devices don't support pasid capability, PASID table is mandatory
>> for a PCI device in scalable mode. However flushing cache of pasid directory
>> table for these devices are not taken after pasid table is allocated as the "size"
>> of table is zero. Fix to assign it with a page size.
>>
>> Fixes: 194b3348bdbb ("iommu/vt-d: Fix PASID directory pointer coherency")
>> Signed-off-by: Yanfei Xu <yanfei.xu@intel.com>
>> ---
>>   drivers/iommu/intel/pasid.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/iommu/intel/pasid.c b/drivers/iommu/intel/pasid.c index
>> c5d479770e12..bde7df055865 100644
>> --- a/drivers/iommu/intel/pasid.c
>> +++ b/drivers/iommu/intel/pasid.c
>> @@ -115,7 +115,9 @@ int intel_pasid_alloc_table(struct device *dev)
>>   				  intel_pasid_max_id);
>>
>>   	size = max_pasid >> (PASID_PDE_SHIFT - 3);
>> -	order = size ? get_order(size) : 0;
>> +	if (!size)
>> +		size = PAGE_SIZE;
> How about merging the logic of the above few lines into this one:
> size = info->pasid_supported ? max_pasid >> (PASID_PDE_SHIFT - 3) : PAGE_SIZE;

Yes, it would be more intuitive. But the prerequisite is if we can
make sure that the value of max_pasid shifted is still greater than
0. I roughly went through the PCIE spec and didn't find out where
defines the smallest PASID value for the PCIE device.

Thanks,
Yanfei

> Though the logic is about the same, the suggested one seems more intuitive.
>
> Regards,
> -Tina
>
>> +	order = get_order(size);
>>   	pages = alloc_pages_node(info->iommu->node,
>>   				 GFP_KERNEL | __GFP_ZERO, order);
>>   	if (!pages) {
>> --
>> 2.34.1
>>