Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230615091757.24686-1-zhuyinbo@loongson.cn> <968b7c81-a24e-1e0d-31a4-f633a82d17b0@loongson.cn>
 <CAAhV-H4Z13wpOsj5GxkuwMK1D6N6=sArQ52yHjcdiEen=dUpjg@mail.gmail.com>
 <9edfe58a-7901-c2d1-8e01-5f10b3a51287@loongson.cn> <a9292d85-83b5-5b43-6c2a-7e393213c6c9@loongson.cn>
In-Reply-To: <a9292d85-83b5-5b43-6c2a-7e393213c6c9@loongson.cn>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Fri, 16 Jun 2023 09:54:22 +0800
Message-ID: <CAAhV-H4-LCryuQKJrwE65w5BZ66a6PQAq+ZT8mqE7vHa7L3_zw@mail.gmail.com>
Subject: Re: [PATCH v3 3/3] soc: loongson2_pm: add power management support
To:     zhuyinbo <zhuyinbo@loongson.cn>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        WANG Xuerui <kernel@xen0n.name>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Pavel Machek <pavel@ucw.cz>, Marc Zyngier <maz@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        loongarch@lists.linux.dev, Jianmin Lv <lvjianmin@loongson.cn>,
        wanghongliang@loongson.cn, Liu Peibao <liupeibao@loongson.cn>,
        loongson-kernel@lists.loongnix.cn
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi, Yinbo,

On Fri, Jun 16, 2023 at 9:45=E2=80=AFAM zhuyinbo <zhuyinbo@loongson.cn> wro=
te:
>
>
> Hi huacai,
>
>
> =E5=9C=A8 2023/6/15 =E4=B8=8B=E5=8D=887:15, zhuyinbo =E5=86=99=E9=81=93:
> >
> >
> > =E5=9C=A8 2023/6/15 =E4=B8=8B=E5=8D=886:00, Huacai Chen =E5=86=99=E9=81=
=93:
> >
> >>> +static void loongson2_pm_status_clear(void)
> >>> +{
> >>> +       u16 value;
> >>> +
> >>> +       value =3D loongson2_pm_readw(LOONGSON2_PM1_STS_REG);
> >>> +       value |=3D (LOONGSON2_PM1_PWRBTN_STS |
> >>> LOONGSON2_PM1_PCIEXP_WAKE_STS |
> >>> +                 LOONGSON2_PM1_WAKE_STS);
> >>> +       loongson2_pm_writew(value, LOONGSON2_PM1_STS_REG);
> >>> +       loongson2_pm_writel(loongson2_pm_readl(LOONGSON2_GPE0_STS_REG=
),
> >>> +                           LOONGSON2_GPE0_STS_REG);
> >> Long-line warnings is removed in latest kernel, so you don't need to
> >> split here.
> >
> >
> > okay, I got it.
> >
> >>
> >>> +}
> >>> +
> >>> +static void loongson2_power_button_irq_enable(void)
> >>
> >> Using loongson2_pm_irq_enable is a little better.
> >
> >
>
> Previously, you suggested that I combine loongson2_pm_irq_enable() and
> power button irq enable code as loongson2_power_button_irq_enable, then
> I remove the function loongson2_pm_irq_enable, in this case that I won't
> be able to call loongson2_pm_irq_enable, so have I misunderstood your
> meaning ? or only rename loongson2_power_button_irq_enable as
> loongson2_pm_irq_enable ?
I'm very sorry for that. At first I only wanted to combine two
functions, but then I found the name  loongson2_pm_irq_enable is
better. So just rename is OK. Thanks.

Huacai
>
> Thanks,
> Yinbo
>
> >
> > ...
> >
> >>> +static int loongson2_suspend_valid_state(suspend_state_t state)
> >>> +{
> >>> +       if (state =3D=3D PM_SUSPEND_MEM)
> >>> +               return 1;
> >>> +
> >>> +       return 0;
> >> "return (state =3D=3D PM_SUSPEND_MEM)" is enough.
> >
> >
> > okay, I got it.
> >
> >
> > Thanks,
> > Yinbo
> >
>
>