Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761580AbXJQSXb (ORCPT ); Wed, 17 Oct 2007 14:23:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756852AbXJQSXW (ORCPT ); Wed, 17 Oct 2007 14:23:22 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:39810 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757346AbXJQSXV (ORCPT ); Wed, 17 Oct 2007 14:23:21 -0400 Date: Wed, 17 Oct 2007 11:22:39 -0700 (PDT) From: Linus Torvalds To: Jens Axboe cc: Ingo Molnar , linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [bug] block subsystem related crash with latest -git In-Reply-To: Message-ID: References: <20071017154655.GA13394@elte.hu> <20071017165949.GF15552@kernel.dk> <20071017170804.GG15552@kernel.dk> <20071017180042.GP15552@kernel.dk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 844 Lines: 22 On Wed, 17 Oct 2007, Linus Torvalds wrote: > > So I think your change to use "sg_next()" only when you actually need a > next pointer is the correct one after all. That still leaves the initialization issue. The link pointers need to all be initialized at SG allocation time (and not just the last one for the case where it's a linked entry). And if you initialize them at allocation time, does an allocation ever get re-used without being free'd in between (if it does, you do indeed need to initialize the non-link pointers each time - but I don't see it being the case, so ..) Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/